| Message ID | 20180605121232.7121-1-digetx@gmail.com |
|---|---|
| State | Deferred |
| Headers | show |
| Series | [v1] clk: tegra: emc: Avoid out-of-bounds bug | expand |
Quoting Dmitry Osipenko (2018-06-05 05:12:32) > Apparently there was an attempt to avoid out-of-bounds accesses when there > is only one memory timing available, but there is a typo in the code that > neglects that attempt. > > Signed-off-by: Dmitry Osipenko <digetx@gmail.com> Fixes: tag? -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tuesday, 12 June 2018 10:46:03 MSK Stephen Boyd wrote: > Quoting Dmitry Osipenko (2018-06-05 05:12:32) > > > Apparently there was an attempt to avoid out-of-bounds accesses when there > > is only one memory timing available, but there is a typo in the code that > > neglects that attempt. > > > > Signed-off-by: Dmitry Osipenko <digetx@gmail.com> > > Fixes: tag? This is kinda a minor fix for an issue that shouldn't happen because today AFAIK nothing on Tegra imposes the max/min clock rate constraints. There is no need to backport this patch. -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoting Dmitry Osipenko (2018-06-05 05:12:32) > Apparently there was an attempt to avoid out-of-bounds accesses when there > is only one memory timing available, but there is a typo in the code that > neglects that attempt. > > Signed-off-by: Dmitry Osipenko <digetx@gmail.com> > --- Applied to clk-next -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/clk/tegra/clk-emc.c b/drivers/clk/tegra/clk-emc.c index 5234acd30e89..0621a3a82ea6 100644 --- a/drivers/clk/tegra/clk-emc.c +++ b/drivers/clk/tegra/clk-emc.c @@ -132,7 +132,7 @@ static int emc_determine_rate(struct clk_hw *hw, struct clk_rate_request *req) timing = tegra->timings + i; if (timing->rate > req->max_rate) { - i = min(i, 1); + i = max(i, 1); req->rate = tegra->timings[i - 1].rate; return 0; }
Apparently there was an attempt to avoid out-of-bounds accesses when there is only one memory timing available, but there is a typo in the code that neglects that attempt. Signed-off-by: Dmitry Osipenko <digetx@gmail.com> --- drivers/clk/tegra/clk-emc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)