Message ID | 20180609192028.4511-1-bwiedemann@suse.de |
---|---|
State | New |
Headers | show |
Series | ltmain.sh: Sort input file list | expand |
If we're not doing a general update from upstream libtool, I think we should use the upstream ltmain.sh fix (libtool commit 74c8993c178a1386ea5e2363a01d919738402f30, it looks like), or follow it as close as possible, rather than having our own variant.
On 2018-06-11 17:06, Joseph Myers wrote: > If we're not doing a general update from upstream libtool, I think we > should use the upstream ltmain.sh fix (libtool commit > 74c8993c178a1386ea5e2363a01d919738402f30, it looks like), or follow it as > close as possible, rather than having our own variant. right. Either variant should be fine. Cherry-picking it, is the safe variant.
On 06/11/2018 11:06 AM, Joseph Myers wrote: > If we're not doing a general update from upstream libtool, I think we > should use the upstream ltmain.sh fix (libtool commit > 74c8993c178a1386ea5e2363a01d919738402f30, it looks like), or follow it as > close as possible, rather than having our own variant. > Agreed. My preference would be to get the various libtool, autoconf and friends updated from the appropriate upstream projects. jeff
On 6/11/18, Jeff Law <law@redhat.com> wrote: > On 06/11/2018 11:06 AM, Joseph Myers wrote: >> If we're not doing a general update from upstream libtool, I think we >> should use the upstream ltmain.sh fix (libtool commit >> 74c8993c178a1386ea5e2363a01d919738402f30, it looks like), or follow it as >> >> close as possible, rather than having our own variant. >> > Agreed. My preference would be to get the various libtool, autoconf and > friends updated from the appropriate upstream projects. > > jeff > Thread from the last time this came up is here: https://gcc.gnu.org/ml/gcc/2017-10/msg00060.html
diff --git a/ltmain.sh b/ltmain.sh index 9503ec85d..96311a12c 100644 --- a/ltmain.sh +++ b/ltmain.sh @@ -2932,7 +2932,7 @@ func_extract_archives () func_extract_an_archive "$my_xdir" "$my_xabs" ;; esac - my_oldobjs="$my_oldobjs "`find $my_xdir -name \*.$objext -print -o -name \*.lo -print | $NL2SP` + my_oldobjs="$my_oldobjs "`find $my_xdir -name \*.$objext -print -o -name \*.lo -print | LC_ALL=C sort | $NL2SP` done func_extract_archives_result="$my_oldobjs"