| Message ID | 1528640149-2195-1-git-send-email-pawel.mikolaj.chmiel@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [1/1] ARM: dts: s5pv210: Add missing interrupt-controller property to gph2 | expand |
On Sun, Jun 10, 2018 at 4:15 PM, Paweł Chmiel <pawel.mikolaj.chmiel@gmail.com> wrote: > This commit adds missing interrupt-controller property to gph2 block, Just "Add missing". See: https://elixir.bootlin.com/linux/latest/source/Documentation/process/submitting-patches.rst#L151 > to silence following warnings during build > /soc/pinctrl@e0200000/gph2: Missing interrupt-controller or interrupt-map property > > Observed on not yet mainlined, an S5PV210 based > Samsung Galaxy S (i9000) phone. The warning is not reproduceable (as you mentioned board is not present in mainline) thus please skip it. Instead, either describe existing reason for this change (e.g. because bindings require it for node of every bank of pins supporting GPIO interrupts) or include this in series mainlining new board (where the reason will be - it will be used by new board etc). Best regards, Krzysztof
On Monday, June 11, 2018 2:43:59 PM CEST Krzysztof Kozlowski wrote: > On Sun, Jun 10, 2018 at 4:15 PM, Paweł Chmiel > <pawel.mikolaj.chmiel@gmail.com> wrote: > > This commit adds missing interrupt-controller property to gph2 block, > > Just "Add missing". See: > https://elixir.bootlin.com/linux/latest/source/Documentation/process/submitting-patches.rst#L151 > > > to silence following warnings during build > > /soc/pinctrl@e0200000/gph2: Missing interrupt-controller or interrupt-map property > > > > Observed on not yet mainlined, an S5PV210 based > > Samsung Galaxy S (i9000) phone. > > The warning is not reproduceable (as you mentioned board is not > present in mainline) thus please skip it. Instead, either describe > existing reason for this change (e.g. because bindings require it for > node of every bank of pins supporting GPIO interrupts) or include this > in series mainlining new board (where the reason will be - it will be > used by new board etc). > > Best regards, > Krzysztof > Ok, I'll send this patch (fixed) with other patches adding new board. Thanks
diff --git a/arch/arm/boot/dts/s5pv210-pinctrl.dtsi b/arch/arm/boot/dts/s5pv210-pinctrl.dtsi index 3a79feab11c3..7f0c9d447871 100644 --- a/arch/arm/boot/dts/s5pv210-pinctrl.dtsi +++ b/arch/arm/boot/dts/s5pv210-pinctrl.dtsi @@ -258,6 +258,8 @@ gph2: gph2 { gpio-controller; #gpio-cells = <2>; + + interrupt-controller; #interrupt-cells = <2>; };
This commit adds missing interrupt-controller property to gph2 block, to silence following warnings during build /soc/pinctrl@e0200000/gph2: Missing interrupt-controller or interrupt-map property Observed on not yet mainlined, an S5PV210 based Samsung Galaxy S (i9000) phone. Signed-off-by: Paweł Chmiel <pawel.mikolaj.chmiel@gmail.com> --- arch/arm/boot/dts/s5pv210-pinctrl.dtsi | 2 ++ 1 file changed, 2 insertions(+)