| Message ID | 20180606093441.16483-1-peron.clem@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | ARM: dts: cygnus: Add HWRNG node | expand |
Hi Clement, On 18-06-06 02:34 AM, Clément Péron wrote: > From: Clément Peron <clement.peron@devialet.com> > > There is a HWRNG in Broadcom Cygnus SoC, so enable it. > > Signed-off-by: Clément Peron <clement.peron@devialet.com> Thanks for upstreaming some missing Cygnus components. But, the problem is the tarball release from Broadcom you are extracting these changes from does not contain git history; so, you are missing the original authors and signed-off's. I checked our internal git repository and for this commit the author is: Mohamed Ismail Abdul Packir Mohamed <mohamed-ismail.abdul@broadcom.com> Please adjust author and signed-off appropriately. If there are other changes you are extracting from the source tarballs you have please contact me so we can construct patch appropriately. Regards, Scott > --- > arch/arm/boot/dts/bcm-cygnus.dtsi | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/arm/boot/dts/bcm-cygnus.dtsi b/arch/arm/boot/dts/bcm-cygnus.dtsi > index 1cee40ac4613..b7178e84d56d 100644 > --- a/arch/arm/boot/dts/bcm-cygnus.dtsi > +++ b/arch/arm/boot/dts/bcm-cygnus.dtsi > @@ -452,6 +452,11 @@ > status = "disabled"; > }; > > + hwrng: hwrng@18032000 { > + compatible = "brcm,iproc-rng200"; > + reg = <0x18032000 0x28>; > + }; > + > sdhci0: sdhci@18041000 { > compatible = "brcm,sdhci-iproc-cygnus"; > reg = <0x18041000 0x100>;
On 06/06/2018 09:03 AM, Scott Branden wrote: > Hi Clement, > > > On 18-06-06 02:34 AM, Clément Péron wrote: >> From: Clément Peron <clement.peron@devialet.com> >> >> There is a HWRNG in Broadcom Cygnus SoC, so enable it. >> >> Signed-off-by: Clément Peron <clement.peron@devialet.com> > Thanks for upstreaming some missing Cygnus components. > > But, the problem is the tarball release from Broadcom you are extracting > these changes from does not contain git history; so, you are missing the > original authors and signed-off's. > I checked our internal git repository and for this commit the author is: > Mohamed Ismail Abdul Packir Mohamed <mohamed-ismail.abdul@broadcom.com> > > Please adjust author and signed-off appropriately. If there are other > changes you are extracting from the source tarballs you have please > contact me so we can construct patch appropriately. If you want the original author's Signed-off-by to be preserved, why don't you extract it from your internal git tree and submit the patch on Mohamed's behalf? AFAICT what Clement is doing here is permissible given the Linux developer certificate of origin though I am not a lawyer of course.
Hi Scott, Florian, On Wed, 6 Jun 2018 at 18:47, Florian Fainelli <f.fainelli@gmail.com> wrote: > > On 06/06/201 8 09:03 AM, Scott Branden wrote: > > Hi Clement, > > > > > > On 18-06-06 02:34 AM, Clément Péron wrote: > >> From: Clément Peron <clement.peron@devialet.com> > >> > >> There is a HWRNG in Broadcom Cygnus SoC, so enable it. > >> > >> Signed-off-by: Clément Peron <clement.peron@devialet.com> > > Thanks for upstreaming some missing Cygnus components. > > > > But, the problem is the tarball release from Broadcom you are extracting > > these changes from does not contain git history; so, you are missing the > > original authors and signed-off's. > > I checked our internal git repository and for this commit the author is: > > Mohamed Ismail Abdul Packir Mohamed <mohamed-ismail.abdul@broadcom.com> > > > > Please adjust author and signed-off appropriately. If there are other > > changes you are extracting from the source tarballs you have please > > contact me so we can construct patch appropriately. > > If you want the original author's Signed-off-by to be preserved, why > don't you extract it from your internal git tree and submit the patch on > Mohamed's behalf? > > AFAICT what Clement is doing here is permissible given the Linux > developer certificate of origin though I am not a lawyer of course. > -- > Florian Totally not my goal to steal the author and agree to keep track of the original author as soon as it's possible. I didn't though it was important for this patch as the same code is available in the dt-bindings documentation. Actually there are still some buggy components like DSA (Arun proposed a patch this morning) the PWM (config and delay aren't correct) and I2C. These are mainlined but can't be used and need a minimal effort to correctly work on Cygnus. Also there are some important components like USB Phy or Mailbox that were proposed and almost made it, but just need a small modification to be accepted. My idea was just to submit small patches that are trivial to review. In order to avoid keeping lots of patches in our kernel and also have something functional when building a mainline kernel. Regards, Clement
On 18-06-06 09:47 AM, Florian Fainelli wrote: > On 06/06/2018 09:03 AM, Scott Branden wrote: >> Hi Clement, >> >> >> On 18-06-06 02:34 AM, Clément Péron wrote: >>> From: Clément Peron <clement.peron@devialet.com> >>> >>> There is a HWRNG in Broadcom Cygnus SoC, so enable it. >>> >>> Signed-off-by: Clément Peron <clement.peron@devialet.com> >> Thanks for upstreaming some missing Cygnus components. >> >> But, the problem is the tarball release from Broadcom you are extracting >> these changes from does not contain git history; so, you are missing the >> original authors and signed-off's. >> I checked our internal git repository and for this commit the author is: >> Mohamed Ismail Abdul Packir Mohamed <mohamed-ismail.abdul@broadcom.com> >> >> Please adjust author and signed-off appropriately. If there are other >> changes you are extracting from the source tarballs you have please >> contact me so we can construct patch appropriately. > If you want the original author's Signed-off-by to be preserved, why > don't you extract it from your internal git tree and submit the patch on > Mohamed's behalf? Sure, I can submit the original patch to keep things simple and avoid finding a lawyer right now. > > AFAICT what Clement is doing here is permissible given the Linux > developer certificate of origin though I am not a lawyer of course. But, It would be great to get some guidance and clarification on this for sure. I'm reading: https://www.kernel.org/doc/html/v4.16/process/submitting-patches.html The change was created entirely by Broadcom, so seems difficult for somebody else to upstream change without appropriate authorship and signed off from copyright holder. Point a) and b) are not met in Developer's Certificate of Origin while point c) is being attempted (without a or b being certified).
On 18-06-06 10:06 AM, Clément Péron wrote: > Hi Scott, Florian, > > On Wed, 6 Jun 2018 at 18:47, Florian Fainelli <f.fainelli@gmail.com> wrote: >> On 06/06/201 8 09:03 AM, Scott Branden wrote: >>> Hi Clement, >>> >>> >>> On 18-06-06 02:34 AM, Clément Péron wrote: >>>> From: Clément Peron <clement.peron@devialet.com> >>>> >>>> There is a HWRNG in Broadcom Cygnus SoC, so enable it. >>>> >>>> Signed-off-by: Clément Peron <clement.peron@devialet.com> >>> Thanks for upstreaming some missing Cygnus components. >>> >>> But, the problem is the tarball release from Broadcom you are extracting >>> these changes from does not contain git history; so, you are missing the >>> original authors and signed-off's. >>> I checked our internal git repository and for this commit the author is: >>> Mohamed Ismail Abdul Packir Mohamed <mohamed-ismail.abdul@broadcom.com> >>> >>> Please adjust author and signed-off appropriately. If there are other >>> changes you are extracting from the source tarballs you have please >>> contact me so we can construct patch appropriately. >> If you want the original author's Signed-off-by to be preserved, why >> don't you extract it from your internal git tree and submit the patch on >> Mohamed's behalf? >> >> AFAICT what Clement is doing here is permissible given the Linux >> developer certificate of origin though I am not a lawyer of course. >> -- >> Florian > Totally not my goal to steal the author and agree to keep track of the > original author > as soon as it's possible. I didn't though it was important for this > patch as the same > code is available in the dt-bindings documentation. > > Actually there are still some buggy components like DSA (Arun proposed > a patch this morning) > the PWM (config and delay aren't correct) and I2C. These are mainlined > but can't be used > and need a minimal effort to correctly work on Cygnus. We have internal versions of most everything. It's a matter of getting people to push the appropriate patches out for upstream version to work. Please contact the bcm-kernel-feedback list with issues and we can work through common solution (or, likely already have a solution just not upstreamed). > > Also there are some important components like USB Phy or Mailbox that > were proposed and > almost made it, but just need a small modification to be accepted. Again - we may have internal solution already. Yes, mailbox was submitted upstream a long time ago and I think got stalled being accepted upstream. We can work through upstream solution by starting with sending to bcm-kernel-feedback-list to discuss details. > > My idea was just to submit small patches that are trivial to review. > In order to avoid keeping > lots of patches in our kernel and also have something functional when > building a mainline kernel. I understand the difficulty you would have if you're trying to work with a different kernel version in our release. If you send me a list directly of the drivers you use in Cygnus that will help me get those changes prioritized to be pushed upstream. And/or we can work together on that. > > Regards, > Clement Thanks, Scott
On 06/06/2018 10:14 AM, Scott Branden wrote: > > > On 18-06-06 09:47 AM, Florian Fainelli wrote: >> On 06/06/2018 09:03 AM, Scott Branden wrote: >>> Hi Clement, >>> >>> >>> On 18-06-06 02:34 AM, Clément Péron wrote: >>>> From: Clément Peron <clement.peron@devialet.com> >>>> >>>> There is a HWRNG in Broadcom Cygnus SoC, so enable it. >>>> >>>> Signed-off-by: Clément Peron <clement.peron@devialet.com> >>> Thanks for upstreaming some missing Cygnus components. >>> >>> But, the problem is the tarball release from Broadcom you are extracting >>> these changes from does not contain git history; so, you are missing the >>> original authors and signed-off's. >>> I checked our internal git repository and for this commit the author is: >>> Mohamed Ismail Abdul Packir Mohamed <mohamed-ismail.abdul@broadcom.com> >>> >>> Please adjust author and signed-off appropriately. If there are other >>> changes you are extracting from the source tarballs you have please >>> contact me so we can construct patch appropriately. >> If you want the original author's Signed-off-by to be preserved, why >> don't you extract it from your internal git tree and submit the patch on >> Mohamed's behalf? > Sure, I can submit the original patch to keep things simple and avoid > finding a lawyer right now. >> >> AFAICT what Clement is doing here is permissible given the Linux >> developer certificate of origin though I am not a lawyer of course. > But, It would be great to get some guidance and clarification on this > for sure. > I'm reading: > https://www.kernel.org/doc/html/v4.16/process/submitting-patches.html > > The change was created entirely by Broadcom, so seems difficult for > somebody else to upstream change without appropriate authorship and > signed off from copyright holder. Indeed, but it is effectively Broadcom's fault for not providing a git tree for the customer to pull from in order to preserve the original authorship, if what was distributed is a tarball of changes against a vanilla kernel (which is likely to be the case), then all author attributions are lost. Not suggesting you change how you deliver code to customers, we have the same issue in the STB/CM group, except maybe customers care less about upstreaming so we can do it ourselves at our own pace and using our own attributions. > Point a) and b) are not met in > Developer's Certificate of Origin while point c) is being attempted > (without a or b being certified). I would think that point a) and b) are met by the very fact that the Cygnus kernel port is GPLv2 code, being a derivative work of the Linux kernel, and that should be enough. This is kind of well established things, this has happened for many Broadcom product lines unfortunately because not everyone is active like you in getting things upstreamed. Those contributions were still entirely valid and acceptable for the kernel community. Maybe we do need a lawyer, Saul Goodman, are you here?
diff --git a/arch/arm/boot/dts/bcm-cygnus.dtsi b/arch/arm/boot/dts/bcm-cygnus.dtsi index 1cee40ac4613..b7178e84d56d 100644 --- a/arch/arm/boot/dts/bcm-cygnus.dtsi +++ b/arch/arm/boot/dts/bcm-cygnus.dtsi @@ -452,6 +452,11 @@ status = "disabled"; }; + hwrng: hwrng@18032000 { + compatible = "brcm,iproc-rng200"; + reg = <0x18032000 0x28>; + }; + sdhci0: sdhci@18041000 { compatible = "brcm,sdhci-iproc-cygnus"; reg = <0x18041000 0x100>;