| Message ID | 20110123215438.GA28153@merkur.ravnborg.org |
|---|---|
| State | RFC |
| Delegated to: | David Miller |
| Headers | show |
From: Sam Ravnborg <sam@ravnborg.org> Date: Sun, 23 Jan 2011 22:54:38 +0100 > The patches survied my SPARCclassic config and defconfig. > But allnoconfig bails out with an error. > > This is because asm-generic/tlb.h require linux/pagemap.h. > The include happended implicitly before. > > > Workaround is simple - see below. > I will try to get it fixed in asm-generic for benefit of all users. Please get this fix in asm-generic and merged upstream, then repost your series and mention this dependency so I can merge in Linus's tree first. Thanks. -- To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: David Miller <davem@davemloft.net> Date: Mon, 24 Jan 2011 16:11:32 -0800 (PST) > From: Sam Ravnborg <sam@ravnborg.org> > Date: Sun, 23 Jan 2011 22:54:38 +0100 > >> The patches survied my SPARCclassic config and defconfig. >> But allnoconfig bails out with an error. >> >> This is because asm-generic/tlb.h require linux/pagemap.h. >> The include happended implicitly before. >> >> >> Workaround is simple - see below. >> I will try to get it fixed in asm-generic for benefit of all users. > > Please get this fix in asm-generic and merged upstream, then > repost your series and mention this dependency so I can merge > in Linus's tree first. > > Thanks. BTW, I did review the patches and they do otherwise look perfectly fine to me. -- To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Jan 24, 2011 at 04:11:32PM -0800, David Miller wrote: > From: Sam Ravnborg <sam@ravnborg.org> > Date: Sun, 23 Jan 2011 22:54:38 +0100 > > > The patches survied my SPARCclassic config and defconfig. > > But allnoconfig bails out with an error. > > > > This is because asm-generic/tlb.h require linux/pagemap.h. > > The include happended implicitly before. > > > > > > Workaround is simple - see below. > > I will try to get it fixed in asm-generic for benefit of all users. > > Please get this fix in asm-generic and merged upstream, then > repost your series and mention this dependency so I can merge > in Linus's tree first. Andrew already fixed it: http://marc.info/?l=linux-mips&m=129593731808647&w=2 I have build tested sparc32 allnoconfig + defconfig. I will repost my serie when this fix is in mainline. The updated serie will be on top of sparc-next. Sam -- To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Sam Ravnborg <sam@ravnborg.org> Date: Tue, 25 Jan 2011 08:52:47 +0100 > Andrew already fixed it: > http://marc.info/?l=linux-mips&m=129593731808647&w=2 > > I have build tested sparc32 allnoconfig + defconfig. > > I will repost my serie when this fix is in mainline. > The updated serie will be on top of sparc-next. Thanks a lot Sam. -- To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Jan 24, 2011 at 04:17:54PM -0800, David Miller wrote: > From: David Miller <davem@davemloft.net> > Date: Mon, 24 Jan 2011 16:11:32 -0800 (PST) > > > From: Sam Ravnborg <sam@ravnborg.org> > > Date: Sun, 23 Jan 2011 22:54:38 +0100 > > > >> The patches survied my SPARCclassic config and defconfig. > >> But allnoconfig bails out with an error. > >> > >> This is because asm-generic/tlb.h require linux/pagemap.h. > >> The include happended implicitly before. > >> > >> > >> Workaround is simple - see below. > >> I will try to get it fixed in asm-generic for benefit of all users. > > > > Please get this fix in asm-generic and merged upstream, then > > repost your series and mention this dependency so I can merge > > in Linus's tree first. > > > > Thanks. > > BTW, I did review the patches and they do otherwise look perfectly > fine to me. Just realised that I did not give you credit for this review in the patch-set I just sent out. Would you like me to add your "Acked-by" / "Reviewed-by" in future patches? As you anyway sign-off the patches it may look a bit redundant. But then it would be documented that you did not blindly apply the patches. Sam -- To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Sam Ravnborg <sam@ravnborg.org> Date: Sat, 29 Jan 2011 09:13:16 +0100 > As you anyway sign-off the patches it may look a bit redundant. It is a bit redundant. > But then it would be documented that you did not blindly > apply the patches. If I blindly apply patches and sign off on them, I should be shot. :-) -- To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/sparc/include/asm/tlb_32.h b/arch/sparc/include/asm/tlb_32.h index 6d02d1c..d29b2ea 100644 --- a/arch/sparc/include/asm/tlb_32.h +++ b/arch/sparc/include/asm/tlb_32.h @@ -1,6 +1,8 @@ #ifndef _SPARC_TLB_H #define _SPARC_TLB_H +#include <linux/pagemap.h> + #define tlb_start_vma(tlb, vma) \ do { \ flush_cache_range(vma, vma->vm_start, vma->vm_end); \