| Message ID | 1526488352-898-2-git-send-email-jacopo+renesas@jmondi.org |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | [1/6] dt-bindings: media: rcar-vin: Describe optional ep properties | expand |
Hi Jacopo, Thanks for your patch. On 2018-05-16 18:32:27 +0200, Jacopo Mondi wrote: > Describe the optional endpoint properties for endpoint nodes of port@0 > and port@1 of the R-Car VIN driver device tree bindings documentation. > > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> Acked-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> > --- > Documentation/devicetree/bindings/media/rcar_vin.txt | 13 ++++++++++++- > 1 file changed, 12 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/media/rcar_vin.txt b/Documentation/devicetree/bindings/media/rcar_vin.txt > index a19517e1..c53ce4e 100644 > --- a/Documentation/devicetree/bindings/media/rcar_vin.txt > +++ b/Documentation/devicetree/bindings/media/rcar_vin.txt > @@ -53,6 +53,16 @@ from local SoC CSI-2 receivers (port1) depending on SoC. > from external SoC pins described in video-interfaces.txt[1]. > Describing more then one endpoint in port 0 is invalid. Only VIN > instances that are connected to external pins should have port 0. > + > + - Optional properties for endpoint nodes of port@0: > + - hsync-active: active state of the HSYNC signal, 0/1 for LOW/HIGH > + respectively. Default is active high. > + - vsync-active: active state of the VSYNC signal, 0/1 for LOW/HIGH > + respectively. Default is active high. > + > + If both HSYNC and VSYNC polarities are not specified, embedded > + synchronization is selected. > + > - port 1 - sub-nodes describing one or more endpoints connected to > the VIN from local SoC CSI-2 receivers. The endpoint numbers must > use the following schema. > @@ -62,6 +72,8 @@ from local SoC CSI-2 receivers (port1) depending on SoC. > - Endpoint 2 - sub-node describing the endpoint connected to CSI40 > - Endpoint 3 - sub-node describing the endpoint connected to CSI41 > > + Endpoint nodes of port@1 do not support any optional endpoint property. > + > Device node example for Gen2 platforms > -------------------------------------- > > @@ -112,7 +124,6 @@ Board setup example for Gen2 platforms (vin1 composite video input) > > vin1ep0: endpoint { > remote-endpoint = <&adv7180>; > - bus-width = <8>; > }; > }; > }; > -- > 2.7.4 >
On Wed, May 16, 2018 at 06:32:27PM +0200, Jacopo Mondi wrote: > Describe the optional endpoint properties for endpoint nodes of port@0 > and port@1 of the R-Car VIN driver device tree bindings documentation. > > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> > --- > Documentation/devicetree/bindings/media/rcar_vin.txt | 13 ++++++++++++- > 1 file changed, 12 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/media/rcar_vin.txt b/Documentation/devicetree/bindings/media/rcar_vin.txt > index a19517e1..c53ce4e 100644 > --- a/Documentation/devicetree/bindings/media/rcar_vin.txt > +++ b/Documentation/devicetree/bindings/media/rcar_vin.txt > @@ -53,6 +53,16 @@ from local SoC CSI-2 receivers (port1) depending on SoC. > from external SoC pins described in video-interfaces.txt[1]. > Describing more then one endpoint in port 0 is invalid. Only VIN > instances that are connected to external pins should have port 0. > + > + - Optional properties for endpoint nodes of port@0: > + - hsync-active: active state of the HSYNC signal, 0/1 for LOW/HIGH > + respectively. Default is active high. > + - vsync-active: active state of the VSYNC signal, 0/1 for LOW/HIGH > + respectively. Default is active high. > + > + If both HSYNC and VSYNC polarities are not specified, embedded > + synchronization is selected. No need to copy-n-paste from video-interfaces.txt. Just "see video-interfaces.txt" for the description is fine. > + > - port 1 - sub-nodes describing one or more endpoints connected to > the VIN from local SoC CSI-2 receivers. The endpoint numbers must > use the following schema. > @@ -62,6 +72,8 @@ from local SoC CSI-2 receivers (port1) depending on SoC. > - Endpoint 2 - sub-node describing the endpoint connected to CSI40 > - Endpoint 3 - sub-node describing the endpoint connected to CSI41 > > + Endpoint nodes of port@1 do not support any optional endpoint property. > + > Device node example for Gen2 platforms > -------------------------------------- > > @@ -112,7 +124,6 @@ Board setup example for Gen2 platforms (vin1 composite video input) > > vin1ep0: endpoint { > remote-endpoint = <&adv7180>; > - bus-width = <8>; > }; > }; > }; > -- > 2.7.4 > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Rob, On Wednesday, 23 May 2018 19:29:47 EEST Rob Herring wrote: > On Wed, May 16, 2018 at 06:32:27PM +0200, Jacopo Mondi wrote: > > Describe the optional endpoint properties for endpoint nodes of port@0 > > and port@1 of the R-Car VIN driver device tree bindings documentation. > > > > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> > > --- > > > > Documentation/devicetree/bindings/media/rcar_vin.txt | 13 ++++++++++++- > > 1 file changed, 12 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/media/rcar_vin.txt > > b/Documentation/devicetree/bindings/media/rcar_vin.txt index > > a19517e1..c53ce4e 100644 > > --- a/Documentation/devicetree/bindings/media/rcar_vin.txt > > +++ b/Documentation/devicetree/bindings/media/rcar_vin.txt > > @@ -53,6 +53,16 @@ from local SoC CSI-2 receivers (port1) depending on > > SoC. > > > > from external SoC pins described in video-interfaces.txt[1]. > > Describing more then one endpoint in port 0 is invalid. Only VIN > > instances that are connected to external pins should have port 0. > > > > + > > + - Optional properties for endpoint nodes of port@0: > > + - hsync-active: active state of the HSYNC signal, 0/1 for > > LOW/HIGH > > + respectively. Default is active high. > > + - vsync-active: active state of the VSYNC signal, 0/1 for > > LOW/HIGH > > + respectively. Default is active high. > > + > > + If both HSYNC and VSYNC polarities are not specified, embedded > > + synchronization is selected. > > No need to copy-n-paste from video-interfaces.txt. Just "see > video-interfaces.txt" for the description is fine. I would still explicitly list the properties that apply to this binding. I agree that there's no need to copy & paste the description of those properties though. > > + > > > > - port 1 - sub-nodes describing one or more endpoints connected to > > > > the VIN from local SoC CSI-2 receivers. The endpoint numbers must > > use the following schema. > > > > @@ -62,6 +72,8 @@ from local SoC CSI-2 receivers (port1) depending on SoC. > > > > - Endpoint 2 - sub-node describing the endpoint connected to > > CSI40 > > - Endpoint 3 - sub-node describing the endpoint connected to > > CSI41 > > > > + Endpoint nodes of port@1 do not support any optional endpoint > > property. + > > > > Device node example for Gen2 platforms > > -------------------------------------- > > > > @@ -112,7 +124,6 @@ Board setup example for Gen2 platforms (vin1 composite > > video input)> > > vin1ep0: endpoint { > > > > remote-endpoint = <&adv7180>; > > > > - bus-width = <8>; > > > > }; > > > > }; > > > > };
On Wed, May 23, 2018 at 2:38 PM, Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote: > Hi Rob, > > On Wednesday, 23 May 2018 19:29:47 EEST Rob Herring wrote: >> On Wed, May 16, 2018 at 06:32:27PM +0200, Jacopo Mondi wrote: >> > Describe the optional endpoint properties for endpoint nodes of port@0 >> > and port@1 of the R-Car VIN driver device tree bindings documentation. >> > >> > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> >> > --- >> > >> > Documentation/devicetree/bindings/media/rcar_vin.txt | 13 ++++++++++++- >> > 1 file changed, 12 insertions(+), 1 deletion(-) >> > >> > diff --git a/Documentation/devicetree/bindings/media/rcar_vin.txt >> > b/Documentation/devicetree/bindings/media/rcar_vin.txt index >> > a19517e1..c53ce4e 100644 >> > --- a/Documentation/devicetree/bindings/media/rcar_vin.txt >> > +++ b/Documentation/devicetree/bindings/media/rcar_vin.txt >> > @@ -53,6 +53,16 @@ from local SoC CSI-2 receivers (port1) depending on >> > SoC. >> > >> > from external SoC pins described in video-interfaces.txt[1]. >> > Describing more then one endpoint in port 0 is invalid. Only VIN >> > instances that are connected to external pins should have port 0. >> > >> > + >> > + - Optional properties for endpoint nodes of port@0: >> > + - hsync-active: active state of the HSYNC signal, 0/1 for >> > LOW/HIGH >> > + respectively. Default is active high. >> > + - vsync-active: active state of the VSYNC signal, 0/1 for >> > LOW/HIGH >> > + respectively. Default is active high. >> > + >> > + If both HSYNC and VSYNC polarities are not specified, embedded >> > + synchronization is selected. >> >> No need to copy-n-paste from video-interfaces.txt. Just "see >> video-interfaces.txt" for the description is fine. > > I would still explicitly list the properties that apply to this binding. I > agree that there's no need to copy & paste the description of those properties > though. Yes, that's what I meant. List each property with "see video-interfaces.txt" for the description of each. Rob -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/media/rcar_vin.txt b/Documentation/devicetree/bindings/media/rcar_vin.txt index a19517e1..c53ce4e 100644 --- a/Documentation/devicetree/bindings/media/rcar_vin.txt +++ b/Documentation/devicetree/bindings/media/rcar_vin.txt @@ -53,6 +53,16 @@ from local SoC CSI-2 receivers (port1) depending on SoC. from external SoC pins described in video-interfaces.txt[1]. Describing more then one endpoint in port 0 is invalid. Only VIN instances that are connected to external pins should have port 0. + + - Optional properties for endpoint nodes of port@0: + - hsync-active: active state of the HSYNC signal, 0/1 for LOW/HIGH + respectively. Default is active high. + - vsync-active: active state of the VSYNC signal, 0/1 for LOW/HIGH + respectively. Default is active high. + + If both HSYNC and VSYNC polarities are not specified, embedded + synchronization is selected. + - port 1 - sub-nodes describing one or more endpoints connected to the VIN from local SoC CSI-2 receivers. The endpoint numbers must use the following schema. @@ -62,6 +72,8 @@ from local SoC CSI-2 receivers (port1) depending on SoC. - Endpoint 2 - sub-node describing the endpoint connected to CSI40 - Endpoint 3 - sub-node describing the endpoint connected to CSI41 + Endpoint nodes of port@1 do not support any optional endpoint property. + Device node example for Gen2 platforms -------------------------------------- @@ -112,7 +124,6 @@ Board setup example for Gen2 platforms (vin1 composite video input) vin1ep0: endpoint { remote-endpoint = <&adv7180>; - bus-width = <8>; }; }; };
Describe the optional endpoint properties for endpoint nodes of port@0 and port@1 of the R-Car VIN driver device tree bindings documentation. Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> --- Documentation/devicetree/bindings/media/rcar_vin.txt | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) -- 2.7.4 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html