| Message ID | 20180517130628.2770-1-andrea.greco.gapmilano@gmail.com |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | None | expand |
On Thu, May 17, 2018 at 03:06:26PM +0200, Andrea Greco wrote: > From: Andrea Greco <a.greco@4sigma.it> > > Add devicetree bindings for smsc com20020 > > Signed-off-by: Andrea Greco <a.greco@4sigma.it> > --- > .../devicetree/bindings/net/smsc-com20020.txt | 21 +++++++++++++++++++++ > 1 file changed, 21 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/smsc-com20020.txt One typo, otherwise: Reviewed-by: Rob Herring <robh@kernel.org> > > diff --git a/Documentation/devicetree/bindings/net/smsc-com20020.txt b/Documentation/devicetree/bindings/net/smsc-com20020.txt > new file mode 100644 > index 000000000000..92360b054873 > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/smsc-com20020.txt > @@ -0,0 +1,21 @@ > +SMSC com20020 Arcnet network controller > + > +Required propelty: property > +- timeout-ns: Arcnet bus timeout, Idle Time (328000 - 20500) > +- bus-speed-bps: Arcnet bus speed (10000000 - 156250) > +- smsc,xtal-mhz: External oscillator frequency > +- smsc,backplane-enabled: Controller use backplane mode > +- reset-gpios: Chip reset pin > +- interrupts: Should contain controller interrupt > + > +arcnet@28000000 { > + compatible = "smsc,com20020"; > + > + timeout-ns = <20500>; > + bus-speed-bps = <10000000>; > + smsc,xtal-mhz = <20>; > + smsc,backplane-enabled; > + > + reset-gpios = <&gpio3 21 GPIO_ACTIVE_LOW>; > + interrupts = <&gpio2 10 GPIO_ACTIVE_LOW>; > +}; > -- > 2.14.3 > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 05/23/2018 06:49 PM, Rob Herring wrote: > One typo, otherwise: > > Reviewed-by: Rob Herring <robh@kernel.org> Yes typo, Fixed over my branch, sorry for that... I expect a comment about bps, Bit per Second, used in `bus-speed-bps` You will add it by your self in property-units.txt, or required my patch? If your confirm that, ready for: Reviewed-by Regards, Andrea -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, May 23, 2018 at 5:17 PM, Andrea Greco <andrea.greco.gapmilano@gmail.com> wrote: > On 05/23/2018 06:49 PM, Rob Herring wrote: >> One typo, otherwise: >> >> Reviewed-by: Rob Herring <robh@kernel.org> > > Yes typo, Fixed over my branch, sorry for that... > I expect a comment about bps, Bit per Second, used in `bus-speed-bps` > You will add it by your self in property-units.txt, or required my patch? If you want to add it, that's fine. But it's really not something that comes up often. For UARTs, there's already the "current-speed" property and most other things I can think of use Hz to express speeds. Rob -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 05/24/2018 04:36 PM, Rob Herring wrote> If you want to add it, that's fine. But it's really not something that > comes up often. For UARTs, there's already the "current-speed" > property and most other things I can think of use Hz to express > speeds. No, Pref keep standard and use Hz. This if finally: ``` SMSC com20020 Arcnet network controller Required property: - timeout-ns: Arcnet bus timeout, Idle Time (328000 - 20500) - bus-speed-bps: Arcnet bus speed (10000000 - 156250) - smsc,xtal-mhz: External oscillator frequency - smsc,backplane-enabled: Controller use backplane mode - reset-gpios: Chip reset pin - interrupts: Should contain controller interrupt arcnet@28000000 { compatible = "smsc,com20020"; timeout-ns = <20500>; bus-speed-hz = <10000000>; smsc,xtal-mhz = <20>; smsc,backplane-enabled; reset-gpios = <&gpio3 21 GPIO_ACTIVE_LOW>; interrupts = <&gpio2 10 GPIO_ACTIVE_LOW>; }; ``` If confirmed, for me is right Andrea -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/net/smsc-com20020.txt b/Documentation/devicetree/bindings/net/smsc-com20020.txt new file mode 100644 index 000000000000..92360b054873 --- /dev/null +++ b/Documentation/devicetree/bindings/net/smsc-com20020.txt @@ -0,0 +1,21 @@ +SMSC com20020 Arcnet network controller + +Required propelty: +- timeout-ns: Arcnet bus timeout, Idle Time (328000 - 20500) +- bus-speed-bps: Arcnet bus speed (10000000 - 156250) +- smsc,xtal-mhz: External oscillator frequency +- smsc,backplane-enabled: Controller use backplane mode +- reset-gpios: Chip reset pin +- interrupts: Should contain controller interrupt + +arcnet@28000000 { + compatible = "smsc,com20020"; + + timeout-ns = <20500>; + bus-speed-bps = <10000000>; + smsc,xtal-mhz = <20>; + smsc,backplane-enabled; + + reset-gpios = <&gpio3 21 GPIO_ACTIVE_LOW>; + interrupts = <&gpio2 10 GPIO_ACTIVE_LOW>; +};