| Message ID | 20180510182719.GA22217@jordon-HP-15-Notebook-PC |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [v2] powerpc: kvm: Change return type to vm_fault_t | expand |
On Thu, May 10, 2018 at 11:57 PM, Souptick Joarder <jrdr.linux@gmail.com> wrote: > Use new return type vm_fault_t for fault handler > in struct vm_operations_struct. For now, this is > just documenting that the function returns a > VM_FAULT value rather than an errno. Once all > instances are converted, vm_fault_t will become > a distinct type. > > commit 1c8f422059ae ("mm: change return type to > vm_fault_t") > > Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com> > --- > v2: Updated the change log > > arch/powerpc/kvm/book3s_64_vio.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/powerpc/kvm/book3s_64_vio.c b/arch/powerpc/kvm/book3s_64_vio.c > index 4dffa61..346ac0d 100644 > --- a/arch/powerpc/kvm/book3s_64_vio.c > +++ b/arch/powerpc/kvm/book3s_64_vio.c > @@ -237,7 +237,7 @@ static void release_spapr_tce_table(struct rcu_head *head) > kfree(stt); > } > > -static int kvm_spapr_tce_fault(struct vm_fault *vmf) > +static vm_fault_t kvm_spapr_tce_fault(struct vm_fault *vmf) > { > struct kvmppc_spapr_tce_table *stt = vmf->vma->vm_file->private_data; > struct page *page; > -- > 1.9.1 > If no comment, we would like to get this patch in queue for 4.18. -- To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, May 16, 2018 at 10:11:11AM +0530, Souptick Joarder wrote: > On Thu, May 10, 2018 at 11:57 PM, Souptick Joarder <jrdr.linux@gmail.com> wrote: > > Use new return type vm_fault_t for fault handler > > in struct vm_operations_struct. For now, this is > > just documenting that the function returns a > > VM_FAULT value rather than an errno. Once all > > instances are converted, vm_fault_t will become > > a distinct type. > > > > commit 1c8f422059ae ("mm: change return type to > > vm_fault_t") > > > > Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com> > > --- > > v2: Updated the change log > > > > arch/powerpc/kvm/book3s_64_vio.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/powerpc/kvm/book3s_64_vio.c b/arch/powerpc/kvm/book3s_64_vio.c > > index 4dffa61..346ac0d 100644 > > --- a/arch/powerpc/kvm/book3s_64_vio.c > > +++ b/arch/powerpc/kvm/book3s_64_vio.c > > @@ -237,7 +237,7 @@ static void release_spapr_tce_table(struct rcu_head *head) > > kfree(stt); > > } > > > > -static int kvm_spapr_tce_fault(struct vm_fault *vmf) > > +static vm_fault_t kvm_spapr_tce_fault(struct vm_fault *vmf) > > { > > struct kvmppc_spapr_tce_table *stt = vmf->vma->vm_file->private_data; > > struct page *page; > > -- > > 1.9.1 > > > > If no comment, we would like to get this patch in queue > for 4.18. It looks fine - I'll queue it up. Paul. -- To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, May 16, 2018 at 12:38 PM, Paul Mackerras <paulus@ozlabs.org> wrote: > On Wed, May 16, 2018 at 10:11:11AM +0530, Souptick Joarder wrote: >> On Thu, May 10, 2018 at 11:57 PM, Souptick Joarder <jrdr.linux@gmail.com> wrote: >> > Use new return type vm_fault_t for fault handler >> > in struct vm_operations_struct. For now, this is >> > just documenting that the function returns a >> > VM_FAULT value rather than an errno. Once all >> > instances are converted, vm_fault_t will become >> > a distinct type. >> > >> > commit 1c8f422059ae ("mm: change return type to >> > vm_fault_t") >> > >> > Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com> >> > --- >> > v2: Updated the change log >> > >> > arch/powerpc/kvm/book3s_64_vio.c | 2 +- >> > 1 file changed, 1 insertion(+), 1 deletion(-) >> > >> > diff --git a/arch/powerpc/kvm/book3s_64_vio.c b/arch/powerpc/kvm/book3s_64_vio.c >> > index 4dffa61..346ac0d 100644 >> > --- a/arch/powerpc/kvm/book3s_64_vio.c >> > +++ b/arch/powerpc/kvm/book3s_64_vio.c >> > @@ -237,7 +237,7 @@ static void release_spapr_tce_table(struct rcu_head *head) >> > kfree(stt); >> > } >> > >> > -static int kvm_spapr_tce_fault(struct vm_fault *vmf) >> > +static vm_fault_t kvm_spapr_tce_fault(struct vm_fault *vmf) >> > { >> > struct kvmppc_spapr_tce_table *stt = vmf->vma->vm_file->private_data; >> > struct page *page; >> > -- >> > 1.9.1 >> > >> >> If no comment, we would like to get this patch in queue >> for 4.18. > > It looks fine - I'll queue it up. > > Paul. Thanks Paul :) -- To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/powerpc/kvm/book3s_64_vio.c b/arch/powerpc/kvm/book3s_64_vio.c index 4dffa61..346ac0d 100644 --- a/arch/powerpc/kvm/book3s_64_vio.c +++ b/arch/powerpc/kvm/book3s_64_vio.c @@ -237,7 +237,7 @@ static void release_spapr_tce_table(struct rcu_head *head) kfree(stt); } -static int kvm_spapr_tce_fault(struct vm_fault *vmf) +static vm_fault_t kvm_spapr_tce_fault(struct vm_fault *vmf) { struct kvmppc_spapr_tce_table *stt = vmf->vma->vm_file->private_data; struct page *page;
Use new return type vm_fault_t for fault handler in struct vm_operations_struct. For now, this is just documenting that the function returns a VM_FAULT value rather than an errno. Once all instances are converted, vm_fault_t will become a distinct type. commit 1c8f422059ae ("mm: change return type to vm_fault_t") Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com> --- v2: Updated the change log arch/powerpc/kvm/book3s_64_vio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html