Message ID | 20180515171303.11312-1-leonardo.sandoval.gonzalez@linux.intel.com |
---|---|
State | New |
Headers | show |
Series | x86-64: remove duplicate line on PREFETCH_ONE_SET macro | expand |
* leonardo sandoval gonzalez: > From: Leonardo Sandoval <leonardo.sandoval.gonzalez@linux.intel.com> > > Tested on 64-bit AVX machine > > * sysdeps/x86_64/multiarch/memmove-vec-unaligned-erms.S (MEMMOVE): > remove duplicate line on PREFETCH_ONE_SET macro This should be: * sysdeps/x86_64/multiarch/memmove-vec-unaligned-erms.S (PREFETCH_ONE_SET): Remove duplicate line. > Signed-off-by: Leonardo Sandoval <leonardo.sandoval.gonzalez@linux.intel.com> We don't use DCO, so this line is very misleading and should not be present. Looks good otherwise. Do you have commit access?
On Tue, 2018-05-15 at 20:27 +0200, Florian Weimer wrote: > * leonardo sandoval gonzalez: > > > From: Leonardo Sandoval <leonardo.sandoval.gonzalez@linux.intel.com > > > > > > > Tested on 64-bit AVX machine > > > > * sysdeps/x86_64/multiarch/memmove-vec-unaligned- > > erms.S (MEMMOVE): > > remove duplicate line on PREFETCH_ONE_SET macro > > This should be: > > * sysdeps/x86_64/multiarch/memmove-vec-unaligned-erms.S > (PREFETCH_ONE_SET): Remove duplicate line. > > > Signed-off-by: Leonardo Sandoval <leonardo.sandoval.gonzalez@linux. > > intel.com> > > We don't use DCO, so this line is very misleading and should not be > present. > I will send a v2. > Looks good otherwise. Do you have commit access? No
* Leonardo Sandoval:
> Florian, can someone check (perhaps you) if I now have commit access?
You will receive email from the overseers once this is set up, I
think.
On Tue, 2018-05-15 at 20:27 +0200, Florian Weimer wrote: > * leonardo sandoval gonzalez: > > > From: Leonardo Sandoval <leonardo.sandoval.gonzalez@linux.intel.com > > > > > > > Tested on 64-bit AVX machine > > > > * sysdeps/x86_64/multiarch/memmove-vec-unaligned- > > erms.S (MEMMOVE): > > remove duplicate line on PREFETCH_ONE_SET macro > > This should be: > > * sysdeps/x86_64/multiarch/memmove-vec-unaligned-erms.S > (PREFETCH_ONE_SET): Remove duplicate line. > > > Signed-off-by: Leonardo Sandoval <leonardo.sandoval.gonzalez@linux. > > intel.com> > > We don't use DCO, so this line is very misleading and should not be > present. > > Looks good otherwise. Do you have commit access? Florian, can someone check (perhaps you) if I now have commit access? Leo
diff --git a/sysdeps/x86_64/multiarch/memmove-vec-unaligned-erms.S b/sysdeps/x86_64/multiarch/memmove-vec-unaligned-erms.S index cbd0d077cf6..1404131bb71 100644 --- a/sysdeps/x86_64/multiarch/memmove-vec-unaligned-erms.S +++ b/sysdeps/x86_64/multiarch/memmove-vec-unaligned-erms.S @@ -90,7 +90,6 @@ # define PREFETCH_ONE_SET(dir, base, offset) \ PREFETCH ((offset)base); \ PREFETCH ((offset + dir * PREFETCH_SIZE)base); \ - PREFETCH ((offset + dir * PREFETCH_SIZE)base); \ PREFETCH ((offset + dir * PREFETCH_SIZE * 2)base); \ PREFETCH ((offset + dir * PREFETCH_SIZE * 3)base) # else