| Message ID | Pine.LNX.4.64.1101140003450.6059@digraph.polyomino.org.uk |
|---|---|
| State | New |
| Headers | show |
On Friday 14 January 2011 01:04:23 Joseph S. Myers wrote: > Various specs pass -Yd, options to the assembler. Various other > places have a comment "The sun bundled assembler doesn't accept -Yd, > (and neither does gas).", presumably to explain why a spec without > %{Yd,*} is overriding another one with it. > > Indeed, -Yd, is not a GNU assembler option, and is not a Solaris > assembler option on either x86 or SPARC. So it is not relevant for > any supported target with such specs and this patch removes all such > specs. OK to commit? > > 2011-01-13 Joseph Myers <joseph@codesourcery.com> > > * config/bfin/bfin.h (ASM_SPEC): Remove %{Yd,*}. > * config/frv/frv.h (ASM_SPEC): Likewise. > * config/i386/sol2-10.h (ASM_SPEC): Likewise. > * config/m68k/linux.h (ASM_SPEC): Likewise. > * config/pa/pa-linux.h (ASM_SPEC): Likewise. > * config/rs6000/linux64.h (ASM_SPEC32): Likewise. > * config/rs6000/vxworks.h (ASM_SPEC): Likewise. > * config/sol2.h (ASM_SPEC): Remove comment about -Yd,. > * config/sparc/linux.h (ASM_SPEC): Likewise. > * config/sparc/linux64.h (ASM_SPEC): Likewise. > * config/sparc/sp-elf.h (ASM_SPEC): Likewise. > * config/sparc/sysv4.h (ASM_SPEC): Remove %{Yd,*}. OK for the SPARC bits.
Ping. The non-SPARC parts of this patch <http://gcc.gnu.org/ml/gcc-patches/2011-01/msg00893.html> are pending review.
On Wed, Jan 26, 2011 at 6:50 PM, Joseph S. Myers <joseph@codesourcery.com> wrote: > Ping. The non-SPARC parts of this patch > <http://gcc.gnu.org/ml/gcc-patches/2011-01/msg00893.html> are pending > review. Ok. Thanks, Richard. > -- > Joseph S. Myers > joseph@codesourcery.com >
diff -rupN --exclude=.svn gcc-mainline-3/gcc/config/bfin/bfin.h gcc-mainline/gcc/config/bfin/bfin.h --- gcc-mainline-3/gcc/config/bfin/bfin.h 2010-12-20 12:57:32.000000000 -0800 +++ gcc-mainline/gcc/config/bfin/bfin.h 2011-01-12 14:01:51.000000000 -0800 @@ -240,7 +240,7 @@ extern unsigned int bfin_workarounds; #undef ASM_SPEC #define ASM_SPEC "\ -%{Ym,*} %{Yd,*} \ +%{Ym,*} \ %{mno-fdpic:-mnopic} %{mfdpic}" #define LINK_SPEC "\ diff -rupN --exclude=.svn gcc-mainline-3/gcc/config/frv/frv.h gcc-mainline/gcc/config/frv/frv.h --- gcc-mainline-3/gcc/config/frv/frv.h 2010-12-20 13:02:08.000000000 -0800 +++ gcc-mainline/gcc/config/frv/frv.h 2011-01-12 14:02:10.000000000 -0800 @@ -57,7 +57,7 @@ #undef ASM_SPEC #define ASM_SPEC "\ -%{G*} %{Ym,*} %{Yd,*} \ +%{G*} %{Ym,*} \ %{mtomcat-stats} \ %{!mno-eflags: \ %{mcpu=*} \ diff -rupN --exclude=.svn gcc-mainline-3/gcc/config/i386/sol2-10.h gcc-mainline/gcc/config/i386/sol2-10.h --- gcc-mainline-3/gcc/config/i386/sol2-10.h 2011-01-07 13:21:15.000000000 -0800 +++ gcc-mainline/gcc/config/i386/sol2-10.h 2011-01-12 14:02:23.000000000 -0800 @@ -28,7 +28,7 @@ along with GCC; see the file COPYING3. #ifdef USE_GAS #define ASM_SPEC "%{m32:--32} %{m64:--64} -s %(asm_cpu)" #else -#define ASM_SPEC "%{v:-V} %{Qy:} %{!Qn:-Qy} %{Ym,*} %{Yd,*} " \ +#define ASM_SPEC "%{v:-V} %{Qy:} %{!Qn:-Qy} %{Ym,*} " \ "%{m32:-xarch=generic} %{m64:-xarch=generic64} " \ "-s %(asm_cpu)" #endif diff -rupN --exclude=.svn gcc-mainline-3/gcc/config/m68k/linux.h gcc-mainline/gcc/config/m68k/linux.h --- gcc-mainline-3/gcc/config/m68k/linux.h 2010-12-20 13:10:07.000000000 -0800 +++ gcc-mainline/gcc/config/m68k/linux.h 2011-01-12 14:02:33.000000000 -0800 @@ -25,7 +25,7 @@ along with GCC; see the file COPYING3. /* Add %(asm_cpu_spec) to a generic definition of ASM_SPEC. */ #undef ASM_SPEC #define ASM_SPEC "%(asm_cpu_spec) %(asm_pcrel_spec) \ - %{Qy:} %{!Qn:-Qy} %{Ym,*} %{Yd,*}" + %{Qy:} %{!Qn:-Qy} %{Ym,*}" #undef PREFERRED_STACK_BOUNDARY #define PREFERRED_STACK_BOUNDARY 32 diff -rupN --exclude=.svn gcc-mainline-3/gcc/config/pa/pa-linux.h gcc-mainline/gcc/config/pa/pa-linux.h --- gcc-mainline-3/gcc/config/pa/pa-linux.h 2010-12-09 05:38:56.000000000 -0800 +++ gcc-mainline/gcc/config/pa/pa-linux.h 2011-01-12 14:02:42.000000000 -0800 @@ -33,7 +33,7 @@ along with GCC; see the file COPYING3. #undef ASM_SPEC #define ASM_SPEC \ - "%{Ym,*} %{Yd,*}" + "%{Ym,*}" /* Define this for shared library support because it isn't in the main linux.h file. */ diff -rupN --exclude=.svn gcc-mainline-3/gcc/config/rs6000/linux64.h gcc-mainline/gcc/config/rs6000/linux64.h --- gcc-mainline-3/gcc/config/rs6000/linux64.h 2010-12-22 04:04:33.000000000 -0800 +++ gcc-mainline/gcc/config/rs6000/linux64.h 2011-01-12 14:02:56.000000000 -0800 @@ -192,7 +192,7 @@ extern int dot_symbols; #endif #endif -#define ASM_SPEC32 "-a32 %{Ym,*} %{Yd,*} \ +#define ASM_SPEC32 "-a32 %{Ym,*} \ %{mrelocatable} %{mrelocatable-lib} %{fpic:-K PIC} %{fPIC:-K PIC} \ %{memb} %{!memb: %{msdata=eabi: -memb}} \ %{!mlittle: %{!mlittle-endian: %{!mbig: %{!mbig-endian: \ diff -rupN --exclude=.svn gcc-mainline-3/gcc/config/rs6000/vxworks.h gcc-mainline/gcc/config/rs6000/vxworks.h --- gcc-mainline-3/gcc/config/rs6000/vxworks.h 2010-12-09 05:38:55.000000000 -0800 +++ gcc-mainline/gcc/config/rs6000/vxworks.h 2011-01-12 14:03:03.000000000 -0800 @@ -87,7 +87,7 @@ VXWORKS_ADDITIONAL_CPP_SPEC #define ASM_SPEC \ "%(asm_cpu) \ %{,assembler|,assembler-with-cpp: %{mregnames} %{mno-regnames}} \ - %{Qy:} %{!Qn:-Qy} %{Ym,*} %{Yd,*} \ + %{Qy:} %{!Qn:-Qy} %{Ym,*} \ %{mrelocatable} %{mrelocatable-lib} %{fpic:-K PIC} %{fPIC:-K PIC} -mbig" #undef LIB_SPEC diff -rupN --exclude=.svn gcc-mainline-3/gcc/config/sol2.h gcc-mainline/gcc/config/sol2.h --- gcc-mainline-3/gcc/config/sol2.h 2011-01-07 13:21:16.000000000 -0800 +++ gcc-mainline/gcc/config/sol2.h 2011-01-12 14:01:39.000000000 -0800 @@ -111,8 +111,7 @@ along with GCC; see the file COPYING3. /* The system headers under Solaris 2 are C++-aware since 2.0. */ #define NO_IMPLICIT_EXTERN_C -/* The sun bundled assembler doesn't accept -Yd, (and neither does gas). - It's safe to pass -s always, even if -g is not used. */ +/* It's safe to pass -s always, even if -g is not used. */ #undef ASM_SPEC #define ASM_SPEC "\ %{v:-V} %{Qy:} %{!Qn:-Qy} %{Ym,*} -s \ diff -rupN --exclude=.svn gcc-mainline-3/gcc/config/sparc/linux.h gcc-mainline/gcc/config/sparc/linux.h --- gcc-mainline-3/gcc/config/sparc/linux.h 2010-12-09 05:38:50.000000000 -0800 +++ gcc-mainline/gcc/config/sparc/linux.h 2011-01-12 14:03:26.000000000 -0800 @@ -87,8 +87,7 @@ along with GCC; see the file COPYING3. -dynamic-linker " LINUX_DYNAMIC_LINKER "} \ %{static:-static}}}" -/* The sun bundled assembler doesn't accept -Yd, (and neither does gas). - It's safe to pass -s always, even if -g is not used. */ +/* It's safe to pass -s always, even if -g is not used. */ #undef ASM_SPEC #define ASM_SPEC "\ %{!Qn:-Qy} \ diff -rupN --exclude=.svn gcc-mainline-3/gcc/config/sparc/linux64.h gcc-mainline/gcc/config/sparc/linux64.h --- gcc-mainline-3/gcc/config/sparc/linux64.h 2010-12-09 05:38:50.000000000 -0800 +++ gcc-mainline/gcc/config/sparc/linux64.h 2011-01-12 14:03:46.000000000 -0800 @@ -216,8 +216,7 @@ along with GCC; see the file COPYING3. #endif /* !SPARC_BI_ARCH */ -/* The sun bundled assembler doesn't accept -Yd, (and neither does gas). - It's safe to pass -s always, even if -g is not used. */ +/* It's safe to pass -s always, even if -g is not used. */ #undef ASM_SPEC #define ASM_SPEC "\ %{!Qn:-Qy} \ diff -rupN --exclude=.svn gcc-mainline-3/gcc/config/sparc/sp-elf.h gcc-mainline/gcc/config/sparc/sp-elf.h --- gcc-mainline-3/gcc/config/sparc/sp-elf.h 2011-01-12 13:56:56.000000000 -0800 +++ gcc-mainline/gcc/config/sparc/sp-elf.h 2011-01-12 14:03:35.000000000 -0800 @@ -24,8 +24,7 @@ along with GCC; see the file COPYING3. /* Don't assume anything about the header files. */ #define NO_IMPLICIT_EXTERN_C -/* The sun bundled assembler doesn't accept -Yd, (and neither does gas). - It's safe to pass -s always, even if -g is not used. */ +/* It's safe to pass -s always, even if -g is not used. */ #undef ASM_SPEC #define ASM_SPEC \ "%{Qy:} %{!Qn:-Qy} %{Ym,*} -s \ diff -rupN --exclude=.svn gcc-mainline-3/gcc/config/sparc/sysv4.h gcc-mainline/gcc/config/sparc/sysv4.h --- gcc-mainline-3/gcc/config/sparc/sysv4.h 2011-01-12 13:57:32.000000000 -0800 +++ gcc-mainline/gcc/config/sparc/sysv4.h 2011-01-12 14:03:16.000000000 -0800 @@ -46,7 +46,7 @@ along with GCC; see the file COPYING3. /* Pass -K to the assembler when PIC. */ #undef ASM_SPEC #define ASM_SPEC \ - "%{Qy:} %{!Qn:-Qy} %{Ym,*} %{Yd,*} \ + "%{Qy:} %{!Qn:-Qy} %{Ym,*} \ %{fpic|fPIC|fpie|fPIE:-K PIC} %(asm_cpu)" /* Define the names of various pseudo-op used by the SPARC/svr4 assembler.
Various specs pass -Yd, options to the assembler. Various other places have a comment "The sun bundled assembler doesn't accept -Yd, (and neither does gas).", presumably to explain why a spec without %{Yd,*} is overriding another one with it. Indeed, -Yd, is not a GNU assembler option, and is not a Solaris assembler option on either x86 or SPARC. So it is not relevant for any supported target with such specs and this patch removes all such specs. OK to commit? 2011-01-13 Joseph Myers <joseph@codesourcery.com> * config/bfin/bfin.h (ASM_SPEC): Remove %{Yd,*}. * config/frv/frv.h (ASM_SPEC): Likewise. * config/i386/sol2-10.h (ASM_SPEC): Likewise. * config/m68k/linux.h (ASM_SPEC): Likewise. * config/pa/pa-linux.h (ASM_SPEC): Likewise. * config/rs6000/linux64.h (ASM_SPEC32): Likewise. * config/rs6000/vxworks.h (ASM_SPEC): Likewise. * config/sol2.h (ASM_SPEC): Remove comment about -Yd,. * config/sparc/linux.h (ASM_SPEC): Likewise. * config/sparc/linux64.h (ASM_SPEC): Likewise. * config/sparc/sp-elf.h (ASM_SPEC): Likewise. * config/sparc/sysv4.h (ASM_SPEC): Remove %{Yd,*}.