| Message ID | 1523866512-11112-3-git-send-email-patrick.delaunay@st.com |
|---|---|
| State | Accepted |
| Commit | 4c6fe075ceb70eda19afaf3bfca9fea1b35c66a3 |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | [U-Boot,1/6] ls102xa: psci: save context id in cpu_on command | expand |
On 04/16/2018 02:15 AM, Patrick Delaunay wrote: > Replace the psci_save_target_pc call by the new function > psci_save(cpu, pc,context_id) So this function doesn't actually exist since it's added in a different patch series that isn't mentioned as a dependency. Luckily I managed to find it in the list archives I have, and assuming the dependency is applied first, Reviewed-by: Stephen Warren <swarren@nvidia.com> > diff --git a/arch/arm/mach-tegra/psci.S b/arch/arm/mach-tegra/psci.S > @@ -90,7 +90,8 @@ ENTRY(psci_cpu_on) > mov r4, r1 > mov r0, r1 > mov r1, r2 > - bl psci_save_target_pc @ store target PC > + mov r2, r3 > + bl psci_save @ store target PC and context id > mov r1, r4
Hi Stephen, > From: Stephen Warren [mailto:swarren@wwwdotorg.org] > Subject: Re: [U-Boot] [PATCH 3/6] tegra: psci: save context id in cpu_on > command > Importance: High > > On 04/16/2018 02:15 AM, Patrick Delaunay wrote: > > Replace the psci_save_target_pc call by the new function > > psci_save(cpu, pc,context_id) > > So this function doesn't actually exist since it's added in a different patch series > that isn't mentioned as a dependency. Luckily I managed to find it in the list > archives I have, and assuming the dependency is applied first, Thanks for the review and sorry for the dependency with http://patchwork.ozlabs.org/patch/898507/ Not indicated in the patchset. For information, I plan this development after Mark Rutland remarks on v1 in http://patchwork.ozlabs.org/patch/888210/ I decide to send the serie in 2 separate patches as the second part is more a cleanup patch and need to be review tested by each maintainers. Do you think I need to RESEND this serie with a cover letter to indicate the dependency ? > Reviewed-by: Stephen Warren <swarren@nvidia.com> Patrick
On 04/18/2018 07:58 AM, Patrick DELAUNAY wrote: > Hi Stephen, > >> From: Stephen Warren [mailto:swarren@wwwdotorg.org] >> Subject: Re: [U-Boot] [PATCH 3/6] tegra: psci: save context id in cpu_on >> command >> Importance: High >> >> On 04/16/2018 02:15 AM, Patrick Delaunay wrote: >>> Replace the psci_save_target_pc call by the new function >>> psci_save(cpu, pc,context_id) >> >> So this function doesn't actually exist since it's added in a different patch series >> that isn't mentioned as a dependency. Luckily I managed to find it in the list >> archives I have, and assuming the dependency is applied first, > > Thanks for the review and sorry for the dependency with http://patchwork.ozlabs.org/patch/898507/ > Not indicated in the patchset. > > For information, I plan this development after Mark Rutland remarks on v1 in http://patchwork.ozlabs.org/patch/888210/ > > I decide to send the serie in 2 separate patches as the second part is more a cleanup patch and need to be review tested by each maintainers. > > Do you think I need to RESEND this serie with a cover letter to indicate the dependency ? I imagine this part of the thread is enough to alert Tom. If you need to resend the series for some reason, you can add the note then.
On Wed, Apr 18, 2018 at 09:23:36AM -0600, Stephen Warren wrote: > On 04/18/2018 07:58 AM, Patrick DELAUNAY wrote: > >Hi Stephen, > > > >>From: Stephen Warren [mailto:swarren@wwwdotorg.org] > >>Subject: Re: [U-Boot] [PATCH 3/6] tegra: psci: save context id in cpu_on > >>command > >>Importance: High > >> > >>On 04/16/2018 02:15 AM, Patrick Delaunay wrote: > >>>Replace the psci_save_target_pc call by the new function > >>>psci_save(cpu, pc,context_id) > >> > >>So this function doesn't actually exist since it's added in a different patch series > >>that isn't mentioned as a dependency. Luckily I managed to find it in the list > >>archives I have, and assuming the dependency is applied first, > > > >Thanks for the review and sorry for the dependency with http://patchwork.ozlabs.org/patch/898507/ > >Not indicated in the patchset. > > > >For information, I plan this development after Mark Rutland remarks on v1 in http://patchwork.ozlabs.org/patch/888210/ > > > >I decide to send the serie in 2 separate patches as the second part is more a cleanup patch and need to be review tested by each maintainers. > > > >Do you think I need to RESEND this serie with a cover letter to indicate the dependency ? > > I imagine this part of the thread is enough to alert Tom. If you need to > resend the series for some reason, you can add the note then. I'll keep this all in mind when I eventually apply things, thanks! :)
On Mon, Apr 16, 2018 at 10:15:09AM +0200, Patrick Delaunay wrote: > Replace the psci_save_target_pc call by the new function > psci_save(cpu, pc,context_id) > > Signed-off-by: Patrick Delaunay <patrick.delaunay@st.com> > Reviewed-by: Stephen Warren <swarren@nvidia.com> Applied to u-boot/master, thanks!
diff --git a/arch/arm/mach-tegra/psci.S b/arch/arm/mach-tegra/psci.S index 645d08f..448df83 100644 --- a/arch/arm/mach-tegra/psci.S +++ b/arch/arm/mach-tegra/psci.S @@ -90,7 +90,8 @@ ENTRY(psci_cpu_on) mov r4, r1 mov r0, r1 mov r1, r2 - bl psci_save_target_pc @ store target PC + mov r2, r3 + bl psci_save @ store target PC and context id mov r1, r4 ldr r6, =TEGRA_RESET_EXCEPTION_VECTOR
Replace the psci_save_target_pc call by the new function psci_save(cpu, pc,context_id) Signed-off-by: Patrick Delaunay <patrick.delaunay@st.com> --- arch/arm/mach-tegra/psci.S | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)