| Message ID | 1525350041-22995-4-git-send-email-absahu@codeaurora.org |
|---|---|
| State | Superseded |
| Delegated to: | Miquel Raynal |
| Headers | show |
| Series | Update for QCOM NAND driver | expand |
On Thu, 3 May 2018 17:50:30 +0530 Abhishek Sahu <absahu@codeaurora.org> wrote: > Now, nand-ecc-strength is optional. If specified in DT, then > controller will use this ECC strength otherwise ECC strength will > be calculated according to chip requirement and available OOB size. > > Signed-off-by: Abhishek Sahu <absahu@codeaurora.org> > --- > * Changes from v1: > > NEW PATCH > > Documentation/devicetree/bindings/mtd/qcom_nandc.txt | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/mtd/qcom_nandc.txt b/Documentation/devicetree/bindings/mtd/qcom_nandc.txt > index 73d336be..f246aa0 100644 > --- a/Documentation/devicetree/bindings/mtd/qcom_nandc.txt > +++ b/Documentation/devicetree/bindings/mtd/qcom_nandc.txt > @@ -45,11 +45,13 @@ Required properties: > number (e.g., 0, 1, 2, etc.) > - #address-cells: see partition.txt > - #size-cells: see partition.txt > -- nand-ecc-strength: see nand.txt > - nand-ecc-step-size: must be 512. see nand.txt for more details. As mentioned in my other review, no need to specify nand-ecc-step-size if you don't have a choice. You can remove the property and say that nand-ecc-strength encodes the ECC strength for 512 bytes chunks. > > Optional properties: > - nand-bus-width: see nand.txt > +- nand-ecc-strength: see nand.txt. If not specified, then ECC strength will > + be used according to chip requirement and available > + OOB size. > > Each nandcs device node may optionally contain a 'partitions' sub-node, which > further contains sub-nodes describing the flash partition mapping. See
Hi Abhishek, On Thu, 3 May 2018 17:50:30 +0530, Abhishek Sahu <absahu@codeaurora.org> wrote: > Now, nand-ecc-strength is optional. If specified in DT, then > controller will use this ECC strength otherwise ECC strength will > be calculated according to chip requirement and available OOB size. Same comment as before: don't start the commit log with "now,". Thanks, Miquèl
On 2018-05-21 20:02, Miquel Raynal wrote: > Hi Abhishek, > > On Thu, 3 May 2018 17:50:30 +0530, Abhishek Sahu > <absahu@codeaurora.org> wrote: > >> Now, nand-ecc-strength is optional. If specified in DT, then >> controller will use this ECC strength otherwise ECC strength will >> be calculated according to chip requirement and available OOB size. > > Same comment as before: don't start the commit log with "now,". > > Thanks, > Miquèl Thanks Miquel. I will change the commit message. Regards, Abhishek
diff --git a/Documentation/devicetree/bindings/mtd/qcom_nandc.txt b/Documentation/devicetree/bindings/mtd/qcom_nandc.txt index 73d336be..f246aa0 100644 --- a/Documentation/devicetree/bindings/mtd/qcom_nandc.txt +++ b/Documentation/devicetree/bindings/mtd/qcom_nandc.txt @@ -45,11 +45,13 @@ Required properties: number (e.g., 0, 1, 2, etc.) - #address-cells: see partition.txt - #size-cells: see partition.txt -- nand-ecc-strength: see nand.txt - nand-ecc-step-size: must be 512. see nand.txt for more details. Optional properties: - nand-bus-width: see nand.txt +- nand-ecc-strength: see nand.txt. If not specified, then ECC strength will + be used according to chip requirement and available + OOB size. Each nandcs device node may optionally contain a 'partitions' sub-node, which further contains sub-nodes describing the flash partition mapping. See
Now, nand-ecc-strength is optional. If specified in DT, then controller will use this ECC strength otherwise ECC strength will be calculated according to chip requirement and available OOB size. Signed-off-by: Abhishek Sahu <absahu@codeaurora.org> --- * Changes from v1: NEW PATCH Documentation/devicetree/bindings/mtd/qcom_nandc.txt | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)