| Message ID | 20180315123027.17696-1-kristian.evensen@gmail.com |
|---|---|
| State | Accepted |
| Delegated to: | John Crispin |
| Headers | show |
| Series | [OpenWrt-Devel] x86: Add APU3 reference to x86 board.d | expand |
On Thu, Mar 15, 2018 at 1:30 PM, Kristian Evensen <kristian.evensen@gmail.com> wrote: > There is a new APU-model available, APU3. The device is configured in > the same way as the APU1 and APU2, so the same LED/network setup can be > used. > > I considered changing the case to pc-engines-apu*, but I chose to follow > the existing pattern and add the full board name. Ping on this patch :) Perhaps it should have been sent to lede-dev instead? -Kristian
Looks okay to me. Are the cases stenciled with the port #’s? Last PC Engines board I had (a Alix 2D3) the firmware would detect the ports in the opposite order (PCI enumerator) than the markings on the case. > On Mar 15, 2018, at 6:30 AM, Kristian Evensen <kristian.evensen@gmail.com> wrote: > > There is a new APU-model available, APU3. The device is configured in > the same way as the APU1 and APU2, so the same LED/network setup can be > used. > > I considered changing the case to pc-engines-apu*, but I chose to follow > the existing pattern and add the full board name. > > Signed-off-by: Kristian Evensen <kristian.evensen@gmail.com> > --- > target/linux/x86/base-files/etc/board.d/01_leds | 2 +- > target/linux/x86/base-files/etc/board.d/02_network | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/target/linux/x86/base-files/etc/board.d/01_leds b/target/linux/x86/base-files/etc/board.d/01_leds > index 04e11705ac..25dc4aeeb1 100755 > --- a/target/linux/x86/base-files/etc/board.d/01_leds > +++ b/target/linux/x86/base-files/etc/board.d/01_leds > @@ -8,7 +8,7 @@ > board_config_update > > case "$(board_name)" in > -pc-engines-apu|pc-engines-apu2) > +pc-engines-apu|pc-engines-apu2|pc-engines-apu3) > ucidef_set_led_netdev "wan" "WAN" "apu2:green:led3" "eth0" > ucidef_set_led_netdev "lan" "LAN" "apu2:green:led2" "br-lan" > ucidef_set_led_default "diag" "DIAG" "apu2:green:power" "1" > diff --git a/target/linux/x86/base-files/etc/board.d/02_network b/target/linux/x86/base-files/etc/board.d/02_network > index bea696d8ff..c6e381b946 100755 > --- a/target/linux/x86/base-files/etc/board.d/02_network > +++ b/target/linux/x86/base-files/etc/board.d/02_network > @@ -9,7 +9,7 @@ > board_config_update > > case "$(board_name)" in > -pc-engines-apu|pc-engines-apu2) > +pc-engines-apu|pc-engines-apu2|pc-engines-apu3) > ucidef_set_interfaces_lan_wan "eth1 eth2" "eth0" > ;; > traverse-technologies-geos)
Hi, On Sat, Apr 21, 2018 at 2:58 AM, Philip Prindeville <philipp_subx@redfish-solutions.com> wrote: > Looks okay to me. Great! > Are the cases stenciled with the port #’s? No, there are no markings on the case. -Kristian
Hi, Am Sat, 21 Apr 2018 10:17:37 +0200 schrieb Kristian Evensen <kristian.evensen@gmail.com>: > > Are the cases stenciled with the port #’s? > > No, there are no markings on the case. just in case, that this detail is of any interest: the PCB contains labels for the three ethernet ports: http://pcengines.ch/pic/apu3a3.jpg (from: http://pcengines.ch/apu3a2.htm) Cheers, Lars
diff --git a/target/linux/x86/base-files/etc/board.d/01_leds b/target/linux/x86/base-files/etc/board.d/01_leds index 04e11705ac..25dc4aeeb1 100755 --- a/target/linux/x86/base-files/etc/board.d/01_leds +++ b/target/linux/x86/base-files/etc/board.d/01_leds @@ -8,7 +8,7 @@ board_config_update case "$(board_name)" in -pc-engines-apu|pc-engines-apu2) +pc-engines-apu|pc-engines-apu2|pc-engines-apu3) ucidef_set_led_netdev "wan" "WAN" "apu2:green:led3" "eth0" ucidef_set_led_netdev "lan" "LAN" "apu2:green:led2" "br-lan" ucidef_set_led_default "diag" "DIAG" "apu2:green:power" "1" diff --git a/target/linux/x86/base-files/etc/board.d/02_network b/target/linux/x86/base-files/etc/board.d/02_network index bea696d8ff..c6e381b946 100755 --- a/target/linux/x86/base-files/etc/board.d/02_network +++ b/target/linux/x86/base-files/etc/board.d/02_network @@ -9,7 +9,7 @@ board_config_update case "$(board_name)" in -pc-engines-apu|pc-engines-apu2) +pc-engines-apu|pc-engines-apu2|pc-engines-apu3) ucidef_set_interfaces_lan_wan "eth1 eth2" "eth0" ;; traverse-technologies-geos)
There is a new APU-model available, APU3. The device is configured in the same way as the APU1 and APU2, so the same LED/network setup can be used. I considered changing the case to pc-engines-apu*, but I chose to follow the existing pattern and add the full board name. Signed-off-by: Kristian Evensen <kristian.evensen@gmail.com> --- target/linux/x86/base-files/etc/board.d/01_leds | 2 +- target/linux/x86/base-files/etc/board.d/02_network | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)