| Message ID | d025236bb2646eb3b4d4de9f2e745cab5d7ef2b9.1523881182.git.gustavo.pimentel@synopsys.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Designware EP support and code clean up | expand |
Hi, On Monday 16 April 2018 08:07 PM, Gustavo Pimentel wrote: > Adds a seconds entry on the pci_epf_test_ids structure that disables the > linkup_notifier parameter on driver. > > This allows EPs that doesn't have linkup notification signal to work > with pcitest. > > Signed-off-by: Gustavo Pimentel <gustavo.pimentel@synopsys.com> > --- > Change v2->v3: > - Added second entry in pci_epf_test_ids structure. > - Remove test_reg_bar field assignment on second entry. > Changes v3->v4: > - Nothing changed, just to follow the patch set version. > > drivers/pci/endpoint/functions/pci-epf-test.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/pci/endpoint/functions/pci-epf-test.c b/drivers/pci/endpoint/functions/pci-epf-test.c > index 7cef851..63dca44 100644 > --- a/drivers/pci/endpoint/functions/pci-epf-test.c > +++ b/drivers/pci/endpoint/functions/pci-epf-test.c > @@ -459,10 +459,18 @@ static int pci_epf_test_bind(struct pci_epf *epf) > return 0; > } > > +static const struct pci_epf_test_data data_cfg2 = { > + .linkup_notifier = false > +}; > + > static const struct pci_epf_device_id pci_epf_test_ids[] = { > { > .name = "pci_epf_test", > }, > + { > + .name = "pci_epf_test_cfg2", I'd prefer this to be named pci_epf_test_designware so that configfs entry is self explanatory. Thanks Kishon
Hi, On Tuesday 17 April 2018 02:49 PM, Kishon Vijay Abraham I wrote: > Hi, > > On Monday 16 April 2018 08:07 PM, Gustavo Pimentel wrote: >> Adds a seconds entry on the pci_epf_test_ids structure that disables the >> linkup_notifier parameter on driver. >> >> This allows EPs that doesn't have linkup notification signal to work >> with pcitest. >> >> Signed-off-by: Gustavo Pimentel <gustavo.pimentel@synopsys.com> >> --- >> Change v2->v3: >> - Added second entry in pci_epf_test_ids structure. >> - Remove test_reg_bar field assignment on second entry. >> Changes v3->v4: >> - Nothing changed, just to follow the patch set version. >> >> drivers/pci/endpoint/functions/pci-epf-test.c | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> >> diff --git a/drivers/pci/endpoint/functions/pci-epf-test.c b/drivers/pci/endpoint/functions/pci-epf-test.c >> index 7cef851..63dca44 100644 >> --- a/drivers/pci/endpoint/functions/pci-epf-test.c >> +++ b/drivers/pci/endpoint/functions/pci-epf-test.c >> @@ -459,10 +459,18 @@ static int pci_epf_test_bind(struct pci_epf *epf) >> return 0; >> } >> >> +static const struct pci_epf_test_data data_cfg2 = { >> + .linkup_notifier = false >> +}; >> + >> static const struct pci_epf_device_id pci_epf_test_ids[] = { >> { >> .name = "pci_epf_test", >> }, >> + { >> + .name = "pci_epf_test_cfg2", > > I'd prefer this to be named pci_epf_test_designware so that configfs entry is > self explanatory. Please document the new epf binding in Documentation/PCI/endpoint/function/binding/pci-test.txt Thanks Kishon
diff --git a/drivers/pci/endpoint/functions/pci-epf-test.c b/drivers/pci/endpoint/functions/pci-epf-test.c index 7cef851..63dca44 100644 --- a/drivers/pci/endpoint/functions/pci-epf-test.c +++ b/drivers/pci/endpoint/functions/pci-epf-test.c @@ -459,10 +459,18 @@ static int pci_epf_test_bind(struct pci_epf *epf) return 0; } +static const struct pci_epf_test_data data_cfg2 = { + .linkup_notifier = false +}; + static const struct pci_epf_device_id pci_epf_test_ids[] = { { .name = "pci_epf_test", }, + { + .name = "pci_epf_test_cfg2", + .driver_data = (kernel_ulong_t)&data_cfg2, + }, {}, };
Adds a seconds entry on the pci_epf_test_ids structure that disables the linkup_notifier parameter on driver. This allows EPs that doesn't have linkup notification signal to work with pcitest. Signed-off-by: Gustavo Pimentel <gustavo.pimentel@synopsys.com> --- Change v2->v3: - Added second entry in pci_epf_test_ids structure. - Remove test_reg_bar field assignment on second entry. Changes v3->v4: - Nothing changed, just to follow the patch set version. drivers/pci/endpoint/functions/pci-epf-test.c | 8 ++++++++ 1 file changed, 8 insertions(+)