| Message ID | 20180410174959.18757-2-vinicius.gomes@intel.com |
|---|---|
| State | Accepted |
| Delegated to: | Jeff Kirsher |
| Headers | show |
| Series | igb: offloading of receive filters | expand |
> From: netdev-owner@vger.kernel.org [mailto:netdev- > owner@vger.kernel.org] On Behalf Of Vinicius Costa Gomes > Sent: Tuesday, April 10, 2018 10:50 AM > To: intel-wired-lan@lists.osuosl.org > Cc: Gomes, Vinicius <vinicius.gomes@intel.com>; Kirsher, Jeffrey T > <jeffrey.t.kirsher@intel.com>; netdev@vger.kernel.org; Sanchez-Palencia, > Jesus <jesus.sanchez-palencia@intel.com> > Subject: [next-queue PATCH v7 01/10] igb: Fix not adding filter elements to > the list > > Because the order of the parameters passes to 'hlist_add_behind()' was > inverted, the 'parent' node was added "behind" the 'input', as input > is not in the list, this causes the 'input' node to be lost. > > Fixes: 0e71def25281 ("igb: add support of RX network flow classification") > Signed-off-by: Vinicius Costa Gomes <vinicius.gomes@intel.com> > --- > drivers/net/ethernet/intel/igb/igb_ethtool.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Tested by: Aaron Brown <aaron.f.brown@intel.com>
> From: Brown, Aaron F > Sent: Friday, April 13, 2018 7:17 PM > To: 'Vinicius Costa Gomes' <vinicius.gomes@intel.com>; intel-wired- > lan@lists.osuosl.org > Cc: Gomes, Vinicius <vinicius.gomes@intel.com>; Kirsher, Jeffrey T > <jeffrey.t.kirsher@intel.com>; netdev@vger.kernel.org; Sanchez-Palencia, > Jesus <jesus.sanchez-palencia@intel.com> > Subject: RE: [next-queue PATCH v7 01/10] igb: Fix not adding filter elements > to the list > > > From: netdev-owner@vger.kernel.org [mailto:netdev- > > owner@vger.kernel.org] On Behalf Of Vinicius Costa Gomes > > Sent: Tuesday, April 10, 2018 10:50 AM > > To: intel-wired-lan@lists.osuosl.org > > Cc: Gomes, Vinicius <vinicius.gomes@intel.com>; Kirsher, Jeffrey T > > <jeffrey.t.kirsher@intel.com>; netdev@vger.kernel.org; Sanchez-Palencia, > > Jesus <jesus.sanchez-palencia@intel.com> > > Subject: [next-queue PATCH v7 01/10] igb: Fix not adding filter elements to > > the list > > > > Because the order of the parameters passes to 'hlist_add_behind()' was > > inverted, the 'parent' node was added "behind" the 'input', as input > > is not in the list, this causes the 'input' node to be lost. > > > > Fixes: 0e71def25281 ("igb: add support of RX network flow classification") > > Signed-off-by: Vinicius Costa Gomes <vinicius.gomes@intel.com> > > --- > > drivers/net/ethernet/intel/igb/igb_ethtool.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > Tested by: Aaron Brown <aaron.f.brown@intel.com> Resending with "Tested-by..." rather then "Tested by..." so that patchwork actually picks it up. What I get for signing off on the mails late Friday. Tested-by: Aaron Brown <aaron.f.brown@intel.com>
diff --git a/drivers/net/ethernet/intel/igb/igb_ethtool.c b/drivers/net/ethernet/intel/igb/igb_ethtool.c index e77ba0d5866d..5975d432836f 100644 --- a/drivers/net/ethernet/intel/igb/igb_ethtool.c +++ b/drivers/net/ethernet/intel/igb/igb_ethtool.c @@ -2865,7 +2865,7 @@ static int igb_update_ethtool_nfc_entry(struct igb_adapter *adapter, /* add filter to the list */ if (parent) - hlist_add_behind(&parent->nfc_node, &input->nfc_node); + hlist_add_behind(&input->nfc_node, &parent->nfc_node); else hlist_add_head(&input->nfc_node, &adapter->nfc_filter_list);
Because the order of the parameters passes to 'hlist_add_behind()' was inverted, the 'parent' node was added "behind" the 'input', as input is not in the list, this causes the 'input' node to be lost. Fixes: 0e71def25281 ("igb: add support of RX network flow classification") Signed-off-by: Vinicius Costa Gomes <vinicius.gomes@intel.com> --- drivers/net/ethernet/intel/igb/igb_ethtool.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)