| Message ID | 20180411214257.14902-1-rjpdasilva@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | dt-bindings: pinctrl: mcp23s08: Clarify gpiospec flags cell usage | expand |
On Wed, Apr 11, 2018 at 10:42:57PM +0100, Ricardo Silva wrote: > The pinctrl-mcp23s08 driver doesn't provide a specific gpiospec > of_xlate() function, causing the gpiolib-of's of_gpio_simple_xlate() > function to be used instead, which takes the gpiospec's second cell as > the flags specifier according to 'include/dt-bindings/gpio/gpio.h'. > > The pinctrl-mcp23s08 bindings document was mentioning that the flags > were unused, which is not accurate because values in that second cell > are indeed used by the gpiolib-of's of_gpio_simple_xlate() for > configuring the gpio (e.g. its polarity). > > This way, replace the "flags currently unused" reference in the > dt-bindings document with references to the appropriate files specifying > the possible flag values and gpiospec description. > > CC: devicetree@vger.kernel.org > Signed-off-by: Ricardo Silva <rjpdasilva@gmail.com> > --- > .../devicetree/bindings/pinctrl/pinctrl-mcp23s08.txt | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) Reviewed-by: Rob Herring <robh@kernel.org> -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Apr 11, 2018 at 11:42 PM, Ricardo Silva <rjpdasilva@gmail.com> wrote: > The pinctrl-mcp23s08 driver doesn't provide a specific gpiospec > of_xlate() function, causing the gpiolib-of's of_gpio_simple_xlate() > function to be used instead, which takes the gpiospec's second cell as > the flags specifier according to 'include/dt-bindings/gpio/gpio.h'. > > The pinctrl-mcp23s08 bindings document was mentioning that the flags > were unused, which is not accurate because values in that second cell > are indeed used by the gpiolib-of's of_gpio_simple_xlate() for > configuring the gpio (e.g. its polarity). > > This way, replace the "flags currently unused" reference in the > dt-bindings document with references to the appropriate files specifying > the possible flag values and gpiospec description. > > CC: devicetree@vger.kernel.org > Signed-off-by: Ricardo Silva <rjpdasilva@gmail.com> Patch applied with Rob's review tag. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/pinctrl/pinctrl-mcp23s08.txt b/Documentation/devicetree/bindings/pinctrl/pinctrl-mcp23s08.txt index 9c451c20dda4..c357c99c948f 100644 --- a/Documentation/devicetree/bindings/pinctrl/pinctrl-mcp23s08.txt +++ b/Documentation/devicetree/bindings/pinctrl/pinctrl-mcp23s08.txt @@ -18,7 +18,9 @@ Required properties: removed. - #gpio-cells : Should be two. - first cell is the pin number - - second cell is used to specify flags. Flags are currently unused. + - second cell is used to specify flags as described in + 'Documentation/devicetree/bindings/gpio/gpio.txt'. Allowed values defined by + 'include/dt-bindings/gpio/gpio.h' (e.g. GPIO_ACTIVE_LOW). - gpio-controller : Marks the device node as a GPIO controller. - reg : For an address on its bus. I2C uses this a the I2C address of the chip. SPI uses this to specify the chipselect line which the chip is
The pinctrl-mcp23s08 driver doesn't provide a specific gpiospec of_xlate() function, causing the gpiolib-of's of_gpio_simple_xlate() function to be used instead, which takes the gpiospec's second cell as the flags specifier according to 'include/dt-bindings/gpio/gpio.h'. The pinctrl-mcp23s08 bindings document was mentioning that the flags were unused, which is not accurate because values in that second cell are indeed used by the gpiolib-of's of_gpio_simple_xlate() for configuring the gpio (e.g. its polarity). This way, replace the "flags currently unused" reference in the dt-bindings document with references to the appropriate files specifying the possible flag values and gpiospec description. CC: devicetree@vger.kernel.org Signed-off-by: Ricardo Silva <rjpdasilva@gmail.com> --- .../devicetree/bindings/pinctrl/pinctrl-mcp23s08.txt | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)