Message ID | a3eebc66b17172b92e91d95c12a9d0289b9417c2.1523360166.git.gustavo.pimentel@synopsys.com |
---|---|
State | Superseded |
Delegated to: | Lorenzo Pieralisi |
Headers | show |
Series | Designware EP support and code clean up | expand |
On Tue, Apr 10, 2018 at 01:58:33PM +0100, Gustavo Pimentel wrote: > Replaces "ctrlreg" reg-name by "dbi" to be coherent with similar drivers, > however it still be compatible with any previous DT that uses the old > reg-name. > > Replaces the PCIe base address example by a real PCIe base address in use. > > Signed-off-by: Gustavo Pimentel <gustavo.pimentel@synopsys.com> > --- > Changes v1->v2: > - Removed any iATU reference or changes to avoid confusion. > - Add "snps,dw-pcie" compatible string following Kishon's suggestion. > Changes v2->v3: > - Nothing changed, just to follow the patch set version. > > Documentation/devicetree/bindings/pci/designware-pcie.txt | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/Documentation/devicetree/bindings/pci/designware-pcie.txt b/Documentation/devicetree/bindings/pci/designware-pcie.txt > index 1da7ade..f02cd20 100644 > --- a/Documentation/devicetree/bindings/pci/designware-pcie.txt > +++ b/Documentation/devicetree/bindings/pci/designware-pcie.txt > @@ -1,7 +1,8 @@ > * Synopsys DesignWare PCIe interface > > Required properties: > -- compatible: should contain "snps,dw-pcie" to identify the core. > +- compatible: > + "snps,dw-pcie-rc", "snps,dw-pcie" for RC mode; I think adding this compatible is pointless. "snps,dw-pcie" meant RC and should continue to mean that. We also have compatibles with the IP version number as well as the SoC specific compatible strings. We don't need 4 compatible strings here. Rob
Hi Rob, On 13/04/2018 22:34, Rob Herring wrote: > On Tue, Apr 10, 2018 at 01:58:33PM +0100, Gustavo Pimentel wrote: >> Replaces "ctrlreg" reg-name by "dbi" to be coherent with similar drivers, >> however it still be compatible with any previous DT that uses the old >> reg-name. >> >> Replaces the PCIe base address example by a real PCIe base address in use. >> >> Signed-off-by: Gustavo Pimentel <gustavo.pimentel@synopsys.com> >> --- >> Changes v1->v2: >> - Removed any iATU reference or changes to avoid confusion. >> - Add "snps,dw-pcie" compatible string following Kishon's suggestion. >> Changes v2->v3: >> - Nothing changed, just to follow the patch set version. >> >> Documentation/devicetree/bindings/pci/designware-pcie.txt | 14 +++++++------- >> 1 file changed, 7 insertions(+), 7 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/pci/designware-pcie.txt b/Documentation/devicetree/bindings/pci/designware-pcie.txt >> index 1da7ade..f02cd20 100644 >> --- a/Documentation/devicetree/bindings/pci/designware-pcie.txt >> +++ b/Documentation/devicetree/bindings/pci/designware-pcie.txt >> @@ -1,7 +1,8 @@ >> * Synopsys DesignWare PCIe interface >> >> Required properties: >> -- compatible: should contain "snps,dw-pcie" to identify the core. >> +- compatible: >> + "snps,dw-pcie-rc", "snps,dw-pcie" for RC mode; > > I think adding this compatible is pointless. "snps,dw-pcie" meant RC and > should continue to mean that. We also have compatibles with the IP > version number as well as the SoC specific compatible strings. We don't > need 4 compatible strings here. Ok. > > Rob > Thanks, Gustavo
diff --git a/Documentation/devicetree/bindings/pci/designware-pcie.txt b/Documentation/devicetree/bindings/pci/designware-pcie.txt index 1da7ade..f02cd20 100644 --- a/Documentation/devicetree/bindings/pci/designware-pcie.txt +++ b/Documentation/devicetree/bindings/pci/designware-pcie.txt @@ -1,7 +1,8 @@ * Synopsys DesignWare PCIe interface Required properties: -- compatible: should contain "snps,dw-pcie" to identify the core. +- compatible: + "snps,dw-pcie-rc", "snps,dw-pcie" for RC mode; - reg: Should contain the configuration address space. - reg-names: Must be "config" for the PCIe configuration space. (The old way of getting the configuration address space from "ranges" @@ -41,11 +42,11 @@ EP mode: Example configuration: - pcie: pcie@dffff000 { - compatible = "snps,dw-pcie"; - reg = <0xdffff000 0x1000>, /* Controller registers */ - <0xd0000000 0x2000>; /* PCI config space */ - reg-names = "ctrlreg", "config"; + pcie: pcie@dfc00000 { + compatible = "snps,dw-pcie-rc", "snps,dw-pcie"; + reg = <0xdfc00000 0x0001000>, /* IP registers */ + <0xd0000000 0x0002000>; /* Configuration space */ + reg-names = "dbi", "config"; #address-cells = <3>; #size-cells = <2>; device_type = "pci"; @@ -54,5 +55,4 @@ Example configuration: interrupts = <25>, <24>; #interrupt-cells = <1>; num-lanes = <1>; - num-viewport = <3>; };
Replaces "ctrlreg" reg-name by "dbi" to be coherent with similar drivers, however it still be compatible with any previous DT that uses the old reg-name. Replaces the PCIe base address example by a real PCIe base address in use. Signed-off-by: Gustavo Pimentel <gustavo.pimentel@synopsys.com> --- Changes v1->v2: - Removed any iATU reference or changes to avoid confusion. - Add "snps,dw-pcie" compatible string following Kishon's suggestion. Changes v2->v3: - Nothing changed, just to follow the patch set version. Documentation/devicetree/bindings/pci/designware-pcie.txt | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)