| Message ID | 20110109224820.GB26607@mtj.dyndns.org (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
Hello Tejun,
On Sunday, 09.January.2011 23:48:20 Tejun Heo wrote:
> Fix it.
I can confirm that, it's fixed.
Thank's a lot. Should have looked into it, that was really a simple
fix.
Roman
On 01/09/2011 05:48 PM, Tejun Heo wrote: > pata_mpc52xx supports BMDMA but inherits ata_sff_port_ops which > triggers BUG_ON() when a DMA command is issued. Fix it. > > Signed-off-by: Tejun Heo<tj@kernel.org> > Reported-by: Roman Fietze<roman.fietze@telemotive.de> > Cc: Sergei Shtylyov<sshtylyov@mvista.com> > Cc: stable@kernel.org > --- > drivers/ata/pata_mpc52xx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/ata/pata_mpc52xx.c b/drivers/ata/pata_mpc52xx.c > index 8cc536e..d7d8026 100644 > --- a/drivers/ata/pata_mpc52xx.c > +++ b/drivers/ata/pata_mpc52xx.c > @@ -610,7 +610,7 @@ static struct scsi_host_template mpc52xx_ata_sht = { > }; > > static struct ata_port_operations mpc52xx_ata_port_ops = { > - .inherits =&ata_sff_port_ops, > + .inherits =&ata_bmdma_port_ops, > .sff_dev_select = mpc52xx_ata_dev_select, > .set_piomode = mpc52xx_ata_set_piomode, applied
diff --git a/drivers/ata/pata_mpc52xx.c b/drivers/ata/pata_mpc52xx.c index 8cc536e..d7d8026 100644 --- a/drivers/ata/pata_mpc52xx.c +++ b/drivers/ata/pata_mpc52xx.c @@ -610,7 +610,7 @@ static struct scsi_host_template mpc52xx_ata_sht = { }; static struct ata_port_operations mpc52xx_ata_port_ops = { - .inherits = &ata_sff_port_ops, + .inherits = &ata_bmdma_port_ops, .sff_dev_select = mpc52xx_ata_dev_select, .set_piomode = mpc52xx_ata_set_piomode, .set_dmamode = mpc52xx_ata_set_dmamode,
pata_mpc52xx supports BMDMA but inherits ata_sff_port_ops which triggers BUG_ON() when a DMA command is issued. Fix it. Signed-off-by: Tejun Heo <tj@kernel.org> Reported-by: Roman Fietze <roman.fietze@telemotive.de> Cc: Sergei Shtylyov <sshtylyov@mvista.com> Cc: stable@kernel.org --- drivers/ata/pata_mpc52xx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)