| Message ID | 1293175184-18746-1-git-send-email-thomas@wytron.com.tw |
|---|---|
| State | Accepted |
| Commit | e91d54535f8535c6de05044fa6f715a78f4320f8 |
| Delegated to: | Scott McNutt |
| Headers | show |
Dear Thomas Chou, In message <1293175184-18746-1-git-send-email-thomas@wytron.com.tw> you wrote: > Signed-off-by: Thomas Chou <thomas@wytron.com.tw> > --- > arch/nios2/include/asm/gpio.h | 6 ++++++ > board/altera/nios2-generic/gpio.c | 5 +++++ > 2 files changed, 11 insertions(+), 0 deletions(-) What is this needed for? I don;t see any callers, and the code doesn't do anything useful? Best regards, Wolfgang Denk
On Mon, Jan 10, 2011 at 4:27 PM, Wolfgang Denk wrote: > Thomas Chou wrote: >> Signed-off-by: Thomas Chou <thomas@wytron.com.tw> >> --- >> arch/nios2/include/asm/gpio.h | 6 ++++++ >> board/altera/nios2-generic/gpio.c | 5 +++++ >> 2 files changed, 11 insertions(+), 0 deletions(-) > > What is this needed for? I don;t see any callers, and the code > doesn't do anything useful? it's part of the standard GPIO API, his new OpenCores tiny_spi driver is using it, and cmd_gpio.c uses it (which is planning on moving to common code once i remove the tiny Blackfin-specific piece). -mike
Added to: git://git.denx.de/u-boot-nios.git 'next' Thank you, --Scott Thomas Chou wrote: > Signed-off-by: Thomas Chou <thomas@wytron.com.tw> > --- > arch/nios2/include/asm/gpio.h | 6 ++++++ > board/altera/nios2-generic/gpio.c | 5 +++++ > 2 files changed, 11 insertions(+), 0 deletions(-) > > diff --git a/arch/nios2/include/asm/gpio.h b/arch/nios2/include/asm/gpio.h > index cff1dd9..36a7132 100644 > --- a/arch/nios2/include/asm/gpio.h > +++ b/arch/nios2/include/asm/gpio.h > @@ -26,6 +26,11 @@ static inline int gpio_request(unsigned gpio, const char *label) > return 0; > } > > +static inline int gpio_free(unsigned gpio) > +{ > + return 0; > +} > + > static inline int gpio_direction_input(unsigned gpio) > { > writel(1, CONFIG_SYS_GPIO_BASE + (gpio << 2)); > @@ -49,6 +54,7 @@ static inline void gpio_set_value(unsigned gpio, int value) > } > #else > extern int gpio_request(unsigned gpio, const char *label); > +extern int gpio_free(unsigned gpio); > extern int gpio_direction_input(unsigned gpio); > extern int gpio_direction_output(unsigned gpio, int value); > extern int gpio_get_value(unsigned gpio); > diff --git a/board/altera/nios2-generic/gpio.c b/board/altera/nios2-generic/gpio.c > index d449684..8c639ce 100644 > --- a/board/altera/nios2-generic/gpio.c > +++ b/board/altera/nios2-generic/gpio.c > @@ -20,6 +20,11 @@ int gpio_request(unsigned gpio, const char *label) > return 0; > } > > +int gpio_free(unsigned gpio) > +{ > + return 0; > +} > + > int gpio_direction_input(unsigned gpio) > { > u32 mask = 1 << gpio;
diff --git a/arch/nios2/include/asm/gpio.h b/arch/nios2/include/asm/gpio.h index cff1dd9..36a7132 100644 --- a/arch/nios2/include/asm/gpio.h +++ b/arch/nios2/include/asm/gpio.h @@ -26,6 +26,11 @@ static inline int gpio_request(unsigned gpio, const char *label) return 0; } +static inline int gpio_free(unsigned gpio) +{ + return 0; +} + static inline int gpio_direction_input(unsigned gpio) { writel(1, CONFIG_SYS_GPIO_BASE + (gpio << 2)); @@ -49,6 +54,7 @@ static inline void gpio_set_value(unsigned gpio, int value) } #else extern int gpio_request(unsigned gpio, const char *label); +extern int gpio_free(unsigned gpio); extern int gpio_direction_input(unsigned gpio); extern int gpio_direction_output(unsigned gpio, int value); extern int gpio_get_value(unsigned gpio); diff --git a/board/altera/nios2-generic/gpio.c b/board/altera/nios2-generic/gpio.c index d449684..8c639ce 100644 --- a/board/altera/nios2-generic/gpio.c +++ b/board/altera/nios2-generic/gpio.c @@ -20,6 +20,11 @@ int gpio_request(unsigned gpio, const char *label) return 0; } +int gpio_free(unsigned gpio) +{ + return 0; +} + int gpio_direction_input(unsigned gpio) { u32 mask = 1 << gpio;
Signed-off-by: Thomas Chou <thomas@wytron.com.tw> --- arch/nios2/include/asm/gpio.h | 6 ++++++ board/altera/nios2-generic/gpio.c | 5 +++++ 2 files changed, 11 insertions(+), 0 deletions(-)