diff mbox series

arm64: dts: armada-3720-espressobin: Document URL for schematic

Message ID 20180316100124.29972-1-u.kleine-koenig@pengutronix.de
State New
Headers show
Series arm64: dts: armada-3720-espressobin: Document URL for schematic | expand

Commit Message

Uwe Kleine-König March 16, 2018, 10:01 a.m. UTC
The schematic of hte espressobin is publicly available, add a comment
where to find it.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
 arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts | 3 +++
 1 file changed, 3 insertions(+)

Comments

Andrew Lunn March 16, 2018, 2:14 p.m. UTC | #1
On Fri, Mar 16, 2018 at 11:01:24AM +0100, Uwe Kleine-König wrote:
> The schematic of hte espressobin is publicly available, add a comment
> where to find it.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
>  arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts b/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts
> index bdfb5553ddb5..6d070b267abe 100644
> --- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts
> +++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts
> @@ -42,6 +42,9 @@
>   *     FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
>   *     OTHER DEALINGS IN THE SOFTWARE.
>   */
> +/*
> + * Schematic available at http://espressobin.net/wp-content/uploads/2017/08/ESPRESSObin_V5_Schematics.pdf
> + */

Version 4 is also available:
http://wiki.espressobin.net/tiki-download_file.php?fileId=90. I've no
idea how you tell the boards apart. But my espressobin has more
jumpers behind the reset button than the board on the home page.

	Andrew
Uwe Kleine-König March 16, 2018, 2:53 p.m. UTC | #2
Hello Andrew,

On Fri, Mar 16, 2018 at 03:14:50PM +0100, Andrew Lunn wrote:
> On Fri, Mar 16, 2018 at 11:01:24AM +0100, Uwe Kleine-König wrote:
> > The schematic of hte espressobin is publicly available, add a comment
> > where to find it.
> > 
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > ---
> >  arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts b/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts
> > index bdfb5553ddb5..6d070b267abe 100644
> > --- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts
> > +++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts
> > @@ -42,6 +42,9 @@
> >   *     FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
> >   *     OTHER DEALINGS IN THE SOFTWARE.
> >   */
> > +/*
> > + * Schematic available at http://espressobin.net/wp-content/uploads/2017/08/ESPRESSObin_V5_Schematics.pdf
> > + */
> 
> Version 4 is also available:
> http://wiki.espressobin.net/tiki-download_file.php?fileId=90. I've no
> idea how you tell the boards apart. But my espressobin has more
> jumpers behind the reset button than the board on the home page.

on the back side my board has printed:

	ESPRESSObin_V5_0_1

between the ethernet ports and the blue USB port, so I guess V5 is the
right schematic for me. And my board has 3 3-pin-headers near the reset
button, these are described on page 7 of the V5 schematic.

Best regards
Uwe
Andrew Lunn March 16, 2018, 5:23 p.m. UTC | #3
On Fri, Mar 16, 2018 at 11:01:24AM +0100, Uwe Kleine-König wrote:
> The schematic of hte espressobin is publicly available, add a comment
> where to find it.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew
Uwe Kleine-König March 16, 2018, 7:58 p.m. UTC | #4
On Fri, Mar 16, 2018 at 11:01:24AM +0100, Uwe Kleine-König wrote:
> The schematic of hte espressobin is publicly available, add a comment

s/hte/the/

Maybe you can fix this up when applying?

Best regards
Uwe
Gregory CLEMENT March 19, 2018, 4:22 p.m. UTC | #5
Hi Uwe,
 
 On ven., mars 16 2018, Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote:

> The schematic of hte espressobin is publicly available, add a comment
> where to find it.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

Applied on mvebu/dt64 with the Reviewed-by from Andrew Lunn and the typo
fixed.

Thanks,

Gregory
> ---
>  arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts b/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts
> index bdfb5553ddb5..6d070b267abe 100644
> --- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts
> +++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts
> @@ -42,6 +42,9 @@
>   *     FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
>   *     OTHER DEALINGS IN THE SOFTWARE.
>   */
> +/*
> + * Schematic available at http://espressobin.net/wp-content/uploads/2017/08/ESPRESSObin_V5_Schematics.pdf
> + */
>  
>  /dts-v1/;
>  
> -- 
> 2.16.2
>
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts b/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts
index bdfb5553ddb5..6d070b267abe 100644
--- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts
+++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts
@@ -42,6 +42,9 @@ 
  *     FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
  *     OTHER DEALINGS IN THE SOFTWARE.
  */
+/*
+ * Schematic available at http://espressobin.net/wp-content/uploads/2017/08/ESPRESSObin_V5_Schematics.pdf
+ */
 
 /dts-v1/;