| Message ID | 1520600632-24955-1-git-send-email-yamada.masahiro@socionext.com |
|---|---|
| State | Accepted |
| Delegated to: | Boris Brezillon |
| Headers | show |
| Series | mtd: nand: remove STANDALONE compile mode of nand_ecc | expand |
On Fri, 9 Mar 2018 22:03:52 +0900 Masahiro Yamada <yamada.masahiro@socionext.com> wrote: > This file can not be built independently any more. We would have to > bring in more to resolve mtd_to_nand(mtd)->ecc.size, for example. > > It is difficult to notice a breakage since nobody compiles this mode. > It is not worth fixing or maintaining in my opinion. Remove. > Applied. Thanks, Boris > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > --- > > drivers/mtd/nand/raw/nand_ecc.c | 20 -------------------- > 1 file changed, 20 deletions(-) > > diff --git a/drivers/mtd/nand/raw/nand_ecc.c b/drivers/mtd/nand/raw/nand_ecc.c > index 3630f0f..8e132ed 100644 > --- a/drivers/mtd/nand/raw/nand_ecc.c > +++ b/drivers/mtd/nand/raw/nand_ecc.c > @@ -28,15 +28,6 @@ > * > */ > > -/* > - * The STANDALONE macro is useful when running the code outside the kernel > - * e.g. when running the code in a testbed or a benchmark program. > - * When STANDALONE is used, the module related macros are commented out > - * as well as the linux include files. > - * Instead a private definition of mtd_info is given to satisfy the compiler > - * (the code does not use mtd_info, so the code does not care) > - */ > -#ifndef STANDALONE > #include <linux/types.h> > #include <linux/kernel.h> > #include <linux/module.h> > @@ -44,17 +35,6 @@ > #include <linux/mtd/rawnand.h> > #include <linux/mtd/nand_ecc.h> > #include <asm/byteorder.h> > -#else > -#include <stdint.h> > -struct mtd_info; > -#define EXPORT_SYMBOL(x) /* x */ > - > -#define MODULE_LICENSE(x) /* x */ > -#define MODULE_AUTHOR(x) /* x */ > -#define MODULE_DESCRIPTION(x) /* x */ > - > -#define pr_err printf > -#endif > > /* > * invparity is a 256 byte table that contains the odd parity
diff --git a/drivers/mtd/nand/raw/nand_ecc.c b/drivers/mtd/nand/raw/nand_ecc.c index 3630f0f..8e132ed 100644 --- a/drivers/mtd/nand/raw/nand_ecc.c +++ b/drivers/mtd/nand/raw/nand_ecc.c @@ -28,15 +28,6 @@ * */ -/* - * The STANDALONE macro is useful when running the code outside the kernel - * e.g. when running the code in a testbed or a benchmark program. - * When STANDALONE is used, the module related macros are commented out - * as well as the linux include files. - * Instead a private definition of mtd_info is given to satisfy the compiler - * (the code does not use mtd_info, so the code does not care) - */ -#ifndef STANDALONE #include <linux/types.h> #include <linux/kernel.h> #include <linux/module.h> @@ -44,17 +35,6 @@ #include <linux/mtd/rawnand.h> #include <linux/mtd/nand_ecc.h> #include <asm/byteorder.h> -#else -#include <stdint.h> -struct mtd_info; -#define EXPORT_SYMBOL(x) /* x */ - -#define MODULE_LICENSE(x) /* x */ -#define MODULE_AUTHOR(x) /* x */ -#define MODULE_DESCRIPTION(x) /* x */ - -#define pr_err printf -#endif /* * invparity is a 256 byte table that contains the odd parity
This file can not be built independently any more. We would have to bring in more to resolve mtd_to_nand(mtd)->ecc.size, for example. It is difficult to notice a breakage since nobody compiles this mode. It is not worth fixing or maintaining in my opinion. Remove. Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> --- drivers/mtd/nand/raw/nand_ecc.c | 20 -------------------- 1 file changed, 20 deletions(-)