| Message ID | Pine.LNX.4.64.1101140005240.6059@digraph.polyomino.org.uk |
|---|---|
| State | New |
| Headers | show |
Joseph S. Myers wrote: > Two targets have CC1_SPEC containing %{save-temps: }. This is > completely useless; the only effect of a spec %{option:} (with no > contents conditional on -option being passed) is to ensure that > -option is accepted by the driver rather than rejected as unknown, and > -save-temps is automatically accepted by the driver without needing a > spec because it has "validated = true" in the case in > driver_handle_option. This patch removes these useless specs. OK to > commit? OK for microblaze.
On Fri, Jan 14, 2011 at 1:06 AM, Joseph S. Myers <joseph@codesourcery.com> wrote: > Two targets have CC1_SPEC containing %{save-temps: }. This is > completely useless; the only effect of a spec %{option:} (with no > contents conditional on -option being passed) is to ensure that > -option is accepted by the driver rather than rejected as unknown, and > -save-temps is automatically accepted by the driver without needing a > spec because it has "validated = true" in the case in > driver_handle_option. This patch removes these useless specs. OK to > commit? Ok. Thanks, Richard. > 2011-01-13 Joseph Myers <joseph@codesourcery.com> > > * config/microblaze/microblaze.h (CC1_SPEC): Remove %{save-temps: }. > * config/mips/mips.h (CC1_SPEC): Likewise. > > diff -rupN --exclude=.svn gcc-mainline-5/gcc/config/microblaze/microblaze.h gcc-mainline/gcc/config/microblaze/microblaze.h > --- gcc-mainline-5/gcc/config/microblaze/microblaze.h 2010-12-09 05:38:51.000000000 -0800 > +++ gcc-mainline/gcc/config/microblaze/microblaze.h 2011-01-12 14:11:16.000000000 -0800 > @@ -94,7 +94,6 @@ extern enum pipeline_type microblaze_pip > #ifndef CC1_SPEC > #define CC1_SPEC " \ > %{G*} %{gline:%{!g:%{!g0:%{!g1:%{!g2: -g1}}}}} \ > -%{save-temps: } \ > %(subtarget_cc1_spec) \ > %{mxl-multiply-high:-mcpu=v6.00.a} \ > " > diff -rupN --exclude=.svn gcc-mainline-5/gcc/config/mips/mips.h gcc-mainline/gcc/config/mips/mips.h > --- gcc-mainline-5/gcc/config/mips/mips.h 2010-12-31 07:04:38.000000000 -0800 > +++ gcc-mainline/gcc/config/mips/mips.h 2011-01-12 14:11:25.000000000 -0800 > @@ -1170,7 +1170,6 @@ enum mips_code_readable_setting { > #define CC1_SPEC "\ > %{gline:%{!g:%{!g0:%{!g1:%{!g2: -g1}}}}} \ > %{G*} %{EB:-meb} %{EL:-mel} %{EB:%{EL:%emay not use both -EB and -EL}} \ > -%{save-temps: } \ > %(subtarget_cc1_spec)" > > /* Preprocessor specs. */ > > -- > Joseph S. Myers > joseph@codesourcery.com >
diff -rupN --exclude=.svn gcc-mainline-5/gcc/config/microblaze/microblaze.h gcc-mainline/gcc/config/microblaze/microblaze.h --- gcc-mainline-5/gcc/config/microblaze/microblaze.h 2010-12-09 05:38:51.000000000 -0800 +++ gcc-mainline/gcc/config/microblaze/microblaze.h 2011-01-12 14:11:16.000000000 -0800 @@ -94,7 +94,6 @@ extern enum pipeline_type microblaze_pip #ifndef CC1_SPEC #define CC1_SPEC " \ %{G*} %{gline:%{!g:%{!g0:%{!g1:%{!g2: -g1}}}}} \ -%{save-temps: } \ %(subtarget_cc1_spec) \ %{mxl-multiply-high:-mcpu=v6.00.a} \ " diff -rupN --exclude=.svn gcc-mainline-5/gcc/config/mips/mips.h gcc-mainline/gcc/config/mips/mips.h --- gcc-mainline-5/gcc/config/mips/mips.h 2010-12-31 07:04:38.000000000 -0800 +++ gcc-mainline/gcc/config/mips/mips.h 2011-01-12 14:11:25.000000000 -0800 @@ -1170,7 +1170,6 @@ enum mips_code_readable_setting { #define CC1_SPEC "\ %{gline:%{!g:%{!g0:%{!g1:%{!g2: -g1}}}}} \ %{G*} %{EB:-meb} %{EL:-mel} %{EB:%{EL:%emay not use both -EB and -EL}} \ -%{save-temps: } \ %(subtarget_cc1_spec)" /* Preprocessor specs. */
Two targets have CC1_SPEC containing %{save-temps: }. This is completely useless; the only effect of a spec %{option:} (with no contents conditional on -option being passed) is to ensure that -option is accepted by the driver rather than rejected as unknown, and -save-temps is automatically accepted by the driver without needing a spec because it has "validated = true" in the case in driver_handle_option. This patch removes these useless specs. OK to commit? 2011-01-13 Joseph Myers <joseph@codesourcery.com> * config/microblaze/microblaze.h (CC1_SPEC): Remove %{save-temps: }. * config/mips/mips.h (CC1_SPEC): Likewise.