| Message ID | 20180308111305.C9F56745707@zero.eik.bme.hu |
|---|---|
| State | New |
| Headers | show |
| Series | ppc440_pcix: Change some error_report to qemu_log_mask(LOG_UNIMP, ...) | expand |
On 08.03.2018 12:08, BALATON Zoltan wrote: > Using log unimp is more appropriate for these messages and this also > silences them by default so they won't clobber make check output when > tests are added for this board. > > Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu> > --- > hw/ppc/ppc440_pcix.c | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/hw/ppc/ppc440_pcix.c b/hw/ppc/ppc440_pcix.c > index ab2626a..fbffe82 100644 > --- a/hw/ppc/ppc440_pcix.c > +++ b/hw/ppc/ppc440_pcix.c > @@ -286,8 +286,9 @@ static void ppc440_pcix_reg_write4(void *opaque, hwaddr addr, > break; > > default: > - error_report("%s: unhandled PCI internal register 0x%lx", __func__, > - (unsigned long)addr); > + qemu_log_mask(LOG_UNIMP, > + "%s: unhandled PCI internal register 0x%lx\n", __func__, > + (unsigned long)addr); > break; > } > } > @@ -377,8 +378,9 @@ static uint64_t ppc440_pcix_reg_read4(void *opaque, hwaddr addr, > break; > > default: > - error_report("%s: invalid PCI internal register 0x%lx", __func__, > - (unsigned long)addr); > + qemu_log_mask(LOG_UNIMP, > + "%s: invalid PCI internal register 0x%lx\n", __func__, > + (unsigned long)addr); > val = 0; > } Reviewed-by: Thomas Huth <thuth@redhat.com>
diff --git a/hw/ppc/ppc440_pcix.c b/hw/ppc/ppc440_pcix.c index ab2626a..fbffe82 100644 --- a/hw/ppc/ppc440_pcix.c +++ b/hw/ppc/ppc440_pcix.c @@ -286,8 +286,9 @@ static void ppc440_pcix_reg_write4(void *opaque, hwaddr addr, break; default: - error_report("%s: unhandled PCI internal register 0x%lx", __func__, - (unsigned long)addr); + qemu_log_mask(LOG_UNIMP, + "%s: unhandled PCI internal register 0x%lx\n", __func__, + (unsigned long)addr); break; } } @@ -377,8 +378,9 @@ static uint64_t ppc440_pcix_reg_read4(void *opaque, hwaddr addr, break; default: - error_report("%s: invalid PCI internal register 0x%lx", __func__, - (unsigned long)addr); + qemu_log_mask(LOG_UNIMP, + "%s: invalid PCI internal register 0x%lx\n", __func__, + (unsigned long)addr); val = 0; }
Using log unimp is more appropriate for these messages and this also silences them by default so they won't clobber make check output when tests are added for this board. Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu> --- hw/ppc/ppc440_pcix.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-)