| Message ID | a8ac13b48a00dbb6e633204fbee460f2396f95a1.1294136554.git.chouteau@adacore.com |
|---|---|
| State | New |
| Headers | show |
On 01/04/2011 11:27 AM, Fabien Chouteau wrote: > On Windows, this is required to flush the remaining data in the IO stream, > otherwise Gdb do not receive the last packet. > > Signed-off-by: Fabien Chouteau<chouteau@adacore.com> > --- > gdbstub.c | 4 ++++ > 1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/gdbstub.c b/gdbstub.c > index 0aa081b..dac3ce6 100644 > --- a/gdbstub.c > +++ b/gdbstub.c > @@ -2391,6 +2391,10 @@ void gdb_exit(CPUState *env, int code) > > snprintf(buf, sizeof(buf), "W%02x", (uint8_t)code); > put_packet(s, buf); > + > + if (s->chr) { > + qemu_chr_close(s->chr); > + } > } > > #ifdef CONFIG_USER_ONLY Any comment on this patch?
On Thu, Jan 13, 2011 at 10:24:50AM +0100, Fabien Chouteau wrote: > On 01/04/2011 11:27 AM, Fabien Chouteau wrote: > > On Windows, this is required to flush the remaining data in the IO stream, > > otherwise Gdb do not receive the last packet. > > > > Signed-off-by: Fabien Chouteau<chouteau@adacore.com> > > --- > > gdbstub.c | 4 ++++ > > 1 files changed, 4 insertions(+), 0 deletions(-) > > > > diff --git a/gdbstub.c b/gdbstub.c > > index 0aa081b..dac3ce6 100644 > > --- a/gdbstub.c > > +++ b/gdbstub.c > > @@ -2391,6 +2391,10 @@ void gdb_exit(CPUState *env, int code) > > > > snprintf(buf, sizeof(buf), "W%02x", (uint8_t)code); > > put_packet(s, buf); > > + > > + if (s->chr) { > > + qemu_chr_close(s->chr); > > + } > > } > > > > #ifdef CONFIG_USER_ONLY > > Any comment on this patch? Yes, sorry for the delays. This patch breaks the linux-user build. Cheers
On 01/13/2011 12:01 PM, Edgar E. Iglesias wrote: > On Thu, Jan 13, 2011 at 10:24:50AM +0100, Fabien Chouteau wrote: >> On 01/04/2011 11:27 AM, Fabien Chouteau wrote: >>> On Windows, this is required to flush the remaining data in the IO stream, >>> otherwise Gdb do not receive the last packet. >>> >>> Signed-off-by: Fabien Chouteau<chouteau@adacore.com> >>> --- >>> gdbstub.c | 4 ++++ >>> 1 files changed, 4 insertions(+), 0 deletions(-) >>> >>> diff --git a/gdbstub.c b/gdbstub.c >>> index 0aa081b..dac3ce6 100644 >>> --- a/gdbstub.c >>> +++ b/gdbstub.c >>> @@ -2391,6 +2391,10 @@ void gdb_exit(CPUState *env, int code) >>> >>> snprintf(buf, sizeof(buf), "W%02x", (uint8_t)code); >>> put_packet(s, buf); >>> + >>> + if (s->chr) { >>> + qemu_chr_close(s->chr); >>> + } >>> } >>> >>> #ifdef CONFIG_USER_ONLY >> >> Any comment on this patch? > > Yes, sorry for the delays. This patch breaks the linux-user build. thanks, I'll send new version in a minute.
diff --git a/gdbstub.c b/gdbstub.c index 0aa081b..dac3ce6 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -2391,6 +2391,10 @@ void gdb_exit(CPUState *env, int code) snprintf(buf, sizeof(buf), "W%02x", (uint8_t)code); put_packet(s, buf); + + if (s->chr) { + qemu_chr_close(s->chr); + } } #ifdef CONFIG_USER_ONLY
On Windows, this is required to flush the remaining data in the IO stream, otherwise Gdb do not receive the last packet. Signed-off-by: Fabien Chouteau <chouteau@adacore.com> --- gdbstub.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-)