Message ID | 1518623406-22992-1-git-send-email-jagan@amarulasolutions.com |
---|---|
State | Changes Requested |
Delegated to: | Philipp Tomsich |
Headers | show |
Series | [U-Boot,1/2] rockchip: rk3288: Add TPL_LDSCRIPT | expand |
> Due to size limitations in SPL by adding falcon mode, > rk3288 support TPL. In order to not overlap SPL_TEXT_BASE > add TPL_TEXT_BASE with u-boot-tpl.lds that intern call > u-boot-spl.lds with proper TEXT_BASE values. > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> > --- > arch/arm/mach-rockchip/Kconfig | 7 +++++++ > arch/arm/mach-rockchip/rk3288/u-boot-tpl.lds | 10 ++++++++++ > 2 files changed, 17 insertions(+) > create mode 100644 arch/arm/mach-rockchip/rk3288/u-boot-tpl.lds > Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
On Wed, 14 Feb 2018, Jagan Teki wrote: > Due to size limitations in SPL by adding falcon mode, > rk3288 support TPL. In order to not overlap SPL_TEXT_BASE > add TPL_TEXT_BASE with u-boot-tpl.lds that intern call > u-boot-spl.lds with proper TEXT_BASE values. A separate TPL_LDSCRIPT is needed only, if the SPL and TPL text base are to be different... is this the case (from include/configs/rk3288_common.h it seems that both SPL and TPL are starting in SRAM)? > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> > Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com> > --- > arch/arm/mach-rockchip/Kconfig | 7 +++++++ > arch/arm/mach-rockchip/rk3288/u-boot-tpl.lds | 10 ++++++++++ > 2 files changed, 17 insertions(+) > create mode 100644 arch/arm/mach-rockchip/rk3288/u-boot-tpl.lds > > diff --git a/arch/arm/mach-rockchip/Kconfig b/arch/arm/mach-rockchip/Kconfig > index 1e5a7bb..d9218da 100644 > --- a/arch/arm/mach-rockchip/Kconfig > +++ b/arch/arm/mach-rockchip/Kconfig > @@ -72,6 +72,13 @@ config ROCKCHIP_RK3288 > and video codec support. Peripherals include Gigabit Ethernet, > USB2 host and OTG, SDIO, I2S, UARTs, SPI, I2C and PWMs. > > +if ROCKCHIP_RK3288 > + > +config TPL_LDSCRIPT > + default "arch/arm/mach-rockchip/rk3288/u-boot-tpl.lds" > + > +endif > + > config ROCKCHIP_RK3328 > bool "Support Rockchip RK3328" > select ARM64 > diff --git a/arch/arm/mach-rockchip/rk3288/u-boot-tpl.lds b/arch/arm/mach-rockchip/rk3288/u-boot-tpl.lds > new file mode 100644 > index 0000000..c7a6092 > --- /dev/null > +++ b/arch/arm/mach-rockchip/rk3288/u-boot-tpl.lds > @@ -0,0 +1,10 @@ > +/* > + * Copyright (C) 2018 Jagan Teki <jagan@amarulasolutions.com> > + * > + * SPDX-License-Identifier: GPL-2.0+ > + */ > + > +#undef CONFIG_SPL_TEXT_BASE > +#define CONFIG_SPL_TEXT_BASE CONFIG_TPL_TEXT_BASE > + > +#include "../../cpu/u-boot-spl.lds" >
On Mon, Feb 19, 2018 at 1:05 AM, Philipp Tomsich <philipp.tomsich@theobroma-systems.com> wrote: > > > On Wed, 14 Feb 2018, Jagan Teki wrote: > >> Due to size limitations in SPL by adding falcon mode, >> rk3288 support TPL. In order to not overlap SPL_TEXT_BASE >> add TPL_TEXT_BASE with u-boot-tpl.lds that intern call >> u-boot-spl.lds with proper TEXT_BASE values. > > > A separate TPL_LDSCRIPT is needed only, if the SPL and TPL text base are to > be different... is this the case (from include/configs/rk3288_common.h > it seems that both SPL and TPL are starting in SRAM)? Yes, with TPL_BOOTROM TPL_TEXT is 0xff704000 SPL_TEXT is 0x0
diff --git a/arch/arm/mach-rockchip/Kconfig b/arch/arm/mach-rockchip/Kconfig index 1e5a7bb..d9218da 100644 --- a/arch/arm/mach-rockchip/Kconfig +++ b/arch/arm/mach-rockchip/Kconfig @@ -72,6 +72,13 @@ config ROCKCHIP_RK3288 and video codec support. Peripherals include Gigabit Ethernet, USB2 host and OTG, SDIO, I2S, UARTs, SPI, I2C and PWMs. +if ROCKCHIP_RK3288 + +config TPL_LDSCRIPT + default "arch/arm/mach-rockchip/rk3288/u-boot-tpl.lds" + +endif + config ROCKCHIP_RK3328 bool "Support Rockchip RK3328" select ARM64 diff --git a/arch/arm/mach-rockchip/rk3288/u-boot-tpl.lds b/arch/arm/mach-rockchip/rk3288/u-boot-tpl.lds new file mode 100644 index 0000000..c7a6092 --- /dev/null +++ b/arch/arm/mach-rockchip/rk3288/u-boot-tpl.lds @@ -0,0 +1,10 @@ +/* + * Copyright (C) 2018 Jagan Teki <jagan@amarulasolutions.com> + * + * SPDX-License-Identifier: GPL-2.0+ + */ + +#undef CONFIG_SPL_TEXT_BASE +#define CONFIG_SPL_TEXT_BASE CONFIG_TPL_TEXT_BASE + +#include "../../cpu/u-boot-spl.lds"
Due to size limitations in SPL by adding falcon mode, rk3288 support TPL. In order to not overlap SPL_TEXT_BASE add TPL_TEXT_BASE with u-boot-tpl.lds that intern call u-boot-spl.lds with proper TEXT_BASE values. Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> --- arch/arm/mach-rockchip/Kconfig | 7 +++++++ arch/arm/mach-rockchip/rk3288/u-boot-tpl.lds | 10 ++++++++++ 2 files changed, 17 insertions(+) create mode 100644 arch/arm/mach-rockchip/rk3288/u-boot-tpl.lds