| Message ID | 20180213173429.19501-1-stefanha@redhat.com |
|---|---|
| State | New |
| Headers | show |
On Tue, 02/13 17:34, Stefan Hajnoczi wrote: > The following changes since commit fb68096da3d35e64c88cd610c1fa42766c58e92a: > > Revert "tests: use memfd in vhost-user-test" (2018-02-13 09:51:52 +0000) > > are available in the Git repository at: > > git://github.com/stefanha/qemu.git tags/block-pull-request > > for you to fetch changes up to 64b01feca991e5b19a5d750ef77cdca92b68bdbb: > > misc: fix spelling (2018-02-13 15:38:17 +0000) Did you mean "PULL" in the subject? Fam
On Wed, Feb 14, 2018 at 08:48:20AM +0800, Fam Zheng wrote: > On Tue, 02/13 17:34, Stefan Hajnoczi wrote: > > The following changes since commit fb68096da3d35e64c88cd610c1fa42766c58e92a: > > > > Revert "tests: use memfd in vhost-user-test" (2018-02-13 09:51:52 +0000) > > > > are available in the Git repository at: > > > > git://github.com/stefanha/qemu.git tags/block-pull-request > > > > for you to fetch changes up to 64b01feca991e5b19a5d750ef77cdca92b68bdbb: > > > > misc: fix spelling (2018-02-13 15:38:17 +0000) > > Did you mean "PULL" in the subject? git-publish is just obeying your profile settings: +[gitpublishprofile "default"] +base = master +prefix = PATCH ^---- :) I used PULL myself in the past but am happy with using whatever we decide the standard should be. Shall we remove prefix from the profiles (it defaults to "PATCH" for regular patches and "PULL" for pull requests)? Stefan
On Wed, Feb 14, 2018 at 9:25 PM, Stefan Hajnoczi <stefanha@redhat.com> wrote: > On Wed, Feb 14, 2018 at 08:48:20AM +0800, Fam Zheng wrote: >> On Tue, 02/13 17:34, Stefan Hajnoczi wrote: >> > The following changes since commit fb68096da3d35e64c88cd610c1fa42766c58e92a: >> > >> > Revert "tests: use memfd in vhost-user-test" (2018-02-13 09:51:52 +0000) >> > >> > are available in the Git repository at: >> > >> > git://github.com/stefanha/qemu.git tags/block-pull-request >> > >> > for you to fetch changes up to 64b01feca991e5b19a5d750ef77cdca92b68bdbb: >> > >> > misc: fix spelling (2018-02-13 15:38:17 +0000) >> >> Did you mean "PULL" in the subject? > > git-publish is just obeying your profile settings: > > +[gitpublishprofile "default"] > +base = master > +prefix = PATCH > ^---- :) > > I used PULL myself in the past but am happy with using whatever we > decide the standard should be. > > Shall we remove prefix from the profiles (it defaults to "PATCH" for > regular patches and "PULL" for pull requests)? Yes, this is a bug. In my ~/.gitconfig I had "prefix = PATCH ..." for all other qemu-* profiles but not the main one, "qemu". When I wrote the patch I didn't realize it is so for a reason, and "fixed" it! Fam
On Wed, Feb 14, 2018 at 09:58:27PM +0800, Fam Zheng wrote: > On Wed, Feb 14, 2018 at 9:25 PM, Stefan Hajnoczi <stefanha@redhat.com> wrote: > > On Wed, Feb 14, 2018 at 08:48:20AM +0800, Fam Zheng wrote: > >> On Tue, 02/13 17:34, Stefan Hajnoczi wrote: > >> > The following changes since commit fb68096da3d35e64c88cd610c1fa42766c58e92a: > >> > > >> > Revert "tests: use memfd in vhost-user-test" (2018-02-13 09:51:52 +0000) > >> > > >> > are available in the Git repository at: > >> > > >> > git://github.com/stefanha/qemu.git tags/block-pull-request > >> > > >> > for you to fetch changes up to 64b01feca991e5b19a5d750ef77cdca92b68bdbb: > >> > > >> > misc: fix spelling (2018-02-13 15:38:17 +0000) > >> > >> Did you mean "PULL" in the subject? > > > > git-publish is just obeying your profile settings: > > > > +[gitpublishprofile "default"] > > +base = master > > +prefix = PATCH > > ^---- :) > > > > I used PULL myself in the past but am happy with using whatever we > > decide the standard should be. > > > > Shall we remove prefix from the profiles (it defaults to "PATCH" for > > regular patches and "PULL" for pull requests)? > > Yes, this is a bug. In my ~/.gitconfig I had "prefix = PATCH ..." for > all other qemu-* profiles but not the main one, "qemu". When I wrote > the patch I didn't realize it is so for a reason, and "fixed" it! Please resend your series once this email thread has run its course. I am dropping it from the pull request because I'd like to merge the other fixes in this pull request as soon as possible. Stefan