Message ID | 1515482234-24716-7-git-send-email-pchandru@nvidia.com |
---|---|
State | Superseded |
Headers | show |
Series | Refactor and add AHCI support for tegra210 | expand |
On 01/09/2018 09:17 AM, Preetham Chandru Ramchandra wrote: > From: Preetham Ramchandra <pchandru@nvidia.com> > > tegra does not support DIPM and it should be disabled Nit: Tegra should be capitalized otherwise, Reviewed-by: Mikko Perttunen <mperttunen@nvidia.com> > > Signed-off-by: Preetham Chandru R <pchandru@nvidia.com> > --- > drivers/ata/ahci_tegra.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/ata/ahci_tegra.c b/drivers/ata/ahci_tegra.c > index a59a97b1b2e5..013880de6412 100644 > --- a/drivers/ata/ahci_tegra.c > +++ b/drivers/ata/ahci_tegra.c > @@ -460,7 +460,7 @@ static struct ata_port_operations ahci_tegra_port_ops = { > }; > > static const struct ata_port_info ahci_tegra_port_info = { > - .flags = AHCI_FLAG_COMMON, > + .flags = AHCI_FLAG_COMMON | ATA_FLAG_NO_DIPM, > .pio_mask = ATA_PIO4, > .udma_mask = ATA_UDMA6, > .port_ops = &ahci_tegra_port_ops, > -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
>-----Original Message----- >From: Mikko Perttunen [mailto:cyndis@kapsi.fi] >Sent: Tuesday, January 23, 2018 9:23 PM >To: Preetham Chandru <pchandru@nvidia.com>; thierry.reding@gmail.com; >tj@kernel.org >Cc: preetham260@gmail.com; linux-tegra@vger.kernel.org; linux- >ide@vger.kernel.org; Venu Byravarasu <vbyravarasu@nvidia.com>; Pavan >Kunapuli <pkunapuli@nvidia.com> >Subject: Re: [PATCH V6 6/7] ata: ahci_tegra: disable DIPM > >On 01/09/2018 09:17 AM, Preetham Chandru Ramchandra wrote: >> From: Preetham Ramchandra <pchandru@nvidia.com> >> >> tegra does not support DIPM and it should be disabled > >Nit: Tegra should be capitalized > okay >otherwise, >Reviewed-by: Mikko Perttunen <mperttunen@nvidia.com> > >> >> Signed-off-by: Preetham Chandru R <pchandru@nvidia.com> >> --- >> drivers/ata/ahci_tegra.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/ata/ahci_tegra.c b/drivers/ata/ahci_tegra.c index >> a59a97b1b2e5..013880de6412 100644 >> --- a/drivers/ata/ahci_tegra.c >> +++ b/drivers/ata/ahci_tegra.c >> @@ -460,7 +460,7 @@ static struct ata_port_operations ahci_tegra_port_ops >= { >> }; >> >> static const struct ata_port_info ahci_tegra_port_info = { >> - .flags = AHCI_FLAG_COMMON, >> + .flags = AHCI_FLAG_COMMON | ATA_FLAG_NO_DIPM, >> .pio_mask = ATA_PIO4, >> .udma_mask = ATA_UDMA6, >> .port_ops = &ahci_tegra_port_ops, >>
diff --git a/drivers/ata/ahci_tegra.c b/drivers/ata/ahci_tegra.c index a59a97b1b2e5..013880de6412 100644 --- a/drivers/ata/ahci_tegra.c +++ b/drivers/ata/ahci_tegra.c @@ -460,7 +460,7 @@ static struct ata_port_operations ahci_tegra_port_ops = { }; static const struct ata_port_info ahci_tegra_port_info = { - .flags = AHCI_FLAG_COMMON, + .flags = AHCI_FLAG_COMMON | ATA_FLAG_NO_DIPM, .pio_mask = ATA_PIO4, .udma_mask = ATA_UDMA6, .port_ops = &ahci_tegra_port_ops,