Message ID | 20180211020330.32658-1-gael.portay@savoirfairelinux.com |
---|---|
State | Changes Requested |
Headers | show |
Series | [1/1] qt5webkit: add missing icu dependency | expand |
Hello, On Sat, 10 Feb 2018 21:03:30 -0500, Gaël PORTAY wrote: > The Config.in is already selecting BR2_PACKAGE_QT5BASE_ICU but the > dependency is missing from the QT5WEBKIT_DEPENDENCIES list in > qt5webkit.mk. And qt5base.mk has: QT5BASE_DEPENDENCIES += $(if $(BR2_PACKAGE_QT5BASE_ICU),icu) and in turn, qt5webkit depends on qt5base. Therefore, I don't see how you can fall into the situation where the qt5webkit build is started without icu being already built. Could you explain ? Thanks! Thomas
Thomas, On Sun, Feb 11, 2018 at 10:14:45AM +0100, Thomas Petazzoni wrote: > Hello, > > On Sat, 10 Feb 2018 21:03:30 -0500, Gaël PORTAY wrote: > > > The Config.in is already selecting BR2_PACKAGE_QT5BASE_ICU but the > > dependency is missing from the QT5WEBKIT_DEPENDENCIES list in > > qt5webkit.mk. > > And qt5base.mk has: > > QT5BASE_DEPENDENCIES += $(if $(BR2_PACKAGE_QT5BASE_ICU),icu) > > and in turn, qt5webkit depends on qt5base. > Good catch ! > Therefore, I don't see how you can fall into the situation where the > qt5webkit build is started without icu being already built. > > Could you explain ? > Well, I do not remember exactly the situation :/ It happened in development. I assume I had a qtbase already build (certainly without ICU support). And then, I build qtwebkit running `make qt5webkit`, the issue happened. BTW, I made a quick look to qtwebkit, and it does not seem to call some Qt ICU symbols. It looks qtwebkit requires ICU for its own needs. > Thanks! > > Thomas > -- > Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons) > Embedded Linux and Kernel engineering > http://bootlin.com > _______________________________________________ > buildroot mailing list > buildroot@busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot Regards, Gael
Hello, On Sun, 11 Feb 2018 09:49:26 -0500, Gaël PORTAY wrote: > > Therefore, I don't see how you can fall into the situation where the > > qt5webkit build is started without icu being already built. > > > > Could you explain ? > > > > Well, I do not remember exactly the situation :/ > > It happened in development. I assume I had a qtbase already build > (certainly without ICU support). And then, I build qtwebkit running > `make qt5webkit`, the issue happened. > > BTW, I made a quick look to qtwebkit, and it does not seem to call some > Qt ICU symbols. It looks qtwebkit requires ICU for its own needs. If that is truly the case, then qtwebkit should not select BR2_PACKAGE_QT5BASE_ICU. Can you try to make a build with qt5webkit enabled, but BR2_PACKAGE_QT5BASE_ICU disabled, and see what happens ? Perhaps this select BR2_PACKAGE_QT5BASE_ICU needs to be turned into a select BR2_PACKAGE_ICU + icu in QT5WEBKIT_DEPENDENCIES. Of course, make sure to verify for Qt 5.6 and Qt 5.9. I hope you have some decent build machines, because building qt5webkit is very long :) Best regards, Thomas
Thomas, On Mon, Feb 12, 2018 at 09:07:23PM +0100, Thomas Petazzoni wrote: > > BTW, I made a quick look to qtwebkit, and it does not seem to call some > > Qt ICU symbols. It looks qtwebkit requires ICU for its own needs. > > If that is truly the case, then qtwebkit should not select > BR2_PACKAGE_QT5BASE_ICU. Can you try to make a build with qt5webkit > enabled, but BR2_PACKAGE_QT5BASE_ICU disabled, and see what happens ? > > Perhaps this select BR2_PACKAGE_QT5BASE_ICU needs to be turned into a > select BR2_PACKAGE_ICU + icu in QT5WEBKIT_DEPENDENCIES. Of course, make > sure to verify for Qt 5.6 and Qt 5.9. I hope you have some decent build > machines, because building qt5webkit is very long :) > Fore sure! I already have a patch for this :) I need to find time to test it and make sure it still works without QT5 ICU. Hopefuly, I have access to a powerful machine now. I get the output within the next 1 hour. > Best regards, > > Thomas > -- > Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons) > Embedded Linux and Kernel engineering > http://bootlin.com Regards, Gael
diff --git a/package/qt5/qt5webkit/qt5webkit.mk b/package/qt5/qt5webkit/qt5webkit.mk index 7925b114e6..3b218a5385 100644 --- a/package/qt5/qt5webkit/qt5webkit.mk +++ b/package/qt5/qt5webkit/qt5webkit.mk @@ -16,7 +16,7 @@ endif QT5WEBKIT_SOURCE = qtwebkit-opensource-src-$(QT5WEBKIT_VERSION).tar.xz QT5WEBKIT_DEPENDENCIES = \ host-bison host-flex host-gperf host-python host-ruby \ - qt5base sqlite + icu qt5base sqlite QT5WEBKIT_INSTALL_STAGING = YES QT5WEBKIT_LICENSE_FILES = Source/WebCore/LICENSE-LGPL-2 Source/WebCore/LICENSE-LGPL-2.1