| Message ID | 1512254273-7567-1-git-send-email-shravan2x@utexas.edu |
|---|---|
| State | New |
| Headers | show |
| Series | qemu-img: Fixed grammatical error in dump_human_image_check | expand |
On Sat, 12/02 14:37, Shravan Rajinikanth wrote: > Signed-off-by: Shravan Rajinikanth <shravan2x@utexas.edu> > --- > qemu-img.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/qemu-img.c b/qemu-img.c > index 68b375f..bea9268 100644 > --- a/qemu-img.c > +++ b/qemu-img.c > @@ -580,7 +580,7 @@ static void dump_human_image_check(ImageCheck *check, bool quiet) > if (check->leaks) { > qprintf(quiet, > "\n%" PRId64 " leaked clusters were found on the image.\n" > - "This means waste of disk space, but no harm to data.\n", > + "This means disk space is wasted, but data is safe.\n", To me both versions seem fine, could you explain the grammatical error in the old message? Fam > check->leaks); > } > > -- > 2.7.4 > >
On 2017-12-02 23:37, Shravan Rajinikanth wrote: > Signed-off-by: Shravan Rajinikanth <shravan2x@utexas.edu> > --- > qemu-img.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/qemu-img.c b/qemu-img.c > index 68b375f..bea9268 100644 > --- a/qemu-img.c > +++ b/qemu-img.c > @@ -580,7 +580,7 @@ static void dump_human_image_check(ImageCheck *check, bool quiet) > if (check->leaks) { > qprintf(quiet, > "\n%" PRId64 " leaked clusters were found on the image.\n" > - "This means waste of disk space, but no harm to data.\n", > + "This means disk space is wasted, but data is safe.\n", > check->leaks); > } How exactly is this a grammatical error? (I'm not a native English speaker, but it always seemed perfectly OK to me) Max
On 4 December 2017 at 15:51, Max Reitz <mreitz@redhat.com> wrote: > On 2017-12-02 23:37, Shravan Rajinikanth wrote: >> Signed-off-by: Shravan Rajinikanth <shravan2x@utexas.edu> >> --- >> qemu-img.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/qemu-img.c b/qemu-img.c >> index 68b375f..bea9268 100644 >> --- a/qemu-img.c >> +++ b/qemu-img.c >> @@ -580,7 +580,7 @@ static void dump_human_image_check(ImageCheck *check, bool quiet) >> if (check->leaks) { >> qprintf(quiet, >> "\n%" PRId64 " leaked clusters were found on the image.\n" >> - "This means waste of disk space, but no harm to data.\n", >> + "This means disk space is wasted, but data is safe.\n", >> check->leaks); >> } > > How exactly is this a grammatical error? (I'm not a native English > speaker, but it always seemed perfectly OK to me) I think "This means" more naturally takes a verb phrase, not a noun phrase. I don't know that I'd go so far as to say that the current text is ungrammatical, but I do think the proposed change sounds more natural to me. thanks -- PMM
> To me both versions seem fine, could you explain the grammatical error in the > old message? My opinion aligns with Peter's, in that "This means" followed by "waste of" is a break in the sentence to a reader. Adding an "a" to change it to "This means a waste of" also seemed like a possible fix, but I made a call to change it "This means disk space is wasted" instead. This is mainly because the first sentence says leaked clusters "were found", which following the same tense in the next sentence should rather be "is wasted" (since the scan was only run once in the past, but disk space continues to be wasted even after the message is displayed). I'm no expert in the English language myself, so perhaps I was wrong in calling it a grammatical error. However, I do find the changed version more natural to read. Regards, Shravan On Mon, Dec 4, 2017 at 9:57 AM, Peter Maydell <peter.maydell@linaro.org> wrote: > On 4 December 2017 at 15:51, Max Reitz <mreitz@redhat.com> wrote: > > On 2017-12-02 23:37, Shravan Rajinikanth wrote: > >> Signed-off-by: Shravan Rajinikanth <shravan2x@utexas.edu> > >> --- > >> qemu-img.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/qemu-img.c b/qemu-img.c > >> index 68b375f..bea9268 100644 > >> --- a/qemu-img.c > >> +++ b/qemu-img.c > >> @@ -580,7 +580,7 @@ static void dump_human_image_check(ImageCheck > *check, bool quiet) > >> if (check->leaks) { > >> qprintf(quiet, > >> "\n%" PRId64 " leaked clusters were found on the > image.\n" > >> - "This means waste of disk space, but no harm to > data.\n", > >> + "This means disk space is wasted, but data is > safe.\n", > >> check->leaks); > >> } > > > > How exactly is this a grammatical error? (I'm not a native English > > speaker, but it always seemed perfectly OK to me) > > I think "This means" more naturally takes a verb phrase, not a noun phrase. > I don't know that I'd go so far as to say that the current text is > ungrammatical, but I do think the proposed change sounds more natural to > me. > > thanks > -- PMM >
On 2017-12-02 23:37, Shravan Rajinikanth wrote: > Signed-off-by: Shravan Rajinikanth <shravan2x@utexas.edu> > --- > qemu-img.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/qemu-img.c b/qemu-img.c > index 68b375f..bea9268 100644 > --- a/qemu-img.c > +++ b/qemu-img.c > @@ -580,7 +580,7 @@ static void dump_human_image_check(ImageCheck *check, bool quiet) > if (check->leaks) { > qprintf(quiet, > "\n%" PRId64 " leaked clusters were found on the image.\n" > - "This means waste of disk space, but no harm to data.\n", > + "This means disk space is wasted, but data is safe.\n", > check->leaks); > } Sorry, somehow I never applied this. (Maybe I thought it would go through trivial...) Applied to my block tree: https://github.com/XanClic/qemu/commits/block Max
On 2018-02-02 14:37, Max Reitz wrote: > On 2017-12-02 23:37, Shravan Rajinikanth wrote: >> Signed-off-by: Shravan Rajinikanth <shravan2x@utexas.edu> >> --- >> qemu-img.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/qemu-img.c b/qemu-img.c >> index 68b375f..bea9268 100644 >> --- a/qemu-img.c >> +++ b/qemu-img.c >> @@ -580,7 +580,7 @@ static void dump_human_image_check(ImageCheck *check, bool quiet) >> if (check->leaks) { >> qprintf(quiet, >> "\n%" PRId64 " leaked clusters were found on the image.\n" >> - "This means waste of disk space, but no harm to data.\n", >> + "This means disk space is wasted, but data is safe.\n", >> check->leaks); >> } > > Sorry, somehow I never applied this. (Maybe I thought it would go > through trivial...) > > Applied to my block tree: > > https://github.com/XanClic/qemu/commits/block I'll have to unstage it again because it breaks some iotests (026, 060, and 112), sorry. Max
diff --git a/qemu-img.c b/qemu-img.c index 68b375f..bea9268 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -580,7 +580,7 @@ static void dump_human_image_check(ImageCheck *check, bool quiet) if (check->leaks) { qprintf(quiet, "\n%" PRId64 " leaked clusters were found on the image.\n" - "This means waste of disk space, but no harm to data.\n", + "This means disk space is wasted, but data is safe.\n", check->leaks); }
Signed-off-by: Shravan Rajinikanth <shravan2x@utexas.edu> --- qemu-img.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)