| Message ID | 1515741233-1442-1-git-send-email-shilpa.bhat@linux.vnet.ibm.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | cpufreq: powernv: Dont assume distinct pstate values for nominal and pmin | expand |
On 12-01-18, 12:43, Shilpasri G Bhat wrote: > Some OpenPOWER boxes can have same pstate values for nominal and > pmin pstates. In these boxes the current code will not initialize > 'powernv_pstate_info.min' variable and result in erroneous CPU > frequency reporting. This patch fixes this problem. > > Fixes: 09ca4c9b5958 ("cpufreq: powernv: Replacing pstate_id with frequency table index") > Reported-by: Alvin Wang <wangat@tw.ibm.com> > Signed-off-by: Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com> > --- > drivers/cpufreq/powernv-cpufreq.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/cpufreq/powernv-cpufreq.c b/drivers/cpufreq/powernv-cpufreq.c > index b6d7c4c..da7fdb4 100644 > --- a/drivers/cpufreq/powernv-cpufreq.c > +++ b/drivers/cpufreq/powernv-cpufreq.c > @@ -288,9 +288,9 @@ static int init_powernv_pstates(void) > > if (id == pstate_max) > powernv_pstate_info.max = i; > - else if (id == pstate_nominal) > + if (id == pstate_nominal) > powernv_pstate_info.nominal = i; > - else if (id == pstate_min) > + if (id == pstate_min) > powernv_pstate_info.min = i; > > if (powernv_pstate_info.wof_enabled && id == pstate_turbo) { Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
diff --git a/drivers/cpufreq/powernv-cpufreq.c b/drivers/cpufreq/powernv-cpufreq.c index b6d7c4c..da7fdb4 100644 --- a/drivers/cpufreq/powernv-cpufreq.c +++ b/drivers/cpufreq/powernv-cpufreq.c @@ -288,9 +288,9 @@ static int init_powernv_pstates(void) if (id == pstate_max) powernv_pstate_info.max = i; - else if (id == pstate_nominal) + if (id == pstate_nominal) powernv_pstate_info.nominal = i; - else if (id == pstate_min) + if (id == pstate_min) powernv_pstate_info.min = i; if (powernv_pstate_info.wof_enabled && id == pstate_turbo) {
Some OpenPOWER boxes can have same pstate values for nominal and pmin pstates. In these boxes the current code will not initialize 'powernv_pstate_info.min' variable and result in erroneous CPU frequency reporting. This patch fixes this problem. Fixes: 09ca4c9b5958 ("cpufreq: powernv: Replacing pstate_id with frequency table index") Reported-by: Alvin Wang <wangat@tw.ibm.com> Signed-off-by: Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com> --- drivers/cpufreq/powernv-cpufreq.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)