| Message ID | 4D1C5123.4050804@rw-gmbh.de |
|---|---|
| State | Accepted |
| Commit | 24ac9a94f9e21ea71d877b0c80867d625b68bec2 |
| Headers | show |
On Thu, 30 Dec 2010 10:30:11 +0100, Ralf Rösch <ralf.roesch@rw-gmbh.de> wrote: > See commit: c0cbfd0e81d879a950ba6f0df3f75ea30c5ab16e > Using __nand_correct_data() helper function, this driver can read 512 > byte (with 6 byte ECC) at a time. > > This is correct, but not more: > With NAND chips providing page sizes > 512 Bytes > chip->ecc.bytes are calculated > 6 in txx9ndfmc_nand_scan. > According the data sheet there are (only) 6 bytes ECC available. > > After applying the patch a Hynix 512M*8 with 2k page size could be > successfully formatted and used with an ubifs file system. > > Signed-off-by: Ralf Roesch <ralf.roesch@rw-gmbh.de> Thank you for the fix. It is good news that this controller can work with large page NAND. Acked-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
On Thu, 2010-12-30 at 10:30 +0100, Ralf Rösch wrote: > See commit: c0cbfd0e81d879a950ba6f0df3f75ea30c5ab16e > Using __nand_correct_data() helper function, this driver can read 512 > byte (with 6 byte ECC) at a time. > > This is correct, but not more: > With NAND chips providing page sizes > 512 Bytes > chip->ecc.bytes are calculated > 6 in txx9ndfmc_nand_scan. > According the data sheet there are (only) 6 bytes ECC available. > > After applying the patch a Hynix 512M*8 with 2k page size could be > successfully formatted and used with an ubifs file system. > > Signed-off-by: Ralf Roesch <ralf.roesch@rw-gmbh.de> Pushed to l2-mtd-2.6.git, thanks!
diff --git a/drivers/mtd/nand/txx9ndfmc.c b/drivers/mtd/nand/txx9ndfmc.c index 054a41c..ca270a4 100644 --- a/drivers/mtd/nand/txx9ndfmc.c +++ b/drivers/mtd/nand/txx9ndfmc.c @@ -277,8 +277,9 @@ static int txx9ndfmc_nand_scan(struct mtd_info *mtd) ret = nand_scan_ident(mtd, 1, NULL); if (!ret) { if (mtd->writesize >= 512) { - chip->ecc.size = mtd->writesize; - chip->ecc.bytes = 3 * (mtd->writesize / 256); + /* Hardware ECC 6 byte ECC per 512 Byte data */ + chip->ecc.size = 512; + chip->ecc.bytes = 6; } ret = nand_scan_tail(mtd); }
See commit: c0cbfd0e81d879a950ba6f0df3f75ea30c5ab16e Using __nand_correct_data() helper function, this driver can read 512 byte (with 6 byte ECC) at a time. This is correct, but not more: With NAND chips providing page sizes > 512 Bytes chip->ecc.bytes are calculated > 6 in txx9ndfmc_nand_scan. According the data sheet there are (only) 6 bytes ECC available. After applying the patch a Hynix 512M*8 with 2k page size could be successfully formatted and used with an ubifs file system. Signed-off-by: Ralf Roesch <ralf.roesch@rw-gmbh.de> --- drivers/mtd/nand/txx9ndfmc.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-)