| Message ID | 20180103115455.25843-3-danielhb@linux.vnet.ibm.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v3,1/2] qmp: adding 'wakeup-suspend-support' in query-target | expand |
Quoting Daniel Henrique Barboza (2018-01-03 05:54:55) > This patch updates the descriptions of 'guest-suspend-ram' and > 'guest-suspend-hybrid' to mention that both commands relies now > on the existence of 'system_wakeup' and also on the proper support > for wake up from suspend, retrieved by the 'wakeup-suspend-support' > attribute of the 'query-target' QMP command. > > Signed-off-by: Daniel Henrique Barboza <danielhb@linux.vnet.ibm.com> Reviewed-by: Michael Roth <mdroth@linux.vnet.ibm.com> > --- > qga/qapi-schema.json | 14 ++++++++++---- > 1 file changed, 10 insertions(+), 4 deletions(-) > > diff --git a/qga/qapi-schema.json b/qga/qapi-schema.json > index 17884c7c70..e3fb8adfce 100644 > --- a/qga/qapi-schema.json > +++ b/qga/qapi-schema.json > @@ -566,8 +566,11 @@ > # package installed in the guest. > # > # IMPORTANT: guest-suspend-ram requires QEMU to support the 'system_wakeup' > -# command. Thus, it's *required* to query QEMU for the presence of the > -# 'system_wakeup' command before issuing guest-suspend-ram. > +# command and the guest to support wake up from suspend. Thus, it's > +# *required* to query QEMU for the presence of the 'system_wakeup' command > +# and to verify that wake up from suspend is enabled by checking the > +# 'wakeup-suspend-support' flag of 'query-target' QMP command, before issuing > +# guest-suspend-ram. > # > # This command does NOT return a response on success. There are two options > # to check for success: > @@ -593,8 +596,11 @@ > # This command requires the pm-utils package to be installed in the guest. > # > # IMPORTANT: guest-suspend-hybrid requires QEMU to support the 'system_wakeup' > -# command. Thus, it's *required* to query QEMU for the presence of the > -# 'system_wakeup' command before issuing guest-suspend-hybrid. > +# command and the guest to support wake up from suspend. Thus, it's > +# *required* to query QEMU for the presence of the 'system_wakeup' command > +# and to verify that wake up from suspend is enabled by checking the > +# 'wakeup-suspend-support' flag of 'query-target' QMP command, before issuing > +# guest-suspend-hybrid. > # > # This command does NOT return a response on success. There are two options > # to check for success: > -- > 2.13.6 >
diff --git a/qga/qapi-schema.json b/qga/qapi-schema.json index 17884c7c70..e3fb8adfce 100644 --- a/qga/qapi-schema.json +++ b/qga/qapi-schema.json @@ -566,8 +566,11 @@ # package installed in the guest. # # IMPORTANT: guest-suspend-ram requires QEMU to support the 'system_wakeup' -# command. Thus, it's *required* to query QEMU for the presence of the -# 'system_wakeup' command before issuing guest-suspend-ram. +# command and the guest to support wake up from suspend. Thus, it's +# *required* to query QEMU for the presence of the 'system_wakeup' command +# and to verify that wake up from suspend is enabled by checking the +# 'wakeup-suspend-support' flag of 'query-target' QMP command, before issuing +# guest-suspend-ram. # # This command does NOT return a response on success. There are two options # to check for success: @@ -593,8 +596,11 @@ # This command requires the pm-utils package to be installed in the guest. # # IMPORTANT: guest-suspend-hybrid requires QEMU to support the 'system_wakeup' -# command. Thus, it's *required* to query QEMU for the presence of the -# 'system_wakeup' command before issuing guest-suspend-hybrid. +# command and the guest to support wake up from suspend. Thus, it's +# *required* to query QEMU for the presence of the 'system_wakeup' command +# and to verify that wake up from suspend is enabled by checking the +# 'wakeup-suspend-support' flag of 'query-target' QMP command, before issuing +# guest-suspend-hybrid. # # This command does NOT return a response on success. There are two options # to check for success:
This patch updates the descriptions of 'guest-suspend-ram' and 'guest-suspend-hybrid' to mention that both commands relies now on the existence of 'system_wakeup' and also on the proper support for wake up from suspend, retrieved by the 'wakeup-suspend-support' attribute of the 'query-target' QMP command. Signed-off-by: Daniel Henrique Barboza <danielhb@linux.vnet.ibm.com> --- qga/qapi-schema.json | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-)