| Message ID | 1293750484-1161-3-git-send-email-justinmattock@gmail.com |
|---|---|
| State | Not Applicable, archived |
| Delegated to: | David Miller |
| Headers | show |
On 12/30/2010 05:07 PM, Justin P. Mattock wrote: > The below patch fixes a typo "diable" to "disable". Please let me know if this > is correct or not. > > Signed-off-by: Justin P. Mattock <justinmattock@gmail.com> > > --- ACKed-by: Larry Finger <Larry.Finger@lwfinger.net> > drivers/staging/rtl8187se/r8180_hw.h | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/staging/rtl8187se/r8180_hw.h b/drivers/staging/rtl8187se/r8180_hw.h > index 3fca144..2911d40 100644 > --- a/drivers/staging/rtl8187se/r8180_hw.h > +++ b/drivers/staging/rtl8187se/r8180_hw.h > @@ -554,7 +554,7 @@ > /* by amy for power save */ > /* by amy for antenna */ > #define EEPROM_SW_REVD_OFFSET 0x3f > -/* BIT[8-9] is for SW Antenna Diversity. Only the value EEPROM_SW_AD_ENABLE means enable, other values are diable. */ > +/* BIT[8-9] is for SW Antenna Diversity. Only the value EEPROM_SW_AD_ENABLE means enable, other values are disabled. */ > #define EEPROM_SW_AD_MASK 0x0300 > #define EEPROM_SW_AD_ENABLE 0x0100 > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, 30 Dec 2010, Justin P. Mattock wrote: > The below patch fixes a typo "diable" to "disable". Please let me know if this > is correct or not. > > Signed-off-by: Justin P. Mattock <justinmattock@gmail.com> > > --- > drivers/staging/rtl8187se/r8180_hw.h | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/staging/rtl8187se/r8180_hw.h b/drivers/staging/rtl8187se/r8180_hw.h > index 3fca144..2911d40 100644 > --- a/drivers/staging/rtl8187se/r8180_hw.h > +++ b/drivers/staging/rtl8187se/r8180_hw.h > @@ -554,7 +554,7 @@ > /* by amy for power save */ > /* by amy for antenna */ > #define EEPROM_SW_REVD_OFFSET 0x3f > -/* BIT[8-9] is for SW Antenna Diversity. Only the value EEPROM_SW_AD_ENABLE means enable, other values are diable. */ > +/* BIT[8-9] is for SW Antenna Diversity. Only the value EEPROM_SW_AD_ENABLE means enable, other values are disabled. */ I think, "other values disable" was what you meant? Finn > #define EEPROM_SW_AD_MASK 0x0300 > #define EEPROM_SW_AD_ENABLE 0x0100 > > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 12/31/2010 10:48 PM, Finn Thain wrote: > > On Thu, 30 Dec 2010, Justin P. Mattock wrote: > >> The below patch fixes a typo "diable" to "disable". Please let me know if this >> is correct or not. >> >> Signed-off-by: Justin P. Mattock<justinmattock@gmail.com> >> >> --- >> drivers/staging/rtl8187se/r8180_hw.h | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/drivers/staging/rtl8187se/r8180_hw.h b/drivers/staging/rtl8187se/r8180_hw.h >> index 3fca144..2911d40 100644 >> --- a/drivers/staging/rtl8187se/r8180_hw.h >> +++ b/drivers/staging/rtl8187se/r8180_hw.h >> @@ -554,7 +554,7 @@ >> /* by amy for power save */ >> /* by amy for antenna */ >> #define EEPROM_SW_REVD_OFFSET 0x3f >> -/* BIT[8-9] is for SW Antenna Diversity. Only the value EEPROM_SW_AD_ENABLE means enable, other values are diable. */ >> +/* BIT[8-9] is for SW Antenna Diversity. Only the value EEPROM_SW_AD_ENABLE means enable, other values are disabled. */ > > I think, "other values disable" was what you meant? > > Finn > >> #define EEPROM_SW_AD_MASK 0x0300 >> #define EEPROM_SW_AD_ENABLE 0x0100 >> >> > no! I changed it to disabled to make it proper.. Justin P. Mattock -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Dec 31, 2010 at 11:43:30PM -0800, Justin P. Mattock wrote: > On 12/31/2010 10:48 PM, Finn Thain wrote: > >>-/* BIT[8-9] is for SW Antenna Diversity. Only the value EEPROM_SW_AD_ENABLE means enable, other values are diable. */ > >>+/* BIT[8-9] is for SW Antenna Diversity. Only the value EEPROM_SW_AD_ENABLE means enable, other values are disabled. */ > > > >I think, "other values disable" was what you meant? > > > >Finn > > > >> #define EEPROM_SW_AD_MASK 0x0300 > >> #define EEPROM_SW_AD_ENABLE 0x0100 > >> > >> > > > > no! I changed it to disabled to make it proper.. Finn is obviously right, but maybe a compromise would be: Only the value EEPROM_SW_AD_ENABLE means "enable", other values mean "disable". regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 01/01/2011 01:09 AM, Dan Carpenter wrote: > On Fri, Dec 31, 2010 at 11:43:30PM -0800, Justin P. Mattock wrote: >> On 12/31/2010 10:48 PM, Finn Thain wrote: >>>> -/* BIT[8-9] is for SW Antenna Diversity. Only the value EEPROM_SW_AD_ENABLE means enable, other values are diable. */ >>>> +/* BIT[8-9] is for SW Antenna Diversity. Only the value EEPROM_SW_AD_ENABLE means enable, other values are disabled. */ >>> >>> I think, "other values disable" was what you meant? >>> >>> Finn >>> >>>> #define EEPROM_SW_AD_MASK 0x0300 >>>> #define EEPROM_SW_AD_ENABLE 0x0100 >>>> >>>> >>> >> >> no! I changed it to disabled to make it proper.. > > Finn is obviously right, but maybe a compromise would be: > > Only the value EEPROM_SW_AD_ENABLE means "enable", other values mean > "disable". > > regards, > dan carpenter > ahh.. I see what you your saying now.. alright let me send this out that way.. Justin P. Mattock -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/staging/rtl8187se/r8180_hw.h b/drivers/staging/rtl8187se/r8180_hw.h index 3fca144..2911d40 100644 --- a/drivers/staging/rtl8187se/r8180_hw.h +++ b/drivers/staging/rtl8187se/r8180_hw.h @@ -554,7 +554,7 @@ /* by amy for power save */ /* by amy for antenna */ #define EEPROM_SW_REVD_OFFSET 0x3f -/* BIT[8-9] is for SW Antenna Diversity. Only the value EEPROM_SW_AD_ENABLE means enable, other values are diable. */ +/* BIT[8-9] is for SW Antenna Diversity. Only the value EEPROM_SW_AD_ENABLE means enable, other values are disabled. */ #define EEPROM_SW_AD_MASK 0x0300 #define EEPROM_SW_AD_ENABLE 0x0100
The below patch fixes a typo "diable" to "disable". Please let me know if this is correct or not. Signed-off-by: Justin P. Mattock <justinmattock@gmail.com> --- drivers/staging/rtl8187se/r8180_hw.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)