| Message ID | ff1871fe837aa3a520fefe2602f8f1e13e1db244.1514475654.git.vilhelm.gray@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | Change ISA_BUS_API dependency to selection | expand |
On Thu, Dec 28, 2017 at 5:02 PM, William Breathitt Gray <vilhelm.gray@gmail.com> wrote: > The ISA_BUS_API Kconfig option enables the compilation of the ISA bus > driver. The ISA bus driver does not perform any hardware interaction, > and is instead just a thin layer of software abstraction to eliminate > boilerplate code common to ISA-style device drivers. Since ISA_BUS_API > has no dependencies and does not jeopardize the integrity of the system > when enabled, drivers should select it when the ISA bus driver > functionality is needed. > > Cc: Linus Walleij <linus.walleij@linaro.org> > Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com> Patch applied. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Jan 2, 2018 at 10:18 AM, Linus Walleij <linus.walleij@linaro.org> wrote: > On Thu, Dec 28, 2017 at 5:02 PM, William Breathitt Gray > <vilhelm.gray@gmail.com> wrote: > >> The ISA_BUS_API Kconfig option enables the compilation of the ISA bus >> driver. The ISA bus driver does not perform any hardware interaction, >> and is instead just a thin layer of software abstraction to eliminate >> boilerplate code common to ISA-style device drivers. Since ISA_BUS_API >> has no dependencies and does not jeopardize the integrity of the system >> when enabled, drivers should select it when the ISA bus driver >> functionality is needed. >> >> Cc: Linus Walleij <linus.walleij@linaro.org> >> Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com> > > Patch applied. Ooops there are newer patches, backed it out. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig index 395669bfcc26..36ad9ce3dc58 100644 --- a/drivers/gpio/Kconfig +++ b/drivers/gpio/Kconfig @@ -590,7 +590,8 @@ menu "Port-mapped I/O GPIO drivers" config GPIO_104_DIO_48E tristate "ACCES 104-DIO-48E GPIO support" - depends on PC104 && ISA_BUS_API + depends on PC104 + select ISA_BUS_API select GPIOLIB_IRQCHIP help Enables GPIO support for the ACCES 104-DIO-48E series (104-DIO-48E, @@ -600,7 +601,8 @@ config GPIO_104_DIO_48E config GPIO_104_IDIO_16 tristate "ACCES 104-IDIO-16 GPIO support" - depends on PC104 && ISA_BUS_API + depends on PC104 + select ISA_BUS_API select GPIOLIB_IRQCHIP help Enables GPIO support for the ACCES 104-IDIO-16 family (104-IDIO-16, @@ -611,7 +613,8 @@ config GPIO_104_IDIO_16 config GPIO_104_IDI_48 tristate "ACCES 104-IDI-48 GPIO support" - depends on PC104 && ISA_BUS_API + depends on PC104 + select ISA_BUS_API select GPIOLIB_IRQCHIP help Enables GPIO support for the ACCES 104-IDI-48 family (104-IDI-48A, @@ -631,7 +634,8 @@ config GPIO_F7188X config GPIO_GPIO_MM tristate "Diamond Systems GPIO-MM GPIO support" - depends on PC104 && ISA_BUS_API + depends on PC104 + select ISA_BUS_API help Enables GPIO support for the Diamond Systems GPIO-MM and GPIO-MM-12. @@ -700,7 +704,7 @@ config GPIO_TS5500 config GPIO_WS16C48 tristate "WinSystems WS16C48 GPIO support" - depends on ISA_BUS_API + select ISA_BUS_API select GPIOLIB_IRQCHIP help Enables GPIO support for the WinSystems WS16C48. The base port
The ISA_BUS_API Kconfig option enables the compilation of the ISA bus driver. The ISA bus driver does not perform any hardware interaction, and is instead just a thin layer of software abstraction to eliminate boilerplate code common to ISA-style device drivers. Since ISA_BUS_API has no dependencies and does not jeopardize the integrity of the system when enabled, drivers should select it when the ISA bus driver functionality is needed. Cc: Linus Walleij <linus.walleij@linaro.org> Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com> --- drivers/gpio/Kconfig | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-)