| Message ID | 20171207102003.23496-3-asolokha@kb.kras.ru |
|---|---|
| State | Accepted |
| Headers | show |
| Series | i2c: mpc: Clean up clock selection | expand |
On Thu, Dec 07, 2017 at 05:20:01PM +0700, Arseny Solokha wrote: > Commit 8ce795cb0c6b ("i2c: mpc: assign the correct prescaler from SVR") > introduced the common helper function for obtaining the actual clock > prescaler value for MPC85xx. However, getting the prescaler for MPC8544 > which depends on the SEC frequency ratio on this platform, has been always > performed separately based on the corresponding Device Tree configuration. > > Move special handling of MPC8544 into that common helper. Make it dependent > on the SoC version and not on Device Tree compatible node, as is the case > with all other SoCs. Handle MPC8533 the same way which is similar > to MPC8544 in this regard, according to AN2919 "Determining the I2C > Frequency Divider Ratio for SCL". > > Signed-off-by: Arseny Solokha <asolokha@kb.kras.ru> Looks good to me, but I have comments to patches 3+4.
On Thu, Dec 07, 2017 at 05:20:01PM +0700, Arseny Solokha wrote: > Commit 8ce795cb0c6b ("i2c: mpc: assign the correct prescaler from SVR") > introduced the common helper function for obtaining the actual clock > prescaler value for MPC85xx. However, getting the prescaler for MPC8544 > which depends on the SEC frequency ratio on this platform, has been always > performed separately based on the corresponding Device Tree configuration. > > Move special handling of MPC8544 into that common helper. Make it dependent > on the SoC version and not on Device Tree compatible node, as is the case > with all other SoCs. Handle MPC8533 the same way which is similar > to MPC8544 in this regard, according to AN2919 "Determining the I2C > Frequency Divider Ratio for SCL". > > Signed-off-by: Arseny Solokha <asolokha@kb.kras.ru> Applied to for-next, thanks!
diff --git a/drivers/i2c/busses/i2c-mpc.c b/drivers/i2c/busses/i2c-mpc.c index 6ad87555f71e..648a5afded64 100644 --- a/drivers/i2c/busses/i2c-mpc.c +++ b/drivers/i2c/busses/i2c-mpc.c @@ -350,7 +350,11 @@ static u32 mpc_i2c_get_sec_cfg_8xxx(void) static u32 mpc_i2c_get_prescaler_8xxx(void) { - /* mpc83xx and mpc82xx all have prescaler 1 */ + /* + * According to the AN2919 all MPC824x have prescaler 1, while MPC83xx + * may have prescaler 1, 2, or 3, depending on the power-on + * configuration. + */ u32 prescaler = 1; /* mpc85xx */ @@ -367,6 +371,10 @@ static u32 mpc_i2c_get_prescaler_8xxx(void) || (SVR_SOC_VER(svr) == SVR_8610)) /* the above 85xx SoCs have prescaler 1 */ prescaler = 1; + else if ((SVR_SOC_VER(svr) == SVR_8533) + || (SVR_SOC_VER(svr) == SVR_8544)) + /* the above 85xx SoCs have prescaler 3 or 2 */ + prescaler = mpc_i2c_get_sec_cfg_8xxx() ? 3 : 2; else /* all the other 85xx have prescaler 2 */ prescaler = 2; @@ -383,8 +391,6 @@ static int mpc_i2c_get_fdr_8xxx(struct device_node *node, u32 clock, int i; /* Determine proper divider value */ - if (of_device_is_compatible(node, "fsl,mpc8544-i2c")) - prescaler = mpc_i2c_get_sec_cfg_8xxx() ? 3 : 2; if (!prescaler) prescaler = mpc_i2c_get_prescaler_8xxx();
Commit 8ce795cb0c6b ("i2c: mpc: assign the correct prescaler from SVR") introduced the common helper function for obtaining the actual clock prescaler value for MPC85xx. However, getting the prescaler for MPC8544 which depends on the SEC frequency ratio on this platform, has been always performed separately based on the corresponding Device Tree configuration. Move special handling of MPC8544 into that common helper. Make it dependent on the SoC version and not on Device Tree compatible node, as is the case with all other SoCs. Handle MPC8533 the same way which is similar to MPC8544 in this regard, according to AN2919 "Determining the I2C Frequency Divider Ratio for SCL". Signed-off-by: Arseny Solokha <asolokha@kb.kras.ru> --- drivers/i2c/busses/i2c-mpc.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-)