| Message ID | 20171226023646.17722-2-jeffy.chen@rock-chips.com |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | PCI: rockchip: Move PCIe WAKE# handling into pci core | expand |
On Tue, Dec 26, 2017 at 10:36:42AM +0800, Jeffy Chen wrote: > We are going to handle PCIe WAKE# pin for PCI devices in the pci core, > so add definitions of the optional PCIe WAKE# pin for PCI devices. > > Also add an definition of the optional PCI interrupt pin for PCI > devices to distinguish it from the PCIe WAKE# pin. By v13 you should drop "RFC". RFC implies not ready for merging. > > Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com> > --- > > Changes in v13: None > Changes in v12: > Only add irq definitions for PCI devices and rewrite the commit message. > > Changes in v11: None > Changes in v10: None > Changes in v9: > Add section for PCI devices and rewrite the commit message. > > Changes in v8: > Add optional "pci", and rewrite commit message. > > Changes in v7: None > Changes in v6: None > Changes in v5: > Move to pci.txt > > Changes in v3: None > Changes in v2: None > > Documentation/devicetree/bindings/pci/pci.txt | 10 ++++++++++ > 1 file changed, 10 insertions(+) Reviewed-by: Rob Herring <robh@kernel.org>
On Wednesday, December 27, 2017 12:35:52 AM CET Rob Herring wrote: > On Tue, Dec 26, 2017 at 10:36:42AM +0800, Jeffy Chen wrote: > > We are going to handle PCIe WAKE# pin for PCI devices in the pci core, > > so add definitions of the optional PCIe WAKE# pin for PCI devices. > > > > Also add an definition of the optional PCI interrupt pin for PCI > > devices to distinguish it from the PCIe WAKE# pin. > > By v13 you should drop "RFC". RFC implies not ready for merging. Which very much still is the case AFAICS. Thanks, Rafael
Hi Rafael and Rob, Thanks for your reply. On 12/27/2017 08:43 AM, Rafael J. Wysocki wrote: > On Wednesday, December 27, 2017 12:35:52 AM CET Rob Herring wrote: >> >On Tue, Dec 26, 2017 at 10:36:42AM +0800, Jeffy Chen wrote: >>> > >We are going to handle PCIe WAKE# pin for PCI devices in the pci core, >>> > >so add definitions of the optional PCIe WAKE# pin for PCI devices. >>> > > >>> > >Also add an definition of the optional PCI interrupt pin for PCI >>> > >devices to distinguish it from the PCIe WAKE# pin. >> > >> >By v13 you should drop "RFC". RFC implies not ready for merging. > Which very much still is the case AFAICS. > maybe i should split this series, and send dt-binding patch and the pci irq parsing patch along without RFC ? > Thanks, > Rafael > > > >
diff --git a/Documentation/devicetree/bindings/pci/pci.txt b/Documentation/devicetree/bindings/pci/pci.txt index c77981c5dd18..3045ac452f27 100644 --- a/Documentation/devicetree/bindings/pci/pci.txt +++ b/Documentation/devicetree/bindings/pci/pci.txt @@ -24,3 +24,13 @@ driver implementation may support the following properties: unsupported link speed, for instance, trying to do training for unsupported link speed, etc. Must be '4' for gen4, '3' for gen3, '2' for gen2, and '1' for gen1. Any other values are invalid. + +PCI devices may support the following properties: + +- interrupts: Interrupt specifier for each name in interrupt-names. +- interrupt-names: + May contain "wakeup" for PCIe WAKE# interrupt and "pci" for PCI interrupt. + The PCI devices may optionally include an 'interrupts' property that + represents the legacy PCI interrupt. And when we try to specify the PCIe + WAKE# pin, a corresponding 'interrupt-names' property is required to + distinguish them.
We are going to handle PCIe WAKE# pin for PCI devices in the pci core, so add definitions of the optional PCIe WAKE# pin for PCI devices. Also add an definition of the optional PCI interrupt pin for PCI devices to distinguish it from the PCIe WAKE# pin. Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com> --- Changes in v13: None Changes in v12: Only add irq definitions for PCI devices and rewrite the commit message. Changes in v11: None Changes in v10: None Changes in v9: Add section for PCI devices and rewrite the commit message. Changes in v8: Add optional "pci", and rewrite commit message. Changes in v7: None Changes in v6: None Changes in v5: Move to pci.txt Changes in v3: None Changes in v2: None Documentation/devicetree/bindings/pci/pci.txt | 10 ++++++++++ 1 file changed, 10 insertions(+)