diff mbox series

[v2] prd: Log unsupported message type

Message ID 20171130051133.31811-1-hegdevasant@linux.vnet.ibm.com
State Accepted
Headers show
Series [v2] prd: Log unsupported message type | expand

Commit Message

Vasant Hegde Nov. 30, 2017, 5:11 a.m. UTC
Useful for debugging.

Sample output:
  [29155.157050283,7] PRD: Unsupported prd message type : 0xc

CC: Jeremy Kerr <jk@ozlabs.org>
Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com>
---
 hw/prd.c | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Jeremy Kerr Dec. 15, 2017, 5:43 a.m. UTC | #1
Hi Vasant,

> Useful for debugging.
> 
> Sample output:
>   [29155.157050283,7] PRD: Unsupported prd message type : 0xc

Looks good to me.

Acked-by: Jeremy Kerr <jk@ozlabs.org>

Cheers,


Jeremy
Stewart Smith Dec. 19, 2017, 12:27 a.m. UTC | #2
Vasant Hegde <hegdevasant@linux.vnet.ibm.com> writes:
> Useful for debugging.
>
> Sample output:
>   [29155.157050283,7] PRD: Unsupported prd message type : 0xc
>
> CC: Jeremy Kerr <jk@ozlabs.org>
> Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com>
> ---
>  hw/prd.c | 4 ++++
>  1 file changed, 4 insertions(+)

Thanks, merged to master as of 0f9a776aa72f75b1983c9d6cd4dd8bf7bef0883a
diff mbox series

Patch

diff --git a/hw/prd.c b/hw/prd.c
index 4db92eb..8ce3af2 100644
--- a/hw/prd.c
+++ b/hw/prd.c
@@ -389,6 +389,8 @@  static int prd_msg_handle_firmware_req(struct opal_prd_msg *msg)
 		rc = 0;
 		break;
 	default:
+		prlog(PR_DEBUG, "PRD: Unsupported fw_request type : 0x%llx\n",
+		      be64_to_cpu(fw_req->type));
 		rc = -ENOSYS;
 	}
 
@@ -432,6 +434,8 @@  static int64_t opal_prd_msg(struct opal_prd_msg *msg)
 		rc = prd_msg_handle_firmware_req(msg);
 		break;
 	default:
+		prlog(PR_DEBUG, "PRD: Unsupported prd message type : 0x%x\n",
+		      msg->hdr.type);
 		rc = OPAL_UNSUPPORTED;
 	}