| Message ID | 20171212005113.909-1-famz@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v4] qemu-img: Document --force-share / -U | expand |
On Tue, Dec 12, 2017 at 08:51:13AM +0800, Fam Zheng wrote: > Signed-off-by: Fam Zheng <famz@redhat.com> > > --- > > v4: "images". [Kevin] > > v3: Document that the option is not allowed for read-write. [Stefan] > > v2: - "code{qemu-img}". [Kashyap, Eric] > - "etc.." -> "etc.". > --- > qemu-img.texi | 9 +++++++++ > 1 file changed, 9 insertions(+) Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
On Tue, Dec 12, 2017 at 08:51:13AM +0800, Fam Zheng wrote: > Signed-off-by: Fam Zheng <famz@redhat.com> [...] > qemu-img.texi | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/qemu-img.texi b/qemu-img.texi > index fdcf120f36..d93501f94f 100644 > --- a/qemu-img.texi > +++ b/qemu-img.texi > @@ -57,6 +57,15 @@ exclusive with the @var{-O} parameters. It is currently required to also use > the @var{-n} parameter to skip image creation. This restriction may be relaxed > in a future release. > > +@item --force-share (-U) > + > +If specified, @code{qemu-img} will open the image with shared permissions, > +which makes it less likely to conflict with a running guest's permissions due > +to image locking. For example, this can be used to get the image information > +(with 'info' subcommand) when the image is used by a running guest. Note that > +this could produce inconsistent result because of concurrent metadata changes, > +etc. This option is only allowed when opening images in read-only mode. > + Reviewed-by: Kashyap Chamarthy <kchamart@redhat.com>
Am 12.12.2017 um 01:51 hat Fam Zheng geschrieben: > Signed-off-by: Fam Zheng <famz@redhat.com> > > --- > > v4: "images". [Kevin] > > v3: Document that the option is not allowed for read-write. [Stefan] > > v2: - "code{qemu-img}". [Kashyap, Eric] > - "etc.." -> "etc.". > --- > qemu-img.texi | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/qemu-img.texi b/qemu-img.texi > index fdcf120f36..d93501f94f 100644 > --- a/qemu-img.texi > +++ b/qemu-img.texi > @@ -57,6 +57,15 @@ exclusive with the @var{-O} parameters. It is currently required to also use > the @var{-n} parameter to skip image creation. This restriction may be relaxed > in a future release. > > +@item --force-share (-U) > + > +If specified, @code{qemu-img} will open the image with shared permissions, > +which makes it less likely to conflict with a running guest's permissions due > +to image locking. For example, this can be used to get the image information > +(with 'info' subcommand) when the image is used by a running guest. Note that > +this could produce inconsistent result because of concurrent metadata changes, Each time you read a text, you find something new... s/result/results/ > +etc. This option is only allowed when opening images in read-only mode. > + Thanks, fixed the above and applied the patch to block-next. Kevin
diff --git a/qemu-img.texi b/qemu-img.texi index fdcf120f36..d93501f94f 100644 --- a/qemu-img.texi +++ b/qemu-img.texi @@ -57,6 +57,15 @@ exclusive with the @var{-O} parameters. It is currently required to also use the @var{-n} parameter to skip image creation. This restriction may be relaxed in a future release. +@item --force-share (-U) + +If specified, @code{qemu-img} will open the image with shared permissions, +which makes it less likely to conflict with a running guest's permissions due +to image locking. For example, this can be used to get the image information +(with 'info' subcommand) when the image is used by a running guest. Note that +this could produce inconsistent result because of concurrent metadata changes, +etc. This option is only allowed when opening images in read-only mode. + @item fmt is the disk image format. It is guessed automatically in most cases. See below for a description of the supported disk formats.
Signed-off-by: Fam Zheng <famz@redhat.com> --- v4: "images". [Kevin] v3: Document that the option is not allowed for read-write. [Stefan] v2: - "code{qemu-img}". [Kashyap, Eric] - "etc.." -> "etc.". --- qemu-img.texi | 9 +++++++++ 1 file changed, 9 insertions(+)