| Message ID | 1512627563-94018-1-git-send-email-jpettit@ovn.org |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [ovs-dev] dpctl: Fix comment describing get_one_dp(). | expand |
On Wed, Dec 06, 2017 at 10:19:23PM -0800, Justin Pettit wrote: > Signed-off-by: Justin Pettit <jpettit@ovn.org> > --- > lib/dpctl.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/lib/dpctl.c b/lib/dpctl.c > index 06cfbc4abf21..5e064ec9c100 100644 > --- a/lib/dpctl.c > +++ b/lib/dpctl.c > @@ -129,8 +129,8 @@ if_up(struct netdev *netdev) > } > > /* Retrieve the name of the datapath if exactly one exists. The caller > - * is responsible for freeing the returned string. If there is not one > - * datapath, aborts with an error message. */ > + * is responsible for freeing the returned string. If a single datapath > + * name cannot be determined, returns NULL. */ > static char * > get_one_dp(struct dpctl_params *dpctl_p) Acked-by: Ben Pfaff <blp@ovn.org>
> On Dec 7, 2017, at 8:21 AM, Ben Pfaff <blp@ovn.org> wrote: > >> On Wed, Dec 06, 2017 at 10:19:23PM -0800, Justin Pettit wrote: >> Signed-off-by: Justin Pettit <jpettit@ovn.org> >> --- >> lib/dpctl.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/lib/dpctl.c b/lib/dpctl.c >> index 06cfbc4abf21..5e064ec9c100 100644 >> --- a/lib/dpctl.c >> +++ b/lib/dpctl.c >> @@ -129,8 +129,8 @@ if_up(struct netdev *netdev) >> } >> >> /* Retrieve the name of the datapath if exactly one exists. The caller >> - * is responsible for freeing the returned string. If there is not one >> - * datapath, aborts with an error message. */ >> + * is responsible for freeing the returned string. If a single datapath >> + * name cannot be determined, returns NULL. */ >> static char * >> get_one_dp(struct dpctl_params *dpctl_p) > > Acked-by: Ben Pfaff <blp@ovn.org> Thanks. I pushed this to master. —Justin
diff --git a/lib/dpctl.c b/lib/dpctl.c index 06cfbc4abf21..5e064ec9c100 100644 --- a/lib/dpctl.c +++ b/lib/dpctl.c @@ -129,8 +129,8 @@ if_up(struct netdev *netdev) } /* Retrieve the name of the datapath if exactly one exists. The caller - * is responsible for freeing the returned string. If there is not one - * datapath, aborts with an error message. */ + * is responsible for freeing the returned string. If a single datapath + * name cannot be determined, returns NULL. */ static char * get_one_dp(struct dpctl_params *dpctl_p) {
Signed-off-by: Justin Pettit <jpettit@ovn.org> --- lib/dpctl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)