Message ID | 1512153879-5291-4-git-send-email-peter.maydell@linaro.org |
---|---|
State | New |
Headers | show |
Series | armv8m: Implement TT, and other bugfixes | expand |
On 12/01/2017 10:44 AM, Peter Maydell wrote: > When we added the ARMMMUIdx_MSUser MMU index we forgot to > add it to the case statement in regime_is_user(), so we > weren't treating it as unprivileged when doing MPU lookups. > Correct the omission. > > Signed-off-by: Peter Maydell <peter.maydell@linaro.org> > --- > target/arm/helper.c | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~
On 12/01/2017 03:44 PM, Peter Maydell wrote: > When we added the ARMMMUIdx_MSUser MMU index we forgot to > add it to the case statement in regime_is_user(), so we > weren't treating it as unprivileged when doing MPU lookups. > Correct the omission. Eh commit e7b921c2d9e wasn't reviewed! > Signed-off-by: Peter Maydell <peter.maydell@linaro.org> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > --- > target/arm/helper.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/target/arm/helper.c b/target/arm/helper.c > index f21c142..c4c8d5a 100644 > --- a/target/arm/helper.c > +++ b/target/arm/helper.c > @@ -8016,6 +8016,7 @@ static inline bool regime_is_user(CPUARMState *env, ARMMMUIdx mmu_idx) > case ARMMMUIdx_S1SE0: > case ARMMMUIdx_S1NSE0: > case ARMMMUIdx_MUser: > + case ARMMMUIdx_MSUser: > return true; > default: > return false; >
diff --git a/target/arm/helper.c b/target/arm/helper.c index f21c142..c4c8d5a 100644 --- a/target/arm/helper.c +++ b/target/arm/helper.c @@ -8016,6 +8016,7 @@ static inline bool regime_is_user(CPUARMState *env, ARMMMUIdx mmu_idx) case ARMMMUIdx_S1SE0: case ARMMMUIdx_S1NSE0: case ARMMMUIdx_MUser: + case ARMMMUIdx_MSUser: return true; default: return false;
When we added the ARMMMUIdx_MSUser MMU index we forgot to add it to the case statement in regime_is_user(), so we weren't treating it as unprivileged when doing MPU lookups. Correct the omission. Signed-off-by: Peter Maydell <peter.maydell@linaro.org> --- target/arm/helper.c | 1 + 1 file changed, 1 insertion(+)