diff mbox

hw/occ: Log proper SCOM register names

Message ID 1491284396-14381-1-git-send-email-ppaidipe@linux.vnet.ibm.com
State Accepted
Headers show

Commit Message

ppaidipe April 4, 2017, 5:39 a.m. UTC 
This patch fixes the logging of incorrect SCOM
register names.

Signed-off-by: Pridhiviraj Paidipeddi <ppaidipe@linux.vnet.ibm.com>
---
 hw/occ.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Stewart Smith Dec. 1, 2017, 6:45 a.m. UTC | #1 
Pridhiviraj Paidipeddi <ppaidipe@linux.vnet.ibm.com> writes:
> This patch fixes the logging of incorrect SCOM
> register names.
>
> Signed-off-by: Pridhiviraj Paidipeddi <ppaidipe@linux.vnet.ibm.com>
> ---
>  hw/occ.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

Thanks, looks good for improved debug. Merged to master as of
40b55be1035b4cdc11bba19088390aefb937a6db
diff mbox

Patch

diff --git a/hw/occ.c b/hw/occ.c
index ee76be6..7ea1922 100644
--- a/hw/occ.c
+++ b/hw/occ.c
@@ -399,7 +399,7 @@  static bool cpu_pstates_prepare_core(struct proc_chip *chip, struct cpu_thread *
 	rc = xscom_read(chip->id, XSCOM_ADDR_P8_EX_SLAVE(core, EX_PM_PPMCR), &tmp);
 	if (rc) {
 		log_simple_error(&e_info(OPAL_RC_OCC_PSTATE_INIT),
-			"OCC: Failed to read from OCC in pstates init\n");
+			"OCC: Failed to read PM_PPMCR from OCC in pstates init\n");
 		return false;
 	}
 	tmp = tmp & ~0xFFFF000000000000ULL;
@@ -408,7 +408,7 @@  static bool cpu_pstates_prepare_core(struct proc_chip *chip, struct cpu_thread *
 	rc = xscom_write(chip->id, XSCOM_ADDR_P8_EX_SLAVE(core, EX_PM_PPMCR), tmp);
 	if (rc) {
 		log_simple_error(&e_info(OPAL_RC_OCC_PSTATE_INIT),
-			"OCC: Failed to write PM_GP1 in pstates init\n");
+			"OCC: Failed to write PM_PPMCR in pstates init\n");
 		return false;
 	}
 	time_wait_ms(1); /* Wait for PState to change */
@@ -435,7 +435,7 @@  static bool cpu_pstates_prepare_core(struct proc_chip *chip, struct cpu_thread *
 	rc = xscom_read(chip->id, XSCOM_ADDR_P8_EX_SLAVE(core, EX_PM_PPMSR), &tmp);
 	if (rc) {
 		log_simple_error(&e_info(OPAL_RC_OCC_PSTATE_INIT),
-			"OCC: Failed to read back setting from OCC"
+			"OCC: Failed to read PM_PPMSR from OCC"
 				 "in pstates init\n");
 		return false;
 	}