diff mbox series

[RESEND] tests: enable dynamic debugging for mac80211_hwsim

Message ID 20171016073247.11810-1-lkundrak@v3.sk
State Accepted
Headers show
Series [RESEND] tests: enable dynamic debugging for mac80211_hwsim | expand

Commit Message

Lubomir Rintel Oct. 16, 2017, 7:32 a.m. UTC 
mac80211_hwsim module typically dumps a lot of details into the kernel
message buffer. While it's probably okay in a dedicated VM, it's way too
chatty in other setups.

Kernel allows fine-tuning logging via the dynamic debugging facility.
Let's enable all logging locations in the mac80211_hwsim module so that we
don't loose debugging output when kenel adpots the dynamic debug mechanism for
the driver.

Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>

---
The relevant kernel patch reference:
https://patchwork.kernel.org/patch/9814285/
---
 tests/hwsim/start.sh         | 2 +-
 tests/hwsim/vm/kernel-config | 2 +-
 tests/hwsim/vm/vm-run.sh     | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

Comments

Jouni Malinen Nov. 26, 2017, 12:20 p.m. UTC | #1 
On Mon, Oct 16, 2017 at 09:32:47AM +0200, Lubomir Rintel wrote:
> mac80211_hwsim module typically dumps a lot of details into the kernel
> message buffer. While it's probably okay in a dedicated VM, it's way too
> chatty in other setups.
> 
> Kernel allows fine-tuning logging via the dynamic debugging facility.
> Let's enable all logging locations in the mac80211_hwsim module so that we
> don't loose debugging output when kenel adpots the dynamic debug mechanism for
> the driver.

Thanks, applied.
diff mbox series

Patch

diff --git a/tests/hwsim/start.sh b/tests/hwsim/start.sh
index dce65ba82..45f1b95e8 100755
--- a/tests/hwsim/start.sh
+++ b/tests/hwsim/start.sh
@@ -101,7 +101,7 @@  else
 	NUM_CH=1
 fi
 
-test -f /proc/modules && sudo modprobe mac80211_hwsim radios=7 channels=$NUM_CH support_p2p_device=0
+test -f /proc/modules && sudo modprobe mac80211_hwsim radios=7 channels=$NUM_CH support_p2p_device=0 dyndbg=+p
 
 sudo ifconfig hwsim0 up
 sudo $WLANTEST -i hwsim0 -n $LOGDIR/hwsim0.pcapng -c -dtN -L $LOGDIR/hwsim0 &
diff --git a/tests/hwsim/vm/kernel-config b/tests/hwsim/vm/kernel-config
index 3c8cd2fc0..e41d69823 100644
--- a/tests/hwsim/vm/kernel-config
+++ b/tests/hwsim/vm/kernel-config
@@ -1844,7 +1844,7 @@  CONFIG_PRINTK_TIME=y
 CONFIG_CONSOLE_LOGLEVEL_DEFAULT=7
 CONFIG_MESSAGE_LOGLEVEL_DEFAULT=4
 # CONFIG_BOOT_PRINTK_DELAY is not set
-# CONFIG_DYNAMIC_DEBUG is not set
+CONFIG_DYNAMIC_DEBUG=y
 
 #
 # Compile-time checks and compiler options
diff --git a/tests/hwsim/vm/vm-run.sh b/tests/hwsim/vm/vm-run.sh
index c0ef5b0fe..3d4d36cfd 100755
--- a/tests/hwsim/vm/vm-run.sh
+++ b/tests/hwsim/vm/vm-run.sh
@@ -132,7 +132,7 @@  $KVM \
 	-fsdev local,security_model=none,id=fsdev-logs,path="$LOGDIR",writeout=immediate \
 	-device virtio-9p-pci,id=fs-logs,fsdev=fsdev-logs,mount_tag=logshare \
 	-monitor null -serial stdio -serial file:$LOGDIR/console \
-	-append "mac80211_hwsim.support_p2p_device=0 mac80211_hwsim.channels=$CHANNELS mac80211_hwsim.radios=7 init=$CMD testdir=$TESTDIR timewarp=$TIMEWARP console=$KVMOUT root=/dev/root rootflags=trans=virtio,version=9p2000.u ro rootfstype=9p EPATH=$EPATH ARGS=$argsfile"
+	-append "mac80211_hwsim.support_p2p_device=0 mac80211_hwsim.channels=$CHANNELS mac80211_hwsim.radios=7 mac80211_hwsim.dyndbg=+p init=$CMD testdir=$TESTDIR timewarp=$TIMEWARP console=$KVMOUT root=/dev/root rootflags=trans=virtio,version=9p2000.u ro rootfstype=9p EPATH=$EPATH ARGS=$argsfile"
 
 if [ $CODECOV = "yes" ]; then
     echo "Preparing code coverage reports"