| Message ID | 1510656704-11153-1-git-send-email-angelo@amarulasolutions.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [1/2] package/i2c-tools: bump to version 4.0 | expand |
Hello, On Tue, 14 Nov 2017 11:51:43 +0100, Angelo Compagnucci wrote: > This patch bumps i2c-tools to version 4.0 and adds a new command > named i2ctransfer. > > Signed-off-by: Angelo Compagnucci <angelo@amarulasolutions.com> This patch breaks the build on Cortex-M4 ARM noMMU configuration: /home/thomas/projets/buildroot/output/host/bin/arm-linux-gcc -shared -Wl,-elf2flt -static -Wl,--version-script=lib/libi2c.map -Wl,-soname,libi2c.so.0 -o lib/libi2c.so.0.1.0 lib/smbus.o -lc ld (ld-elf2flt): -shared used without passing a shared library ID It is trying to unconditionally build a shared library, even when there is no support for shared libraries. You can reproduce using the following defconfig: BR2_arm=y BR2_cortex_m4=y BR2_TOOLCHAIN_EXTERNAL=y BR2_TOOLCHAIN_EXTERNAL_DOWNLOAD=y BR2_TOOLCHAIN_EXTERNAL_URL="http://autobuild.buildroot.org/toolchains/tarballs/br-arm-cortex-m4-full-2017.11-rc1.tar.bz2" BR2_TOOLCHAIN_EXTERNAL_GCC_6=y BR2_TOOLCHAIN_EXTERNAL_HEADERS_4_13=y BR2_TOOLCHAIN_EXTERNAL_LOCALE=y # BR2_TOOLCHAIN_EXTERNAL_HAS_THREADS_DEBUG is not set # BR2_TOOLCHAIN_EXTERNAL_HAS_THREADS_NPTL is not set BR2_TOOLCHAIN_EXTERNAL_CXX=y BR2_INIT_NONE=y # BR2_PACKAGE_BUSYBOX is not set BR2_PACKAGE_I2C_TOOLS=y # BR2_TARGET_ROOTFS_TAR is not set Could you look into this, and submit an updated version? It would be preferably to support building without shared library support, because i2c-tools are very basic, and potentially useful on noMMU systems. Thanks! Thomas
diff --git a/package/i2c-tools/i2c-tools.hash b/package/i2c-tools/i2c-tools.hash index 464219d..3475d20 100644 --- a/package/i2c-tools/i2c-tools.hash +++ b/package/i2c-tools/i2c-tools.hash @@ -1,5 +1,5 @@ # Locally computed -sha256 6d6079153cd49a62d4addacef4c092db1a46ba60b2807070a3fbe050262aef87 i2c-tools-3.1.2.tar.xz +sha256 d900ca1c11c51ea20caa50b096f948008b8a7ad832311b23353e21baa7af28d6 i2c-tools-4.0.tar.xz # License file sha256 ab15fd526bd8dd18a9e77ebc139656bf4d33e97fc7238cd11bf60e2b9b8666c6 COPYING diff --git a/package/i2c-tools/i2c-tools.mk b/package/i2c-tools/i2c-tools.mk index 3bbaf38..2bbb12f 100644 --- a/package/i2c-tools/i2c-tools.mk +++ b/package/i2c-tools/i2c-tools.mk @@ -4,7 +4,7 @@ # ################################################################################ -I2C_TOOLS_VERSION = 3.1.2 +I2C_TOOLS_VERSION = 4.0 I2C_TOOLS_SOURCE = i2c-tools-$(I2C_TOOLS_VERSION).tar.xz I2C_TOOLS_SITE = https://www.kernel.org/pub/software/utils/i2c-tools I2C_TOOLS_LICENSE = GPL-2.0+, GPL-2.0 (py-smbus) @@ -52,7 +52,7 @@ define I2C_TOOLS_BUILD_CMDS endef define I2C_TOOLS_INSTALL_TARGET_CMDS - for i in i2cdump i2cget i2cset i2cdetect; \ + for i in i2cdump i2cget i2cset i2cdetect i2ctransfer; \ do \ $(INSTALL) -m 755 -D $(@D)/tools/$$i $(TARGET_DIR)/usr/sbin/$$i; \ done
This patch bumps i2c-tools to version 4.0 and adds a new command named i2ctransfer. Signed-off-by: Angelo Compagnucci <angelo@amarulasolutions.com> --- package/i2c-tools/i2c-tools.hash | 2 +- package/i2c-tools/i2c-tools.mk | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-)