diff mbox series

[2/2] qemu-options: Mention locking option of file driver

Message ID 20171123135906.12852-3-famz@redhat.com
State New
Headers show
Series docs: Add documentation for image locking | expand

Commit Message

Fam Zheng Nov. 23, 2017, 1:59 p.m. UTC 
Signed-off-by: Fam Zheng <famz@redhat.com>
---
 qemu-options.hx | 3 +++
 1 file changed, 3 insertions(+)

Comments

Kevin Wolf Nov. 23, 2017, 5:03 p.m. UTC | #1 
Am 23.11.2017 um 14:59 hat Fam Zheng geschrieben:
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
>  qemu-options.hx | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/qemu-options.hx b/qemu-options.hx
> index 3728e9b4dd..bcb7a88ec3 100644
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -693,6 +693,9 @@ This is the protocol-level block driver for accessing regular files.
>  The path to the image file in the local filesystem
>  @item aio
>  Specifies the AIO backend (threads/native, default: threads)
> +@item locking
> +Specifies whether the image file is protected with Linux OFD / POSIX locks.
> +(auto/on/off, default: auto)

Maybe "should be protected" would be better than "is protected"?

Do we want to explain what "auto" means?

Kevin
Fam Zheng Nov. 24, 2017, 8:44 a.m. UTC | #2 
On Thu, 11/23 18:03, Kevin Wolf wrote:
> Am 23.11.2017 um 14:59 hat Fam Zheng geschrieben:
> > Signed-off-by: Fam Zheng <famz@redhat.com>
> > ---
> >  qemu-options.hx | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/qemu-options.hx b/qemu-options.hx
> > index 3728e9b4dd..bcb7a88ec3 100644
> > --- a/qemu-options.hx
> > +++ b/qemu-options.hx
> > @@ -693,6 +693,9 @@ This is the protocol-level block driver for accessing regular files.
> >  The path to the image file in the local filesystem
> >  @item aio
> >  Specifies the AIO backend (threads/native, default: threads)
> > +@item locking
> > +Specifies whether the image file is protected with Linux OFD / POSIX locks.
> > +(auto/on/off, default: auto)
> 
> Maybe "should be protected" would be better than "is protected"?

Yes.

> 
> Do we want to explain what "auto" means?

Will add that.

Fam
diff mbox series

Patch

diff --git a/qemu-options.hx b/qemu-options.hx
index 3728e9b4dd..bcb7a88ec3 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -693,6 +693,9 @@  This is the protocol-level block driver for accessing regular files.
 The path to the image file in the local filesystem
 @item aio
 Specifies the AIO backend (threads/native, default: threads)
+@item locking
+Specifies whether the image file is protected with Linux OFD / POSIX locks.
+(auto/on/off, default: auto)
 @end table
 Example:
 @example