| Message ID | AM5PR0701MB29613C53A2B6FB586D570A90A4570@AM5PR0701MB2961.eurprd07.prod.outlook.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [ovs-dev] odp-execute: Bug Fix - missing break statement for CLONE action | expand |
Hi, Do any one sees issues with this patch ? If let loose, it may create issues once we have implementation of METER. Warm Regards, Vishal From: Vishal Deep Ajmera Sent: Thursday, November 09, 2017 3:45 PM To: dev@openvswitch.org Subject: [PATCH] odp-execute: Bug Fix - missing break statement for CLONE action Adding the break statement for CLONE action case. Signed-off-by: Vishal Deep Ajmera <vishal.deep.ajmera@ericsson.com<mailto:vishal.deep.ajmera@ericsson.com>> --- lib/odp-execute.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/odp-execute.c b/lib/odp-execute.c index 3011479..2d20cd5 100644 --- a/lib/odp-execute.c +++ b/lib/odp-execute.c @@ -800,6 +800,7 @@ odp_execute_actions(void *dp, struct dp_packet_batch *batch, bool steal, * stolen them. */ return; } + break; case OVS_ACTION_ATTR_METER: /* Not implemented yet. */ break;
On Thu, Nov 09, 2017 at 10:15:31AM +0000, Vishal Deep Ajmera wrote: > Adding the break statement for CLONE action case. > > Signed-off-by: Vishal Deep Ajmera <vishal.deep.ajmera@ericsson.com> Thanks, applied to master. I adjusted the commit message to reflect that it doesn't fix an existing bug, only makes future bugs less likely.
diff --git a/lib/odp-execute.c b/lib/odp-execute.c index 3011479..2d20cd5 100644 --- a/lib/odp-execute.c +++ b/lib/odp-execute.c @@ -800,6 +800,7 @@ odp_execute_actions(void *dp, struct dp_packet_batch *batch, bool steal, * stolen them. */ return; } + break; case OVS_ACTION_ATTR_METER: /* Not implemented yet. */ break;
Adding the break statement for CLONE action case. Signed-off-by: Vishal Deep Ajmera <vishal.deep.ajmera@ericsson.com> --- lib/odp-execute.c | 1 + 1 file changed, 1 insertion(+)