| Message ID | 20171109091444.dxvoaaafjgkf43a2@lenoch |
|---|---|
| State | Superseded |
| Delegated to: | Boris Brezillon |
| Headers | show |
| Series | OMAP2+ OneNAND driver update | expand |
On 09/11/17 11:14, Ladislav Michl wrote: > No platform data user setups partitioning informations, so remove. > > Signed-off-by: Ladislav Michl <ladis@linux-mips.org> > --- > Changes: > -v2: new patch > -v3: none > > drivers/mtd/onenand/omap2.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/mtd/onenand/omap2.c b/drivers/mtd/onenand/omap2.c > index 93bd94337b35..883993bbe40b 100644 > --- a/drivers/mtd/onenand/omap2.c > +++ b/drivers/mtd/onenand/omap2.c > @@ -703,8 +703,7 @@ static int omap2_onenand_probe(struct platform_device *pdev) > if ((r = onenand_scan(&c->mtd, 1)) < 0) > goto err_release_dma; > > - r = mtd_device_register(&c->mtd, pdata ? pdata->parts : NULL, > - pdata ? pdata->nr_parts : 0); > + r = mtd_device_register(&c->mtd, NULL, 0); > if (r) > goto err_release_onenand; > > Same here. Need to update platform data structure.
On Fri, Nov 10, 2017 at 10:19:11AM +0200, Roger Quadros wrote: > On 09/11/17 11:14, Ladislav Michl wrote: > > No platform data user setups partitioning informations, so remove. > > > > Signed-off-by: Ladislav Michl <ladis@linux-mips.org> > > --- > > Changes: > > -v2: new patch > > -v3: none > > > > drivers/mtd/onenand/omap2.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/drivers/mtd/onenand/omap2.c b/drivers/mtd/onenand/omap2.c > > index 93bd94337b35..883993bbe40b 100644 > > --- a/drivers/mtd/onenand/omap2.c > > +++ b/drivers/mtd/onenand/omap2.c > > @@ -703,8 +703,7 @@ static int omap2_onenand_probe(struct platform_device *pdev) > > if ((r = onenand_scan(&c->mtd, 1)) < 0) > > goto err_release_dma; > > > > - r = mtd_device_register(&c->mtd, pdata ? pdata->parts : NULL, > > - pdata ? pdata->nr_parts : 0); > > + r = mtd_device_register(&c->mtd, NULL, 0); > > if (r) > > goto err_release_onenand; > > > > > > Same here. Need to update platform data structure. I do not want to unnecessarily extend patch as I hope no sane maintainer would ever allow anyone to add any new platform data dependency while we are moving towards DT only configured kernel. Platform data structure will be deleted entirely together with arch/arm/mach-omap2/gpmc-onenand.c once driver update gets accepted. ladis
diff --git a/drivers/mtd/onenand/omap2.c b/drivers/mtd/onenand/omap2.c index 93bd94337b35..883993bbe40b 100644 --- a/drivers/mtd/onenand/omap2.c +++ b/drivers/mtd/onenand/omap2.c @@ -703,8 +703,7 @@ static int omap2_onenand_probe(struct platform_device *pdev) if ((r = onenand_scan(&c->mtd, 1)) < 0) goto err_release_dma; - r = mtd_device_register(&c->mtd, pdata ? pdata->parts : NULL, - pdata ? pdata->nr_parts : 0); + r = mtd_device_register(&c->mtd, NULL, 0); if (r) goto err_release_onenand;
No platform data user setups partitioning informations, so remove. Signed-off-by: Ladislav Michl <ladis@linux-mips.org> --- Changes: -v2: new patch -v3: none drivers/mtd/onenand/omap2.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)