Message ID | 20171105130429.6399-1-colin.king@canonical.com |
---|---|
State | Accepted |
Delegated to: | Jeff Kirsher |
Headers | show |
Series | i40e: remove redundant initialization of read_size | expand |
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces@osuosl.org] On Behalf > Of Colin King > Sent: Sunday, November 5, 2017 5:04 AM > To: Kirsher, Jeffrey T <jeffrey.t.kirsher@intel.com>; intel-wired- > lan@lists.osuosl.org; netdev@vger.kernel.org > Cc: kernel-janitors@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: [Intel-wired-lan] [PATCH] i40e: remove redundant initialization of > read_size > > From: Colin Ian King <colin.king@canonical.com> > > Variable read_size is initialized and this value is never read, it is > instead set inside the do-loop, hence the intialization is redundant > and can be removed. Cleans up clang warning: > > drivers/net/ethernet/intel/i40e/i40e_nvm.c:390:6: warning: Value stored > to 'read_size' during its initialization is never read > > Signed-off-by: Colin Ian King <colin.king@canonical.com> s/intialization/initialization/g
> From: Brown, Aaron F > Sent: Thursday, November 9, 2017 7:16 PM > To: 'Colin King' <colin.king@canonical.com>; Kirsher, Jeffrey T > <jeffrey.t.kirsher@intel.com>; intel-wired-lan@lists.osuosl.org; > netdev@vger.kernel.org > Cc: kernel-janitors@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: RE: [Intel-wired-lan] [PATCH] i40e: remove redundant initialization > of read_size > > > From: Intel-wired-lan [mailto:intel-wired-lan-bounces@osuosl.org] On > Behalf > > Of Colin King > > Sent: Sunday, November 5, 2017 5:04 AM > > To: Kirsher, Jeffrey T <jeffrey.t.kirsher@intel.com>; intel-wired- > > lan@lists.osuosl.org; netdev@vger.kernel.org > > Cc: kernel-janitors@vger.kernel.org; linux-kernel@vger.kernel.org > > Subject: [Intel-wired-lan] [PATCH] i40e: remove redundant initialization of > > read_size > > > > From: Colin Ian King <colin.king@canonical.com> > > > > Variable read_size is initialized and this value is never read, it is > > instead set inside the do-loop, hence the intialization is redundant > > and can be removed. Cleans up clang warning: > > > > drivers/net/ethernet/intel/i40e/i40e_nvm.c:390:6: warning: Value stored > > to 'read_size' during its initialization is never read > > > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > > s/intialization/initialization/g Other than that typo, looks fine: Tested-by: Aaron Brown <aaron.f.brown@intel.com>
diff --git a/drivers/net/ethernet/intel/i40e/i40e_nvm.c b/drivers/net/ethernet/intel/i40e/i40e_nvm.c index 0ccab0a5d717..8f444a40c3f9 100644 --- a/drivers/net/ethernet/intel/i40e/i40e_nvm.c +++ b/drivers/net/ethernet/intel/i40e/i40e_nvm.c @@ -387,7 +387,7 @@ static i40e_status i40e_read_nvm_buffer_aq(struct i40e_hw *hw, u16 offset, u16 *words, u16 *data) { i40e_status ret_code; - u16 read_size = *words; + u16 read_size; bool last_cmd = false; u16 words_read = 0; u16 i = 0;