| Message ID | 1508848852-29396-1-git-send-email-kishanpgondaliya@gmail.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Add missing data type __s8 | expand |
On Tue, Oct 24, 2017 at 06:10:52PM +0530, Kishan Gondaliya wrote: > diff --git a/src/drivers/linux_wext.h b/src/drivers/linux_wext.h > @@ -26,6 +26,7 @@ typedef int32_t __s32; > typedef uint16_t __u16; > typedef int16_t __s16; > typedef uint8_t __u8; > +typedef int8_t __s8; > #ifndef __user > #define __user > #endif /* __user */ Could you please clarify why this is needed? These typedefs in linux_wext.h were added for the purpose of being able to accept the linux/wireless.h header file from the kernel (include/uapi/wireless.h) and that file does not seem to be using __s8.
On Mon, Oct 30, 2017 at 09:59:14AM +0530, Kishan Gondaliya wrote: > Referencing to this issue: https://github.com/openwrt/openwrt/issues/566 > > Build fails for OpenWRT due to missing data type. That's an OpenWrt specific bug that does not show up in upstream hostapd/wpa_supplicant and as such, should not be fixed in hostap.git. Instead, this should be fixed in the OpenWrt patch that causes the issue: package/network/services/hostapd/patches/460-wpa_supplicant-add-new-config-params-to-be-used-with.patch That patch pulls in nl80211_copy.h into driver.h and as such, into compilation of multiple files that should not have anything to do with the nl80211 header. NL80211_* values must not be used in driver.h to keep the interface clean and independent of driver interface specific information.
diff --git a/src/drivers/linux_wext.h b/src/drivers/linux_wext.h index e7c7001..1cb8909 100644 --- a/src/drivers/linux_wext.h +++ b/src/drivers/linux_wext.h @@ -26,6 +26,7 @@ typedef int32_t __s32; typedef uint16_t __u16; typedef int16_t __s16; typedef uint8_t __u8; +typedef int8_t __s8; #ifndef __user #define __user #endif /* __user */
Signed-off-by: Kishan Gondaliya <kishanpgondaliya@gmail.com> --- src/drivers/linux_wext.h | 1 + 1 file changed, 1 insertion(+)