| Message ID | 4CFE16A3.6070903@dsn.okisemi.com |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
On 12/07/2010 12:12 PM, Tomoya MORINAGA wrote: > Since this driver is implemented as NAPI, > netif_receive_skb must be used not netif_rx. > > Signed-off-by: Tomoya MORINAGA <tomoya-linux@dsn.okisemi.com> Looks good. Acked-by: Marc Kleine-Budde <mkl@pengutronix.de> Marc > --- > drivers/net/can/pch_can.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/net/can/pch_can.c b/drivers/net/can/pch_can.c > index 4697b1c..8d45fdd 100644 > --- a/drivers/net/can/pch_can.c > +++ b/drivers/net/can/pch_can.c > @@ -572,7 +572,7 @@ static void pch_can_error(struct net_device *ndev, u32 status) > cf->data[7] = (errc & PCH_REC) >> 8; > > priv->can.state = state; > - netif_rx(skb); > + netif_receive_skb(skb); > > stats->rx_packets++; > stats->rx_bytes += cf->can_dlc;
diff --git a/drivers/net/can/pch_can.c b/drivers/net/can/pch_can.c index 4697b1c..8d45fdd 100644 --- a/drivers/net/can/pch_can.c +++ b/drivers/net/can/pch_can.c @@ -572,7 +572,7 @@ static void pch_can_error(struct net_device *ndev, u32 status) cf->data[7] = (errc & PCH_REC) >> 8; priv->can.state = state; - netif_rx(skb); + netif_receive_skb(skb); stats->rx_packets++; stats->rx_bytes += cf->can_dlc;
Since this driver is implemented as NAPI, netif_receive_skb must be used not netif_rx. Signed-off-by: Tomoya MORINAGA <tomoya-linux@dsn.okisemi.com> --- drivers/net/can/pch_can.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)