Message ID | 20171013061550.996-3-fenglinw@codeaurora.org |
---|---|
State | New |
Headers | show |
Series | [V1,1/2] pinctrl: qcom: spmi-gpio: Read REG_EN_CTL to get initial enable state | expand |
On Thu 12 Oct 23:15 PDT 2017, fenglinw@codeaurora.org wrote: > From: Fenglin Wu <fenglinw@codeaurora.org> > > The initial value of is_enabled flag is read out from hardware in > pmic_gpio_populate(), and it will be set in pmic_gpio_config_set() if > pinconf is defined. For any GPIOs disabled initially in hardware which > only have pinmux defined, they won't be enabled in pmic_gpio_set_mux() > calling. So set is_enabled flag in set_mux() to ensure the GPIO module > could be enabled in above case. > I'm still interested in knowing when it is valid to configure a pin with only mux, no config. I.e. in what cases does setting a alternative function make the pinconfig not count. Regards, Bjorn > Signed-off-by: Fenglin Wu <fenglinw@codeaurora.org> > --- > drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c > index 0a1e173..219c934 100644 > --- a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c > +++ b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c > @@ -312,6 +312,7 @@ static int pmic_gpio_set_mux(struct pinctrl_dev *pctldev, unsigned function, > } > > pad = pctldev->desc->pins[pin].drv_data; > + pad->is_enabled = true; > /* > * Non-LV/MV subtypes only support 2 special functions, > * offsetting the dtestx function values by 2 > -- > Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project. > -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 10/17/2017 6:29 AM, Bjorn Andersson wrote: > On Thu 12 Oct 23:15 PDT 2017, fenglinw@codeaurora.org wrote: > >> From: Fenglin Wu <fenglinw@codeaurora.org> >> >> The initial value of is_enabled flag is read out from hardware in >> pmic_gpio_populate(), and it will be set in pmic_gpio_config_set() if >> pinconf is defined. For any GPIOs disabled initially in hardware which >> only have pinmux defined, they won't be enabled in pmic_gpio_set_mux() >> calling. So set is_enabled flag in set_mux() to ensure the GPIO module >> could be enabled in above case. >> > > I'm still interested in knowing when it is valid to configure a pin with > only mux, no config. I.e. in what cases does setting a alternative > function make the pinconfig not count. I agreed that any pins should be configured with pinmux as well as pinconf, but the driver doesn't prevent the case of only pinmux defined, right? I am not sure if this is valid case but it would happen: The hardware or the sw prior to linux kernel has the default setting of the function and config for one GPIO but we need to keep it disabled until the consumer request it, in this case, we just need to define the pinmux and ignore the pinconf definition in its device node. > > Regards, > Bjorn > >> Signed-off-by: Fenglin Wu <fenglinw@codeaurora.org> >> --- >> drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c >> index 0a1e173..219c934 100644 >> --- a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c >> +++ b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c >> @@ -312,6 +312,7 @@ static int pmic_gpio_set_mux(struct pinctrl_dev *pctldev, unsigned function, >> } >> >> pad = pctldev->desc->pins[pin].drv_data; >> + pad->is_enabled = true; >> /* >> * Non-LV/MV subtypes only support 2 special functions, >> * offsetting the dtestx function values by 2 >> -- >> Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, >> a Linux Foundation Collaborative Project. >> > -- > To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >
On Tue, Oct 17, 2017 at 6:36 AM, Fenglin Wu <fenglinw@codeaurora.org> wrote: > I am not sure if this is valid case but it would happen: The > hardware or the sw prior to linux kernel has the default setting of the > function and config for one GPIO but we need to keep it disabled until > the consumer request it, in this case, we just need to define the pinmux > and ignore the pinconf definition in its device node. This firmware-kernel partitioning of responsibilities makes me nervous every time it happens. Who's in charge really? Who fixes bugs? Firmware? Linux? Linux overriding firmware? Linux overriding firmware on special firmware revisions? Linux overriding firmware on special firmware revisions that cannot be detected and instead needs to be passed as cmdline parmeters? This kind of stuff gives me the creeps and just a general feeling of not being in control having very little clue as to what is really going on in the system. But I guess that is essentially the working assumption for things like ACPI and other behind-my-back firmware: don't worry be happy. Anyways, it's up to Björn to establish what is best for the qcom pin control, I'm just gonna accept whatever he ACKs. Just rambling. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c index 0a1e173..219c934 100644 --- a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c +++ b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c @@ -312,6 +312,7 @@ static int pmic_gpio_set_mux(struct pinctrl_dev *pctldev, unsigned function, } pad = pctldev->desc->pins[pin].drv_data; + pad->is_enabled = true; /* * Non-LV/MV subtypes only support 2 special functions, * offsetting the dtestx function values by 2